From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5556C3DA79 for ; Mon, 26 Dec 2022 22:58:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E7CDB6455; Mon, 26 Dec 2022 23:57:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E7CDB6455 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1672095497; bh=Wti5O+00kVoBmzkKswTPUDc+8JKLmMqF4b5CHt77e60=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=oO+UCFIYy0rmw9njTCG2+J+msHu/lG/5yEUVBoC8vGlEzTy+BTE8lw3L5eOVBoeTy Hb+gmQhjdmQGLiqa+tMZ4vy4/xhFEZuhEhO83LXUNNFJRnHZRMsAzN/mj73ob7av2q a9bxMAsMH3LoRlWFiPcoFFxmfSTZjieHAua05H1Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8FDA1F80310; Mon, 26 Dec 2022 23:57:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DB28EF8042F; Mon, 26 Dec 2022 23:57:24 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 628E1F800F0 for ; Mon, 26 Dec 2022 23:57:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 628E1F800F0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=mM5WMwZZ Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 409FD60EE0; Mon, 26 Dec 2022 22:57:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EAA8C433D2; Mon, 26 Dec 2022 22:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672095438; bh=Wti5O+00kVoBmzkKswTPUDc+8JKLmMqF4b5CHt77e60=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mM5WMwZZSj4y5reqpjVqwaFFLgUdoLXqlSI/D9TJfClLz9ZQo5/wnnnqUVNc8Y25o M0gvOqg3oSboFXCnk7e5VnuFC+29uVViQ6cK/KBXc5BNirjRvcSu2SprbyRkqz4dll 9x7B0LNEXFtTLfI16iX/MWQKFY8dDWViSrfCVSEfH9cQ5GYYFPn7FAL7YIwrAkVRpC N33F6qNE4NV8pjgHQmraElbqgI5P3uLRmqtj+J140r24NriBV8xWK4kHRbuPHOVI6X tntGhtlByw2YUl6rw2o7E8lIn3CdQwZF9oUMTi7hhrDGZTkOTk+QB7SshiT33tXtA5 bu3bd2YHvDggA== Date: Mon, 26 Dec 2022 22:57:12 +0000 From: Mark Brown To: Venkata Prasad Potturu Subject: Re: [PATCH 3/5] ASoC: amd: acp: Refactor dai format implementation Message-ID: References: <20221220072705.1456908-1-venkataprasad.potturu@amd.com> <20221220072705.1456908-4-venkataprasad.potturu@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h5fGREPqKqgMueed" Content-Disposition: inline In-Reply-To: <20221220072705.1456908-4-venkataprasad.potturu@amd.com> X-Cookie: Noone ever built a statue to a critic. X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Sunil-kumar.Dommati@amd.com, ssabakar@amd.com, Ajit Kumar Pandey , ye xingchen , Basavaraj.Hiregoudar@amd.com, Takashi Iwai , Liam Girdwood , Jia-Ju Bai , Akihiko Odaki , Vijendar.Mukunda@amd.com, vsujithkumar.reddy@amd.com, open list Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --h5fGREPqKqgMueed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 20, 2022 at 12:57:03PM +0530, Venkata Prasad Potturu wrote: > Refactor dai format implementation in dai_link specific > snd_soc_ops. This breaks an x86 allmodconfig build: /build/stage/linux/sound/soc/amd/acp/acp-mach-common.c: In function =E2=80= =98acp_card_maxim_hw_params=E2=80=99: /build/stage/linux/sound/soc/amd/acp/acp-mach-common.c:454:13: error: =E2= =80=98drvdata=E2=80=99 undeclared (first use in this function) 454 | if (drvdata->soc_mclk) | ^~~~~~~ /build/stage/linux/sound/soc/amd/acp/acp-mach-common.c:454:13: note: each u= ndeclared identifier is reported only once for each function it appears in --h5fGREPqKqgMueed Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOqJscACgkQJNaLcl1U h9A9WAf7BvZ7QNfzBCPPyXGxrXWwjIKX83E0fKopQpPw+AAwbjjH4TCk8gx1hTC6 GGmNtlgTGDgsSUE6+3/CdvcNBJUw0joK+mjaCZBC3oeAwr4Ku/KlQjRqW82S1Hxd oRT0JlJ/dglR2WhZvgMUlPBbZNLlL0rHuM4ghe8AAfTLBhhigOBQpyFbiYhb2MH8 P2bHd+IQ9U1jVZ8Ejuw5a9XrSHCnbYkpuH9YdaF6HIDGlnTO2f5hT84kbyFBDmtp /7kva/qQzRGLKOec5sF16sizwnNhK6rb7BY9ByiipGR4RHrWmsdi5Q5bDHyz3RTz vZj0Wy8cDERGIrsQlX3hnGc5l77Eiw== =3Fz1 -----END PGP SIGNATURE----- --h5fGREPqKqgMueed-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDADFC3DA79 for ; Mon, 26 Dec 2022 22:58:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232433AbiLZW5k (ORCPT ); Mon, 26 Dec 2022 17:57:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbiLZW5W (ORCPT ); Mon, 26 Dec 2022 17:57:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FD701002 for ; Mon, 26 Dec 2022 14:57:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0B1A3B80DB9 for ; Mon, 26 Dec 2022 22:57:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EAA8C433D2; Mon, 26 Dec 2022 22:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672095438; bh=Wti5O+00kVoBmzkKswTPUDc+8JKLmMqF4b5CHt77e60=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mM5WMwZZSj4y5reqpjVqwaFFLgUdoLXqlSI/D9TJfClLz9ZQo5/wnnnqUVNc8Y25o M0gvOqg3oSboFXCnk7e5VnuFC+29uVViQ6cK/KBXc5BNirjRvcSu2SprbyRkqz4dll 9x7B0LNEXFtTLfI16iX/MWQKFY8dDWViSrfCVSEfH9cQ5GYYFPn7FAL7YIwrAkVRpC N33F6qNE4NV8pjgHQmraElbqgI5P3uLRmqtj+J140r24NriBV8xWK4kHRbuPHOVI6X tntGhtlByw2YUl6rw2o7E8lIn3CdQwZF9oUMTi7hhrDGZTkOTk+QB7SshiT33tXtA5 bu3bd2YHvDggA== Date: Mon, 26 Dec 2022 22:57:12 +0000 From: Mark Brown To: Venkata Prasad Potturu Cc: alsa-devel@alsa-project.org, vsujithkumar.reddy@amd.com, Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, ssabakar@amd.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Ajit Kumar Pandey , Akihiko Odaki , Jia-Ju Bai , ye xingchen , open list Subject: Re: [PATCH 3/5] ASoC: amd: acp: Refactor dai format implementation Message-ID: References: <20221220072705.1456908-1-venkataprasad.potturu@amd.com> <20221220072705.1456908-4-venkataprasad.potturu@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h5fGREPqKqgMueed" Content-Disposition: inline In-Reply-To: <20221220072705.1456908-4-venkataprasad.potturu@amd.com> X-Cookie: Noone ever built a statue to a critic. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --h5fGREPqKqgMueed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 20, 2022 at 12:57:03PM +0530, Venkata Prasad Potturu wrote: > Refactor dai format implementation in dai_link specific > snd_soc_ops. This breaks an x86 allmodconfig build: /build/stage/linux/sound/soc/amd/acp/acp-mach-common.c: In function =E2=80= =98acp_card_maxim_hw_params=E2=80=99: /build/stage/linux/sound/soc/amd/acp/acp-mach-common.c:454:13: error: =E2= =80=98drvdata=E2=80=99 undeclared (first use in this function) 454 | if (drvdata->soc_mclk) | ^~~~~~~ /build/stage/linux/sound/soc/amd/acp/acp-mach-common.c:454:13: note: each u= ndeclared identifier is reported only once for each function it appears in --h5fGREPqKqgMueed Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOqJscACgkQJNaLcl1U h9A9WAf7BvZ7QNfzBCPPyXGxrXWwjIKX83E0fKopQpPw+AAwbjjH4TCk8gx1hTC6 GGmNtlgTGDgsSUE6+3/CdvcNBJUw0joK+mjaCZBC3oeAwr4Ku/KlQjRqW82S1Hxd oRT0JlJ/dglR2WhZvgMUlPBbZNLlL0rHuM4ghe8AAfTLBhhigOBQpyFbiYhb2MH8 P2bHd+IQ9U1jVZ8Ejuw5a9XrSHCnbYkpuH9YdaF6HIDGlnTO2f5hT84kbyFBDmtp /7kva/qQzRGLKOec5sF16sizwnNhK6rb7BY9ByiipGR4RHrWmsdi5Q5bDHyz3RTz vZj0Wy8cDERGIrsQlX3hnGc5l77Eiw== =3Fz1 -----END PGP SIGNATURE----- --h5fGREPqKqgMueed--