From: Johan Hovold <johan@kernel.org>
To: Christina Quast <chrysh@christina-quast.de>
Cc: Christina Quast <contact@christina-quast.de>,
linux-serial@vger.kernel.org, ilpo.jarvinen@linux.intel.com,
gregkh@linuxfoundation.org, daniel.beer@igorinstitute.com
Subject: Re: [PATCH tty-next v2 3/3] hid-ft260: Change u8 to __u8 for hw facing structs
Date: Tue, 27 Dec 2022 10:48:24 +0100 [thread overview]
Message-ID: <Y6q/aN+wfIbvBiOR@hovoldconsulting.com> (raw)
In-Reply-To: <d9c0cc2c-c724-b641-80ce-e31336901410@christina-quast.de>
On Tue, Dec 27, 2022 at 10:32:25AM +0100, Christina Quast wrote:
> Hi Johan!
>
> Thanks for your review. I added this change, because that was GKH's
> comment for the struct ft260_configure_uart_request in e previous
> review of the commit:
>
> And as this is a structure that comes from the device, you should be
> using __u8 and friends.
>
> So you are sure I should remove this change from the patchset? We want
> to continue using u8?
Yes, I believe Greg is mistaken here. He may prefer that style for some
reason, but there's really no need to go about changing existing drivers
to use __u8 for something which is not shared with user space.
Side note: your mailer seems to be sending mails with HTML which will be
rejected by the mailing lists.
> On 12/27/22 09:45, Johan Hovold wrote:
> > On Mon, Dec 26, 2022 at 06:15:49PM +0100, Christina Quast wrote:
> >> Structures that come from a device should use __u8 instead of u8
> >> for their elements. Therefore change all elements in the HID report
> >> structs from u8 to __u8.
> > No, this is not correct. You only need to use __u8 in header files that
> > are shared with user space.
Johan
prev parent reply other threads:[~2022-12-27 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 17:15 [PATCH tty-next v2 0/3] hid-ft260 cleanups Christina Quast
2022-12-26 17:15 ` [PATCH tty-next v2 1/3] hid-ft260: Cleanup macro formatting Christina Quast
2022-12-26 18:00 ` Ilpo Järvinen
2022-12-27 7:25 ` Greg KH
2022-12-26 17:15 ` [PATCH tty-next v2 2/3] hid-ft260: Rename struct ft260_i2c_input_report Christina Quast
2022-12-26 17:15 ` [PATCH tty-next v2 3/3] hid-ft260: Change u8 to __u8 for hw facing structs Christina Quast
2022-12-27 8:45 ` Johan Hovold
[not found] ` <d9c0cc2c-c724-b641-80ce-e31336901410@christina-quast.de>
2022-12-27 9:48 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6q/aN+wfIbvBiOR@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=chrysh@christina-quast.de \
--cc=contact@christina-quast.de \
--cc=daniel.beer@igorinstitute.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.