From: Sasha Levin <sashal@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: stable-commits@vger.kernel.org, johan+linaro@kernel.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: Patch "phy: qcom-qmp-combo: fix runtime suspend" has been added to the 5.15-stable tree
Date: Tue, 27 Dec 2022 08:04:11 -0500 [thread overview]
Message-ID: <Y6rtS7AaQ+EmfD8o@sashalap> (raw)
In-Reply-To: <Y6q3k21nJFWKye76@hovoldconsulting.com>
On Tue, Dec 27, 2022 at 10:14:59AM +0100, Johan Hovold wrote:
>On Sun, Dec 25, 2022 at 10:09:13AM -0500, Sasha Levin wrote:
>> This is a note to let you know that I've just added the patch titled
>>
>> phy: qcom-qmp-combo: fix runtime suspend
>>
>> to the 5.15-stable tree which can be found at:
>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>
>> The filename of the patch is:
>> phy-qcom-qmp-combo-fix-runtime-suspend.patch
>> and it can be found in the queue-5.15 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>>
>>
>>
>> commit d17b3a7b0119f7d92788acbe0f3d3b31bd8f892b
>> Author: Johan Hovold <johan+linaro@kernel.org>
>> Date: Mon Nov 14 09:13:45 2022 +0100
>>
>> phy: qcom-qmp-combo: fix runtime suspend
>>
>> [ Upstream commit c7b98de745cffdceefc077ad5cf9cda032ef8959 ]
>>
>> Drop the confused runtime-suspend type check which effectively broke
>> runtime PM if the DP child node happens to be parsed before the USB
>> child node during probe (e.g. due to order of child nodes in the
>> devicetree).
>>
>> Instead use the new driver data USB PHY pointer to access the USB
>> configuration and resources.
>>
>> Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy")
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>> Link: https://lore.kernel.org/r/20221114081346.5116-6-johan+linaro@kernel.org
>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>This one was not marked for stable and can not be backported without
>further dependencies. This driver did not even exist in 5.15, and no,
>you should no try to backport the split of the original driver either.
I'll drop this patch.
>Sasha, please stop this madness.
So help me understand this... The fixes tag says:
Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy")
52e013d0bffa was merged in v5.10. Does the tag point to the wrong
commit?
--
Thanks,
Sasha
next prev parent reply other threads:[~2022-12-27 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221225150913.691403-1-sashal@kernel.org>
2022-12-27 9:14 ` Patch "phy: qcom-qmp-combo: fix runtime suspend" has been added to the 5.15-stable tree Johan Hovold
2022-12-27 13:04 ` Sasha Levin [this message]
2022-12-27 13:24 ` Johan Hovold
2022-12-27 20:26 ` Sasha Levin
2022-12-28 11:06 ` Johan Hovold
2023-02-03 22:26 [PATCH 5.15.y v3 5/5] phy: qcom-qmp-combo: fix runtime suspend Stephen Boyd
2023-02-07 11:10 ` Patch "phy: qcom-qmp-combo: fix runtime suspend" has been added to the 5.15-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6rtS7AaQ+EmfD8o@sashalap \
--to=sashal@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable-commits@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.