From: Vinod Koul <vkoul@kernel.org>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Set traffic class values in GRPCFG on DSA 2.0
Date: Wed, 28 Dec 2022 12:30:18 +0530 [thread overview]
Message-ID: <Y6vpgh4cGFBG0PB9@matsya> (raw)
In-Reply-To: <20221209172141.562648-1-fenghua.yu@intel.com>
On 09-12-22, 09:21, Fenghua Yu wrote:
> On DSA/IAX 1.0, TC-A and TC-B in GRPCFG are set as 1 to have best
> performance and cannot be changed through sysfs knobs unless override
> option is given.
>
> The same values should be set on DSA 2.0 as well.
Applied, thanks
>
> Fixes: ea7c8f598c32 ("dmaengine: idxd: restore traffic class defaults after wq reset")
> Fixes: ade8a86b512c ("dmaengine: idxd: Set defaults for GRPCFG traffic class")
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/device.c | 2 +-
> drivers/dma/idxd/init.c | 2 +-
> drivers/dma/idxd/sysfs.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index b55405efd4ab..901257081524 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -834,7 +834,7 @@ static void idxd_groups_clear_state(struct idxd_device *idxd)
> group->use_rdbuf_limit = false;
> group->rdbufs_allowed = 0;
> group->rdbufs_reserved = 0;
> - if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override) {
> + if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override) {
> group->tc_a = 1;
> group->tc_b = 1;
> } else {
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index 1053e2bb4e9f..4ecd34200998 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -314,7 +314,7 @@ static int idxd_setup_groups(struct idxd_device *idxd)
> }
>
> idxd->groups[i] = group;
> - if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override) {
> + if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override) {
> group->tc_a = 1;
> group->tc_b = 1;
> } else {
> diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
> index 632166538458..9db35011037f 100644
> --- a/drivers/dma/idxd/sysfs.c
> +++ b/drivers/dma/idxd/sysfs.c
> @@ -388,7 +388,7 @@ static ssize_t group_traffic_class_a_store(struct device *dev,
> if (idxd->state == IDXD_DEV_ENABLED)
> return -EPERM;
>
> - if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override)
> + if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override)
> return -EPERM;
>
> if (val < 0 || val > 7)
> @@ -430,7 +430,7 @@ static ssize_t group_traffic_class_b_store(struct device *dev,
> if (idxd->state == IDXD_DEV_ENABLED)
> return -EPERM;
>
> - if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override)
> + if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override)
> return -EPERM;
>
> if (val < 0 || val > 7)
> --
> 2.32.0
--
~Vinod
prev parent reply other threads:[~2022-12-28 7:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 17:21 [PATCH] dmaengine: idxd: Set traffic class values in GRPCFG on DSA 2.0 Fenghua Yu
2022-12-28 7:00 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6vpgh4cGFBG0PB9@matsya \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.