From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5462C61DB3 for ; Thu, 12 Jan 2023 09:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239703AbjALJ5A (ORCPT ); Thu, 12 Jan 2023 04:57:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239209AbjALJzl (ORCPT ); Thu, 12 Jan 2023 04:55:41 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 55302DFE0; Thu, 12 Jan 2023 01:53:15 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D8AD280A6; Thu, 12 Jan 2023 09:53:13 +0000 (UTC) Date: Thu, 12 Jan 2023 11:53:12 +0200 From: Tony Lindgren To: Arnd Bergmann Cc: Lukas Bulwahn , Aaro Koskinen , Janusz Krzysztofik , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Linux-OMAP , linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] usb: remove OMAP USB Device Controller and OHCI support for OMAP1/2 chips Message-ID: References: <20230112083746.9551-1-lukas.bulwahn@gmail.com> <20230112083746.9551-4-lukas.bulwahn@gmail.com> <3f2663ff-ff3f-4632-853a-ba4d38df9701@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f2663ff-ff3f-4632-853a-ba4d38df9701@app.fastmail.com> Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org * Arnd Bergmann [230112 09:03]: > On Thu, Jan 12, 2023, at 09:37, Lukas Bulwahn wrote: > > Commit 0fee2eac5c2b ("usb: phy: remove phy-isp1301-omap driver") removes > > the Philips ISP1301 with OMAP OTG driver and its corresponding config > > ISP1301_OMAP. The drivers, OMAP USB Device Controller and OHCI support for > > OMAP1/2 chips, with corresponding configs, USB_OMAP and USB_OHCI_HCD_OMAP1, > > need this removed driver (see "depends on ISP1301_OMAP") to build. > > > > Remove those two drivers. > > > > With the config USB_OMAP removed in this commit, remove some further code > > in the omap-dma header and mach-omap1 architecture code. > > > > Signed-off-by: Lukas Bulwahn > > This would be a great cleanup because of the simplications of the > omap-dma code. I had previously looked at it and concluded that > the driver is still in use though, and I think my mistake was > just in the Kconfig part of this patch: It sure would be nice to drop the old custom dma api in omap-dma.c while keeping the dma.c in arch/arm/mach-omap1. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A96E8C54EBD for ; Thu, 12 Jan 2023 09:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fNC6UJaUhx2lsGeNymtn0p6ZEhSZIO+DBP1WE4OOSh4=; b=QH0J0LVsX7tFJ6 R7UW3Ovu3X5wpvK6o2yLbQKnbj7DMPGPCslg1W2VZ9b3wO4hk3LVD8KOmr5cgnnHhx/Xo8J2et1iH DM42ZGQhVkfEmeR3rfv0W0/CxjRIxeWCQhi9VJWnb/2OvGCtrwd/ELbDK12GEre3LOj7lLC9hwIhO KEKst0LoGBzbD7lvoEqK+8LJgruPUaOk8yeDoz1JJwQlHAECvhk3k+0+pl9lX7Wb4cz9yPDpcP8zD lUTD22wOPDy9ZSkbf11Te4rmrQpwHVmHWPtgZIFrMB4oyMl+qgEIVKMX7L8fZzfCyqgW5rCTDEBVM fcDalwXkUNSin/URGUXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFuGv-00ESxt-0k; Thu, 12 Jan 2023 09:53:21 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFuGq-00ESwQ-T0 for linux-arm-kernel@lists.infradead.org; Thu, 12 Jan 2023 09:53:18 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D8AD280A6; Thu, 12 Jan 2023 09:53:13 +0000 (UTC) Date: Thu, 12 Jan 2023 11:53:12 +0200 From: Tony Lindgren To: Arnd Bergmann Cc: Lukas Bulwahn , Aaro Koskinen , Janusz Krzysztofik , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Linux-OMAP , linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] usb: remove OMAP USB Device Controller and OHCI support for OMAP1/2 chips Message-ID: References: <20230112083746.9551-1-lukas.bulwahn@gmail.com> <20230112083746.9551-4-lukas.bulwahn@gmail.com> <3f2663ff-ff3f-4632-853a-ba4d38df9701@app.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3f2663ff-ff3f-4632-853a-ba4d38df9701@app.fastmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_015317_011638_9CE53C90 X-CRM114-Status: GOOD ( 16.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Arnd Bergmann [230112 09:03]: > On Thu, Jan 12, 2023, at 09:37, Lukas Bulwahn wrote: > > Commit 0fee2eac5c2b ("usb: phy: remove phy-isp1301-omap driver") removes > > the Philips ISP1301 with OMAP OTG driver and its corresponding config > > ISP1301_OMAP. The drivers, OMAP USB Device Controller and OHCI support for > > OMAP1/2 chips, with corresponding configs, USB_OMAP and USB_OHCI_HCD_OMAP1, > > need this removed driver (see "depends on ISP1301_OMAP") to build. > > > > Remove those two drivers. > > > > With the config USB_OMAP removed in this commit, remove some further code > > in the omap-dma header and mach-omap1 architecture code. > > > > Signed-off-by: Lukas Bulwahn > > This would be a great cleanup because of the simplications of the > omap-dma code. I had previously looked at it and concluded that > the driver is still in use though, and I think my mistake was > just in the Kconfig part of this patch: It sure would be nice to drop the old custom dma api in omap-dma.c while keeping the dma.c in arch/arm/mach-omap1. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel