From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97953C61DB3 for ; Thu, 12 Jan 2023 10:26:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237483AbjALK0V (ORCPT ); Thu, 12 Jan 2023 05:26:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237183AbjALKZk (ORCPT ); Thu, 12 Jan 2023 05:25:40 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4243237391 for ; Thu, 12 Jan 2023 02:20:15 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9081480A6; Thu, 12 Jan 2023 10:20:14 +0000 (UTC) Date: Thu, 12 Jan 2023 12:20:13 +0200 From: Tony Lindgren To: Adam Ford Cc: Linux-OMAP Subject: Re: AM3517 Failed to request pm_wkup irq Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, * Adam Ford [230105 18:32]: > When booting the AM3517-EVM, I get a few errors related to the pm. > > [ 2.038452] pm: Failed to request pm_wkup irq > [ 2.042846] omap2_common_pm_late_init: pm soc init failed: -22 > > omap3_pm_init inside pm34xx.c calls omap_prcm_event_to_irq looking for > "wkup" which returns EINVAL . > > Inside omap_prm.c, there are a bunch of data structures for > omap_prm_data which contain for various boards for AM3, AM4, omap4, > omap5 and dra7, but a reference to ti,omap3-prm-inst appears to be > missing. I looked at the TRM for the AM335X, and i can clearly see a > nice table with addresses that correspond to the tables found in > omap_prm.c, but after looking at both a DM3730 and AM3517 TRM, I am > not seeing a corresponding L4_WKUP Peripheral Memory map. > > If someone can point me in the right direction, I can try to setup the > OMAP3 tables accordingly. The older SoCs set up the prm wakeup via omap3_prcm_irq_setup. Ideally this would be nowadays done using dts and driver/irqchip though. Maybe see omap3xxx_check_features() and try adding flags for OMAP3_HAS_IO_WAKEUP for am3517? Likely this is the same as for 34xx. It may also have OMAP3_HAS_IO_CHAIN_CTRL like 36xx, but likely not. Regards, Tony