From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF5DEC67871 for ; Thu, 12 Jan 2023 11:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229549AbjALLJN (ORCPT ); Thu, 12 Jan 2023 06:09:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229899AbjALLIR (ORCPT ); Thu, 12 Jan 2023 06:08:17 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 79EDD23C; Thu, 12 Jan 2023 03:00:47 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 556C8AD7; Thu, 12 Jan 2023 03:01:29 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.43.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E28033F67D; Thu, 12 Jan 2023 03:00:44 -0800 (PST) Date: Thu, 12 Jan 2023 11:00:35 +0000 From: Mark Rutland To: Li Huafei Cc: catalin.marinas@arm.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, mhiramat@kernel.org, ndesaulniers@google.com, ojeda@kernel.org, peterz@infradead.org, rafael.j.wysocki@intel.com, revest@chromium.org, robert.moore@intel.com, rostedt@goodmis.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/8] ftrace: Add DYNAMIC_FTRACE_WITH_CALL_OPS Message-ID: References: <20230109135828.879136-1-mark.rutland@arm.com> <20230109135828.879136-5-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jan 12, 2023 at 02:48:45PM +0800, Li Huafei wrote: > On 2023/1/9 21:58, Mark Rutland wrote: > > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > > index 99f1146614c04..5eeb2776124c5 100644 > > --- a/include/linux/ftrace.h > > +++ b/include/linux/ftrace.h > > @@ -57,6 +57,9 @@ void arch_ftrace_ops_list_func(unsigned long ip, unsigned long parent_ip); > > void arch_ftrace_ops_list_func(unsigned long ip, unsigned long parent_ip, > > struct ftrace_ops *op, struct ftrace_regs *fregs); > > #endif > > +extern const struct ftrace_ops ftrace_nop_ops; > > +extern const struct ftrace_ops ftrace_list_ops; > > +struct ftrace_ops *ftrace_find_unique_ops(struct dyn_ftrace *rec); > > Hi Mark, Hi Huafei, Thanks for the reporrt. > This patch has build issues on x86: > > CC mm/readahead.o > In file included from include/linux/perf_event.h:52:0, > from arch/x86/events/amd/lbr.c:2: > include/linux/ftrace.h:62:50: error: ‘struct dyn_ftrace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > struct ftrace_ops *ftrace_find_unique_ops(struct dyn_ftrace *rec); > > Here we should need 'struct dyn_ftrace' forward declaration. The build robot spotted this a couple of days ago (from my branch rather than the list), and I fixed it there a couple of days ago. The relevant messages were: https://lore.kernel.org/oe-kbuild-all/202301100944.E0mV3kSO-lkp@intel.com/ https://lore.kernel.org/oe-kbuild-all/Y72TJ3qQuvx3gIOi@FVFF77S0Q05N/#t ... and the updated commit is at: https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=arm64/ftrace/per-callsite-ops&id=acab29d6ea2f20d8d156cdd301ad9790bd1d888f ... I'll post a v2 with that folded in once this has had a bit more time to gather comments. Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D3EEC54EBC for ; Thu, 12 Jan 2023 11:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n2kSTS8+eMFB1QWZPfmb0U7+d6IEWWOomEaV4DHcUpY=; b=IW7mXrghUVQR2C A6Mgv/F3RJjcLzVrOQklhbAFJZlrrAJr3az69zK9oHQLSzQOYgbPpQQ/za2y1OEXwDbl8sTs+0HmX 47AiV4X9RvMzsWe6hjuCL0ptjq6v8b1OJuLyeAKr/qAyYO7Gx6/DABNMV/hwUQ5S3znpB3Unwdbhi NNonuoAODJcO52gn9UBHPZKq1GWnuosn/IhhVh0IWvGyNJCOAD78tQvi3iel4HaWjXLqOVqRYuCr7 W/5ogXabcXjuLxnparXGX+Mq7QXXXzZcUB0vNgxdnUFKUnBLvPbdH+B/RPVOszmA0xo/UU+dtiJva URi0htXVFAXAh8Q9/KMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFvKM-00Eiqp-SQ; Thu, 12 Jan 2023 11:01:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFvKH-00Eimx-Hm for linux-arm-kernel@lists.infradead.org; Thu, 12 Jan 2023 11:00:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 556C8AD7; Thu, 12 Jan 2023 03:01:29 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.43.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E28033F67D; Thu, 12 Jan 2023 03:00:44 -0800 (PST) Date: Thu, 12 Jan 2023 11:00:35 +0000 From: Mark Rutland To: Li Huafei Cc: catalin.marinas@arm.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, mhiramat@kernel.org, ndesaulniers@google.com, ojeda@kernel.org, peterz@infradead.org, rafael.j.wysocki@intel.com, revest@chromium.org, robert.moore@intel.com, rostedt@goodmis.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/8] ftrace: Add DYNAMIC_FTRACE_WITH_CALL_OPS Message-ID: References: <20230109135828.879136-1-mark.rutland@arm.com> <20230109135828.879136-5-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_030053_677366_C0DAE67E X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKYW4gMTIsIDIwMjMgYXQgMDI6NDg6NDVQTSArMDgwMCwgTGkgSHVhZmVpIHdyb3Rl Ogo+IE9uIDIwMjMvMS85IDIxOjU4LCBNYXJrIFJ1dGxhbmQgd3JvdGU6Cj4gCj4gPiBkaWZmIC0t Z2l0IGEvaW5jbHVkZS9saW51eC9mdHJhY2UuaCBiL2luY2x1ZGUvbGludXgvZnRyYWNlLmgKPiA+ IGluZGV4IDk5ZjExNDY2MTRjMDQuLjVlZWIyNzc2MTI0YzUgMTAwNjQ0Cj4gPiAtLS0gYS9pbmNs dWRlL2xpbnV4L2Z0cmFjZS5oCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4L2Z0cmFjZS5oCj4gPiBA QCAtNTcsNiArNTcsOSBAQCB2b2lkIGFyY2hfZnRyYWNlX29wc19saXN0X2Z1bmModW5zaWduZWQg bG9uZyBpcCwgdW5zaWduZWQgbG9uZyBwYXJlbnRfaXApOwo+ID4gIHZvaWQgYXJjaF9mdHJhY2Vf b3BzX2xpc3RfZnVuYyh1bnNpZ25lZCBsb25nIGlwLCB1bnNpZ25lZCBsb25nIHBhcmVudF9pcCwK PiA+ICAJCQkgICAgICAgc3RydWN0IGZ0cmFjZV9vcHMgKm9wLCBzdHJ1Y3QgZnRyYWNlX3JlZ3Mg KmZyZWdzKTsKPiA+ICAjZW5kaWYKPiA+ICtleHRlcm4gY29uc3Qgc3RydWN0IGZ0cmFjZV9vcHMg ZnRyYWNlX25vcF9vcHM7Cj4gPiArZXh0ZXJuIGNvbnN0IHN0cnVjdCBmdHJhY2Vfb3BzIGZ0cmFj ZV9saXN0X29wczsKPiA+ICtzdHJ1Y3QgZnRyYWNlX29wcyAqZnRyYWNlX2ZpbmRfdW5pcXVlX29w cyhzdHJ1Y3QgZHluX2Z0cmFjZSAqcmVjKTsKPiAKPiBIaSBNYXJrLAoKSGkgSHVhZmVpLAoKVGhh bmtzIGZvciB0aGUgcmVwb3JydC4KCj4gVGhpcyBwYXRjaCBoYXMgYnVpbGQgaXNzdWVzIG9uIHg4 NjoKPiAKPiAgICAgQ0MgICAgICBtbS9yZWFkYWhlYWQubwo+ICAgSW4gZmlsZSBpbmNsdWRlZCBm cm9tIGluY2x1ZGUvbGludXgvcGVyZl9ldmVudC5oOjUyOjAsCj4gICAgICAgICAgICAgICAgICAg IGZyb20gYXJjaC94ODYvZXZlbnRzL2FtZC9sYnIuYzoyOgo+ICAgaW5jbHVkZS9saW51eC9mdHJh Y2UuaDo2Mjo1MDogZXJyb3I6IOKAmHN0cnVjdCBkeW5fZnRyYWNl4oCZIGRlY2xhcmVkIGluc2lk ZSBwYXJhbWV0ZXIgbGlzdCB3aWxsIG5vdCBiZSB2aXNpYmxlIG91dHNpZGUgb2YgdGhpcyBkZWZp bml0aW9uIG9yIGRlY2xhcmF0aW9uIFstV2Vycm9yXQo+ICAgIHN0cnVjdCBmdHJhY2Vfb3BzICpm dHJhY2VfZmluZF91bmlxdWVfb3BzKHN0cnVjdCBkeW5fZnRyYWNlICpyZWMpOwo+IAo+IEhlcmUg d2Ugc2hvdWxkIG5lZWQgJ3N0cnVjdCBkeW5fZnRyYWNlJyBmb3J3YXJkIGRlY2xhcmF0aW9uLgoK VGhlIGJ1aWxkIHJvYm90IHNwb3R0ZWQgdGhpcyBhIGNvdXBsZSBvZiBkYXlzIGFnbyAoZnJvbSBt eSBicmFuY2ggcmF0aGVyIHRoYW4KdGhlIGxpc3QpLCBhbmQgSSBmaXhlZCBpdCB0aGVyZSBhIGNv dXBsZSBvZiBkYXlzIGFnby4gVGhlIHJlbGV2YW50IG1lc3NhZ2VzIHdlcmU6CgogIGh0dHBzOi8v bG9yZS5rZXJuZWwub3JnL29lLWtidWlsZC1hbGwvMjAyMzAxMTAwOTQ0LkUwbVYza1NPLWxrcEBp bnRlbC5jb20vCiAgaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvb2Uta2J1aWxkLWFsbC9ZNzJUSjNx UXV2eDNnSU9pQEZWRkY3N1MwUTA1Ti8jdAoKLi4uIGFuZCB0aGUgdXBkYXRlZCBjb21taXQgaXMg YXQ6CgogIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L21h cmsvbGludXguZ2l0L2NvbW1pdC8/aD1hcm02NC9mdHJhY2UvcGVyLWNhbGxzaXRlLW9wcyZpZD1h Y2FiMjlkNmVhMmYyMGQ4ZDE1NmNkZDMwMWFkOTc5MGJkMWQ4ODhmCgoKLi4uIEknbGwgcG9zdCBh IHYyIHdpdGggdGhhdCBmb2xkZWQgaW4gb25jZSB0aGlzIGhhcyBoYWQgYSBiaXQgbW9yZSB0aW1l IHRvIGdhdGhlciBjb21tZW50cy4KClRoYW5rcywJCk1hcmsuCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==