From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99989C54EBD for ; Thu, 12 Jan 2023 11:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbjALLPY (ORCPT ); Thu, 12 Jan 2023 06:15:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232440AbjALLOa (ORCPT ); Thu, 12 Jan 2023 06:14:30 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B3BBD1177 for ; Thu, 12 Jan 2023 03:06:58 -0800 (PST) Date: Thu, 12 Jan 2023 12:06:55 +0100 From: Pablo Neira Ayuso To: Phil Sutter , Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [nf-next PATCH v2] netfilter: nf_tables: Introduce NFTA_RULE_ACTUAL_EXPR Message-ID: References: <20221221142221.27211-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Jan 12, 2023 at 11:15:10AM +0100, Phil Sutter wrote: > Bump? > > On Wed, Dec 21, 2022 at 03:22:21PM +0100, Phil Sutter wrote: > > Allow for user space to provide an improved variant of the rule for > > actual use. The variant in NFTA_RULE_EXPRESSIONS may provide maximum > > compatibility for old user space tools (e.g. in outdated containers). > > > > The new attribute is also dumped back to user space, e.g. for comparison > > against the compatible variant. > > > > While being at it, improve nft_rule_policy for NFTA_RULE_EXPRESSIONS. Could you split this in two patches? I still don't see how this is improving the situation for the scenario you describe, if you could extend a bit on how you plan to use this I'd appreciate. Thanks.