From: Sabrina Dubroca <sd@queasysnail.net>
To: ehakim@nvidia.com
Cc: dsahern@kernel.org, netdev@vger.kernel.org,
Raed Salem <raeds@nvidia.com>
Subject: Re: [PATCH main 1/1] macsec: Fix Macsec replay protection
Date: Tue, 10 Jan 2023 11:02:03 +0100 [thread overview]
Message-ID: <Y703mx5EEjQyH8Fu@hog> (raw)
In-Reply-To: <20230110080218.18799-1-ehakim@nvidia.com>
2023-01-10, 10:02:19 +0200, ehakim@nvidia.com wrote:
> @@ -1516,7 +1515,7 @@ static int macsec_parse_opt(struct link_util *lu, int argc, char **argv,
> addattr_l(n, MACSEC_BUFLEN, IFLA_MACSEC_ICV_LEN,
> &cipher.icv_len, sizeof(cipher.icv_len));
>
> - if (replay_protect != -1) {
> + if (replay_protect) {
This will silently break disabling replay protection on an existing
device. This:
ip link set macsec0 type macsec replay off
would now appear to succeed but will not do anything. That's why I
used an int with -1 in iproute, and a U8 netlink attribute rather a
flag.
I think this would be a better fix:
if (replay_protect != -1) {
- addattr32(n, MACSEC_BUFLEN, IFLA_MACSEC_WINDOW, window);
+ if (replay_protect)
+ addattr32(n, MACSEC_BUFLEN, IFLA_MACSEC_WINDOW, window);
addattr8(n, MACSEC_BUFLEN, IFLA_MACSEC_REPLAY_PROTECT,
replay_protect);
}
Does that work for all your test cases?
> addattr32(n, MACSEC_BUFLEN, IFLA_MACSEC_WINDOW, window);
> addattr8(n, MACSEC_BUFLEN, IFLA_MACSEC_REPLAY_PROTECT,
> replay_protect);
--
Sabrina
next prev parent reply other threads:[~2023-01-10 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 8:02 [PATCH main 1/1] macsec: Fix Macsec replay protection ehakim
2023-01-10 10:02 ` Sabrina Dubroca [this message]
2023-01-10 11:23 ` Emeel Hakim
2023-01-10 12:03 ` Sabrina Dubroca
2023-01-10 13:38 ` Emeel Hakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y703mx5EEjQyH8Fu@hog \
--to=sd@queasysnail.net \
--cc=dsahern@kernel.org \
--cc=ehakim@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=raeds@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.