From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-block@nongnu.org, jsnow@redhat.com, crosa@redhat.com,
kwolf@redhat.com, hreitz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 02/11] python/qemu: rename command() to cmd()
Date: Tue, 10 Jan 2023 10:53:28 +0000 [thread overview]
Message-ID: <Y71DqHAgg/Wvbz7+@redhat.com> (raw)
In-Reply-To: <20230110083758.161201-3-vsementsov@yandex-team.ru>
On Tue, Jan 10, 2023 at 11:37:49AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Use a shorter name. We are going to move in iotests from qmp() to
> command() where possible. But command() is longer than qmp() and don't
> look better. Let's rename.
>
> You can simply grep for '\.command(' and for 'def command(' to check
> that everything is updated (command() in tests/docker/docker.py is
> unrelated).
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> docs/devel/testing.rst | 10 +-
> python/qemu/machine/machine.py | 8 +-
> python/qemu/qmp/legacy.py | 2 +-
> python/qemu/qmp/qmp_shell.py | 2 +-
> python/qemu/utils/qemu_ga_client.py | 2 +-
> python/qemu/utils/qom.py | 8 +-
> python/qemu/utils/qom_common.py | 2 +-
> python/qemu/utils/qom_fuse.py | 6 +-
> scripts/cpu-x86-uarch-abi.py | 8 +-
> scripts/device-crash-test | 8 +-
> scripts/render_block_graph.py | 8 +-
> tests/avocado/avocado_qemu/__init__.py | 4 +-
> tests/avocado/cpu_queries.py | 5 +-
> tests/avocado/hotplug_cpu.py | 10 +-
> tests/avocado/info_usernet.py | 4 +-
> tests/avocado/machine_arm_integratorcp.py | 6 +-
> tests/avocado/machine_m68k_nextcube.py | 4 +-
> tests/avocado/machine_mips_malta.py | 6 +-
> tests/avocado/machine_s390_ccw_virtio.py | 28 ++--
> tests/avocado/migration.py | 10 +-
> tests/avocado/pc_cpu_hotplug_props.py | 2 +-
> tests/avocado/version.py | 4 +-
> tests/avocado/virtio_check_params.py | 6 +-
> tests/avocado/virtio_version.py | 5 +-
> tests/avocado/x86_cpu_model_versions.py | 13 +-
> tests/migration/guestperf/engine.py | 150 +++++++++++-----------
> tests/qemu-iotests/256 | 34 ++---
> tests/qemu-iotests/257 | 36 +++---
> 28 files changed, 198 insertions(+), 193 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-01-10 11:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 8:37 [PATCH v4 00/11] iotests: use vm.cmd() Vladimir Sementsov-Ogievskiy
2023-01-10 8:37 ` [PATCH v4 01/11] python: rename QEMUMonitorProtocol.cmd() to cmd_raw() Vladimir Sementsov-Ogievskiy
2023-01-10 10:49 ` Daniel P. Berrangé
2023-01-10 13:24 ` Vladimir Sementsov-Ogievskiy
2023-01-10 8:37 ` [PATCH v4 02/11] python/qemu: rename command() to cmd() Vladimir Sementsov-Ogievskiy
2023-01-10 10:53 ` Daniel P. Berrangé [this message]
2023-01-10 8:37 ` [PATCH v4 03/11] python/machine.py: upgrade vm.cmd() method Vladimir Sementsov-Ogievskiy
2023-01-10 8:37 ` [PATCH v4 04/11] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine Vladimir Sementsov-Ogievskiy
2023-01-10 19:13 ` John Snow
2023-01-10 8:37 ` [PATCH v4 05/11] iotests: add some missed checks of qmp result Vladimir Sementsov-Ogievskiy
2023-01-10 8:37 ` [PATCH v4 06/11] iotests: refactor some common qmp result checks into generic pattern Vladimir Sementsov-Ogievskiy
2023-01-10 8:37 ` [PATCH v4 07/11] iotests: drop some occasional semicolons Vladimir Sementsov-Ogievskiy
2023-01-10 8:37 ` [PATCH v4 08/11] iotests: drop some extra ** in qmp() call Vladimir Sementsov-Ogievskiy
2023-01-10 8:37 ` [PATCH v4 09/11] iotests.py: pause_job(): drop return value Vladimir Sementsov-Ogievskiy
2023-01-10 8:37 ` [PATCH v4 10/11] tests/vm/basevm.py: use cmd() instead of qmp() Vladimir Sementsov-Ogievskiy
2023-01-10 8:37 ` [PATCH v4 11/11] python: use vm.cmd() instead of vm.qmp() where appropriate Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y71DqHAgg/Wvbz7+@redhat.com \
--to=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.