From: Greg KH <gregkh@linuxfoundation.org>
To: Tyler Hicks <code@tyhicks.com>
Cc: stable@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>,
Muhammad Usama Anjum <usama.anjum@collabora.com>
Subject: Re: [PATCH 5.15 5.10 1/1] selftests: set the BUILD variable to absolute path
Date: Tue, 10 Jan 2023 16:49:35 +0100 [thread overview]
Message-ID: <Y72JDysNVItMWrcF@kroah.com> (raw)
In-Reply-To: <20230106220816.763835-2-code@tyhicks.com>
On Fri, Jan 06, 2023 at 04:08:16PM -0600, Tyler Hicks wrote:
> From: Muhammad Usama Anjum <usama.anjum@collabora.com>
>
> commit 5ad51ab618de5d05f4e692ebabeb6fe6289aaa57 upstream.
>
> The build of kselftests fails if relative path is specified through
> KBUILD_OUTPUT or O=<path> method. BUILD variable is used to determine
> the path of the output objects. When make is run from other directories
> with relative paths, the exact path of the build objects is ambiguous
> and build fails.
>
> make[1]: Entering directory '/home/usama/repos/kernel/linux_mainline2/tools/testing/selftests/alsa'
> gcc mixer-test.c -L/usr/lib/x86_64-linux-gnu -lasound -o build/kselftest/alsa/mixer-test
> /usr/bin/ld: cannot open output file build/kselftest/alsa/mixer-test
>
> Set the BUILD variable to the absolute path of the output directory.
> Make the logic readable and easy to follow. Use spaces instead of tabs
> for indentation as if with tab indentation is considered recipe in make.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Tyler Hicks (Microsoft) <code@tyhicks.com>
> ---
> tools/testing/selftests/Makefile | 26 +++++++++++++++++---------
> 1 file changed, 17 insertions(+), 9 deletions(-)
>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-01-10 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 22:08 [PATCH 5.15 5.10 0/1] Fix kselftest builds when specifying an output dir Tyler Hicks
2023-01-06 22:08 ` [PATCH 5.15 5.10 1/1] selftests: set the BUILD variable to absolute path Tyler Hicks
2023-01-10 15:49 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y72JDysNVItMWrcF@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=code@tyhicks.com \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.