From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80356C677F1 for ; Wed, 11 Jan 2023 02:13:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235542AbjAKCNl (ORCPT ); Tue, 10 Jan 2023 21:13:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235245AbjAKCNb (ORCPT ); Tue, 10 Jan 2023 21:13:31 -0500 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C85F64C7; Tue, 10 Jan 2023 18:13:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=njrrmruQDIC0in34qwfwYVLn81yNCbta3wj2UCVqMgs=; b=nh0gZtN2mPu3w5awxIzCHyCM0m VL7XTrWSWP/T3pXS1JaWh6hTp9KvW6KHDhtX2kyiA8TwA81F6Pqp6MN5fkdOW8mYBgv4PdAWlhPV5 HO78Fcczxdyq35HLxMLDtwOodiZ2yh6krPSU706FcQ7hzKU0gDz3zzYBXr4hSNnWGOVbwrT1cmA6r h5aEO9JLRpDpneToikJt11IFS/KVgwbXQlCgNlO11DGxO0Y2XrcTxJzCJg+0AhCT1uzgmJS00241D 6QuZTgwjKcGVUzNQkX9fB3CfMoLRZ8ZIWrKz6eEqMFO7wlHlPvRp3Rsm1EAfnwwOVh84wSPT+W1vT xRc2VA1g==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pFQbO-0016Yj-2p; Wed, 11 Jan 2023 02:12:31 +0000 Date: Wed, 11 Jan 2023 02:12:30 +0000 From: Al Viro To: Jeff Layton Cc: Russell King , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Xiubo Li , Ilya Dryomov , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Christine Caulfield , David Teigland , Chuck Lever , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Namjae Jeon , Sergey Senozhatsky , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , "Darrick J. Wong" , Christian Brauner , Christoph Hellwig , Steve French , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v2] filelock: move file locking definitions to separate header file Message-ID: References: <20230105211937.1572384-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105211937.1572384-1-jlayton@kernel.org> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Thu, Jan 05, 2023 at 04:19:29PM -0500, Jeff Layton wrote: > The file locking definitions have lived in fs.h since the dawn of time, > but they are only used by a small subset of the source files that > include it. > > Move the file locking definitions to a new header file, and add the > appropriate #include directives to the source files that need them. By > doing this we trim down fs.h a bit and limit the amount of rebuilding > that has to be done when we make changes to the file locking APIs. > > Reviewed-by: Xiubo Li > Reviewed-by: Christian Brauner (Microsoft) > Reviewed-by: Christoph Hellwig > Reviewed-by: David Howells > Acked-by: Chuck Lever > Acked-by: Joseph Qi > Acked-by: Steve French > Signed-off-by: Jeff Layton Same question re git tree preferences (and my Acked-by in any case) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Wed, 11 Jan 2023 02:12:30 +0000 Subject: [Cluster-devel] [PATCH v2] filelock: move file locking definitions to separate header file In-Reply-To: <20230105211937.1572384-1-jlayton@kernel.org> References: <20230105211937.1572384-1-jlayton@kernel.org> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jan 05, 2023 at 04:19:29PM -0500, Jeff Layton wrote: > The file locking definitions have lived in fs.h since the dawn of time, > but they are only used by a small subset of the source files that > include it. > > Move the file locking definitions to a new header file, and add the > appropriate #include directives to the source files that need them. By > doing this we trim down fs.h a bit and limit the amount of rebuilding > that has to be done when we make changes to the file locking APIs. > > Reviewed-by: Xiubo Li > Reviewed-by: Christian Brauner (Microsoft) > Reviewed-by: Christoph Hellwig > Reviewed-by: David Howells > Acked-by: Chuck Lever > Acked-by: Joseph Qi > Acked-by: Steve French > Signed-off-by: Jeff Layton Same question re git tree preferences (and my Acked-by in any case) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aib29ajc253.phx1.oracleemaildelivery.com (aib29ajc253.phx1.oracleemaildelivery.com [192.29.103.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10ACAC61DB3 for ; Wed, 11 Jan 2023 02:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oss-phx-1109; d=oss.oracle.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=+FTeHpSf5Cf3H9lNPV3jAepmaeEHh7NZR7FuXIOprhI=; b=BgKSNq81AFO4xs4q5N70aePj+oeahZcXOAr0bZgr8dMHAoWGxu6c5z2iBNGbQVOHqwkp/Qn4IvAM TW3NN8joEtRoeMs7Ptrf3wCUzLnLjJ1osqiU4/WcHhATfw/cYbix9rNGga57cM/eY7KRSWLP+0Sc BU7/I988NNKwUD8QK5abWwk5UBEbBWYvMIXf3vKGFf9St7J7JkgKryKTdr1JOiZISTjWecM9GdbJ Lr4wBGQUdiFSvCi3S6NcmZUx0NJ/QhwLrtpjwH2eizXqmljT6GZoNAChm/g3bTBApqiLySkwOEs+ qFfCzox/m0l4KB7+GDRkSNEnIMCN9yDgkKAMEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-phx-20191217; d=phx1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=+FTeHpSf5Cf3H9lNPV3jAepmaeEHh7NZR7FuXIOprhI=; b=udAVAw1mSx5lbH4DD52jA2LAXEF+s/IdX24MJ1XiaPbosu5ZA86GgqPkfl8lq8MU+hX4/iiH0vbH /H7MWSMtl12ny4kNO+NYdBcu5IRgu694on8R9xCob01gwmW55vh/SY0IWwCdR7JU8Q0AelZjEC+H nwAW6U/oVVjo2KGFBC4nGbqhtgjlOqT4xFWYgps4HDNbIDxPbIZKhQy1lRA9Kq0FxDO5khc/Hm6l fx38Ws7FYSE33TwXDWqTUIUDKObXRyzZQgTyFnyiPctWH9kqhMwJdamdjecfUWzPSdrJWxlDG0// e8RcmeHuvJCXQH04RTPyT1a41A+F4fu6RULsBQ== Received: by omta-ad3-fd1-302-us-phoenix-1.omtaad3.vcndpphx.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20221212 64bit (built Dec 12 2022)) with ESMTPS id <0ROA00LCBVAA6T40@omta-ad3-fd1-302-us-phoenix-1.omtaad3.vcndpphx.oraclevcn.com> for ocfs2-devel@archiver.kernel.org; Wed, 11 Jan 2023 02:37:22 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=njrrmruQDIC0in34qwfwYVLn81yNCbta3wj2UCVqMgs=; b=nh0gZtN2mPu3w5awxIzCHyCM0m VL7XTrWSWP/T3pXS1JaWh6hTp9KvW6KHDhtX2kyiA8TwA81F6Pqp6MN5fkdOW8mYBgv4PdAWlhPV5 HO78Fcczxdyq35HLxMLDtwOodiZ2yh6krPSU706FcQ7hzKU0gDz3zzYBXr4hSNnWGOVbwrT1cmA6r h5aEO9JLRpDpneToikJt11IFS/KVgwbXQlCgNlO11DGxO0Y2XrcTxJzCJg+0AhCT1uzgmJS00241D 6QuZTgwjKcGVUzNQkX9fB3CfMoLRZ8ZIWrKz6eEqMFO7wlHlPvRp3Rsm1EAfnwwOVh84wSPT+W1vT xRc2VA1g==; Date: Wed, 11 Jan 2023 02:12:30 +0000 To: Jeff Layton Message-id: References: <20230105211937.1572384-1-jlayton@kernel.org> MIME-version: 1.0 Content-disposition: inline In-reply-to: <20230105211937.1572384-1-jlayton@kernel.org> X-Source-IP: 62.89.141.173 X-Proofpoint-Virus-Version: vendor=nai engine=6500 definitions=10586 signatures=596816 X-Proofpoint-Spam-Details: rule=tap_notspam policy=tap score=0 bulkscore=0 mlxlogscore=999 clxscore=102 lowpriorityscore=0 malwarescore=0 phishscore=0 mlxscore=0 priorityscore=156 spamscore=0 impostorscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301110014 Cc: Latchesar Ionkov , Martin Brandenburg , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , linux-xfs@vger.kernel.org, Mike Marshall , linux-cifs@vger.kernel.org, Andreas Gruenbacher , Miklos Szeredi , Russell King , linux-afs@lists.infradead.org, cluster-devel@redhat.com, Christine Caulfield , v9fs-developer@lists.sourceforge.net, Ilya Dryomov , Namjae Jeon , devel@lists.orangefs.org, Shyam Prasad N , Eric Van Hensbergen , linux-nfs@vger.kernel.org, Tom Talpey , linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, Xiubo Li , Trond Myklebust , linux-arm-kernel@lists.infradead.org, Christian Brauner , Paulo Alcantara , samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Ronnie Sahlberg , Steve French , Sergey Senozhatsky , Chuck Lever , ocfs2-devel@oss.oracle.com, Anna Schumaker , Bob Peterson , Steve French Subject: Re: [Ocfs2-devel] [PATCH v2] filelock: move file locking definitions to separate header file X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Al Viro via Ocfs2-devel Reply-to: Al Viro Content-type: text/plain; charset="us-ascii" Content-transfer-encoding: 7bit Errors-to: ocfs2-devel-bounces@oss.oracle.com X-ServerName: zeniv.linux.org.uk X-Proofpoint-SPF-Result: None X-Spam: Clean X-Proofpoint-ORIG-GUID: XApzEcwMt6P-E3procTsYePyDBYtRDuo X-Proofpoint-GUID: XApzEcwMt6P-E3procTsYePyDBYtRDuo X-Mailman-Approved-At: Wed, 11 Jan 2023 02:37:20 +0000 Reporting-Meta: AAFkFsCnDP+7uI/3BTjmHG6stlEkEjkn9DR78+kok5LLjKYszsXa1OO3iAXNUSV5 A3vzw+fKEBmGOKbNMDu8Fmc0tDXaluqr2iKkp/gREvTdJZM3B6fgW+U4maoATpiP XIrwnsKwsgP8CwxmlVFBelJRoWy6c/hQDa5DEZC7RKooCbsYtGvFdIXForhSqy8G Ra1KOrlo+jBbRDN6b52/O7DTYqP7h5y9T0yN+rfs2PAslWlnOqidUv5QBtzvvmhN UcYEBEBiXQYOgMyS1o8fZ4TOnm6Qgwi4yXE06jKqOBB7rjOBmDlCkR8Bp/q5bhJG NYllPIRppdXQbYdLwwSOvUWhZqfcO8622aoPF8dRYKVEHTG366iagqVVdUii9yk+ qx6jXZ+bSSV1rhTExP6XY6G3gZk/4dy+yA9ZWXngWBSM/CwzHPnb9M7Z6AK5YliG 1+bkPH/HDOlSODLYkdm9heCRPbZjmSVaJzHcVly7OCQrVL+5PyKSNpRJJZflsYbI 2tHyWgaHCOsrX1WSh1LWkwtTcxeUXZTMmoxU1a0Vgy4= On Thu, Jan 05, 2023 at 04:19:29PM -0500, Jeff Layton wrote: > The file locking definitions have lived in fs.h since the dawn of time, > but they are only used by a small subset of the source files that > include it. > > Move the file locking definitions to a new header file, and add the > appropriate #include directives to the source files that need them. By > doing this we trim down fs.h a bit and limit the amount of rebuilding > that has to be done when we make changes to the file locking APIs. > > Reviewed-by: Xiubo Li > Reviewed-by: Christian Brauner (Microsoft) > Reviewed-by: Christoph Hellwig > Reviewed-by: David Howells > Acked-by: Chuck Lever > Acked-by: Joseph Qi > Acked-by: Steve French > Signed-off-by: Jeff Layton Same question re git tree preferences (and my Acked-by in any case) _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2767FC46467 for ; Wed, 11 Jan 2023 02:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s8JtMRoEbMAePHQaQtpRAbFTwSViYqbKtCG9Q/E+Ht0=; b=Yg2hQEtCbdOshl Un+RSHsoT0f4jQkZhq9YWg8CfeqnB9TP0CVjMWKB+5xEexCe45ptMzaFxdGU+9sdYY8EGokgAkBIv d2vhP6IY42we3RHlx20qIT1mZntRb3EjLG7Z7JIhmDWXVfWV0+TEV24cg+Zg8V7bS9zyw63wDbhAL U8tGjO/9Y2x2/37WpZEWA1r87ufijU84PPRv1cbg/gQNtoKy74jdGaHWT1OFDCLBXfxA/sXpwmf6U NQr3rjkPsjARDU2ZkPXkUvG1Sp7o9ENzPz7xsNQIMk4ldEkA+07NTGWgW/DdebaN3y2/oNxY0/MI8 m9HQeWAg3Wv+L9MK6yQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFQcO-009F3T-Af; Wed, 11 Jan 2023 02:13:32 +0000 Received: from zeniv.linux.org.uk ([2a03:a000:7:0:5054:ff:fe1c:15ff]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFQcL-009F2n-98; Wed, 11 Jan 2023 02:13:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=njrrmruQDIC0in34qwfwYVLn81yNCbta3wj2UCVqMgs=; b=nh0gZtN2mPu3w5awxIzCHyCM0m VL7XTrWSWP/T3pXS1JaWh6hTp9KvW6KHDhtX2kyiA8TwA81F6Pqp6MN5fkdOW8mYBgv4PdAWlhPV5 HO78Fcczxdyq35HLxMLDtwOodiZ2yh6krPSU706FcQ7hzKU0gDz3zzYBXr4hSNnWGOVbwrT1cmA6r h5aEO9JLRpDpneToikJt11IFS/KVgwbXQlCgNlO11DGxO0Y2XrcTxJzCJg+0AhCT1uzgmJS00241D 6QuZTgwjKcGVUzNQkX9fB3CfMoLRZ8ZIWrKz6eEqMFO7wlHlPvRp3Rsm1EAfnwwOVh84wSPT+W1vT xRc2VA1g==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pFQbO-0016Yj-2p; Wed, 11 Jan 2023 02:12:31 +0000 Date: Wed, 11 Jan 2023 02:12:30 +0000 From: Al Viro To: Jeff Layton Cc: Russell King , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Xiubo Li , Ilya Dryomov , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Christine Caulfield , David Teigland , Chuck Lever , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Namjae Jeon , Sergey Senozhatsky , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , "Darrick J. Wong" , Christian Brauner , Christoph Hellwig , Steve French , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v2] filelock: move file locking definitions to separate header file Message-ID: References: <20230105211937.1572384-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230105211937.1572384-1-jlayton@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_181329_361295_5FC20C0C X-CRM114-Status: GOOD ( 15.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 05, 2023 at 04:19:29PM -0500, Jeff Layton wrote: > The file locking definitions have lived in fs.h since the dawn of time, > but they are only used by a small subset of the source files that > include it. > > Move the file locking definitions to a new header file, and add the > appropriate #include directives to the source files that need them. By > doing this we trim down fs.h a bit and limit the amount of rebuilding > that has to be done when we make changes to the file locking APIs. > > Reviewed-by: Xiubo Li > Reviewed-by: Christian Brauner (Microsoft) > Reviewed-by: Christoph Hellwig > Reviewed-by: David Howells > Acked-by: Chuck Lever > Acked-by: Joseph Qi > Acked-by: Steve French > Signed-off-by: Jeff Layton Same question re git tree preferences (and my Acked-by in any case) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel