All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/pipe: Delete unused do_pipe_flags()
Date: Wed, 11 Jan 2023 03:14:46 +0000	[thread overview]
Message-ID: <Y74pphK09fZ9x8gI@ZenIV> (raw)
In-Reply-To: <20230111030547.7730-1-zhouchengming@bytedance.com>

On Wed, Jan 11, 2023 at 11:05:47AM +0800, Chengming Zhou wrote:
> It looks like do_pipe_flags() is not used anywhere and not exported
> too, so delete it. No any functional changes.

What do you mean, not used anywhere?

<checks>

; git grep -n -w do_pipe_flags
arch/alpha/kernel/osf_sys.c:1315:       int res = do_pipe_flags(fd, 0);
arch/ia64/kernel/sys_ia64.c:109:        retval = do_pipe_flags(fd, 0);
arch/mips/kernel/syscall.c:54:  int error = do_pipe_flags(fd, 0);
arch/sh/kernel/sys_sh32.c:31:   error = do_pipe_flags(fd, 0);
arch/sparc/kernel/sys_sparc_32.c:81:    error = do_pipe_flags(fd, 0);
arch/sparc/kernel/sys_sparc_64.c:319:   error = do_pipe_flags(fd, 0);
fs/pipe.c:989:int do_pipe_flags(int *fd, int flags)
include/linux/fs.h:3019:extern int do_pipe_flags(int *, int);
;

A bunch of callers, and it's easy to check that they are not
ifdefed out, etc. - normal live code...

  reply	other threads:[~2023-01-11  3:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11  3:05 [PATCH] fs/pipe: Delete unused do_pipe_flags() Chengming Zhou
2023-01-11  3:14 ` Al Viro [this message]
2023-01-11  7:54 ` kernel test robot
2023-01-11 10:26 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y74pphK09fZ9x8gI@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.