From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB83AC54EBC for ; Thu, 12 Jan 2023 16:02:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 82F3492ED; Thu, 12 Jan 2023 17:01:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 82F3492ED DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1673539339; bh=hkuo7qNDuli+lY95kty3I8u2gv4csLJIhFbudWsHe44=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=JJiwo3AxB8ccwKoWUunOs4xWPmZbgz3DvtfZLfEMmbmp1EO1lJGULXQP2HN8l5yMj jBAhmz91yCTxtRFX3WbRhQWRAvCb2lZcApm7S6fnHKOZ3Xv95aSco8aXBi5q9/tJ2i WhONr9UUeasokW1kkBDoxF8+B1nxf8yRyBJpLkT0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2542AF8055C; Thu, 12 Jan 2023 16:59:48 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 923D2F803DC; Wed, 11 Jan 2023 10:52:17 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 88FD6F8026A for ; Wed, 11 Jan 2023 10:52:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 88FD6F8026A Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=hlUjMxfx Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C6DA9B81B6E; Wed, 11 Jan 2023 09:52:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 827F6C433EF; Wed, 11 Jan 2023 09:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673430733; bh=hkuo7qNDuli+lY95kty3I8u2gv4csLJIhFbudWsHe44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hlUjMxfxt0z7KP7jhGBcW0mbvluD21ZU5AMs1exGjhcHCcNtCt2tujvNtHoCc84RR AZrGEOSQj9OQpn95tznKo4sX8isYo7p8QwqWycSgsIcnfk+WGrTzY3MMLiTZ8IqXpg 6a9zIgsqx4b3HroVDVYyjIDs5L+hk4EDNJSkmWUw= Date: Wed, 11 Jan 2023 10:52:10 +0100 From: Greg Kroah-Hartman To: Mika Westerberg Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Thu, 12 Jan 2023 16:59:42 +0100 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heikki Krogerus , Sean Young , "Rafael J. Wysocki" , alsa-devel@alsa-project.org, platform-driver-x86@vger.kernel.org, linux-i2c@vger.kernel.org, Andreas Noever , linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, Bard Liao , Dan Williams , Andy Shevchenko , linux-acpi@vger.kernel.org, Frank Rowand , Pierre-Louis Bossart , "Matthew Wilcox \(Oracle\)" , Jason Gunthorpe , Alan Stern , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Won Chung , Len Brown , devicetree@vger.kernel.org, Chaitanya Kulkarni , Ira Weiny , Michael Jamet , Ming Lei , Mark Gross , Hans de Goede , Rob Herring , Jiri Slaby , Thomas Gleixner , Mauro Carvalho Chehab , Jens Axboe , linux-block@vger.kernel.org, Jilin Yuan , "Martin K. Petersen" , Dmitry Torokhov , linux-kernel@vger.kernel.org, Wolfram Sang , Vinod Koul , Stefan Richter , Sakari Ailus , Yehezkel Bernat , Sanyog Kale , linux-media@vger.kernel.org, Maximilian Luz , linux-usb@vger.kernel.org Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Nov 23, 2022 at 03:56:54PM +0200, Mika Westerberg wrote: > On Wed, Nov 23, 2022 at 01:25:21PM +0100, Greg Kroah-Hartman wrote: > > The uevent() callback in struct device_type should not be modifying the > > device that is passed into it, so mark it as a const * and propagate the > > function signature changes out into all relevant subsystems that use > > this callback. > > > > Cc: Jens Axboe > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: Stefan Richter > > Cc: Wolfram Sang > > Cc: Alexandre Belloni > > Cc: Dmitry Torokhov > > Cc: Sean Young > > Cc: Mauro Carvalho Chehab > > Cc: Rob Herring > > Cc: Frank Rowand > > Cc: Maximilian Luz > > Cc: Hans de Goede > > Cc: Mark Gross > > Cc: Vinod Koul > > Cc: Bard Liao > > Cc: Pierre-Louis Bossart > > Cc: Sanyog Kale > > Cc: Andreas Noever > > Cc: Michael Jamet > > Cc: Mika Westerberg > > Acked-by: Mika Westerberg # for Thunderbolt Thanks for the review. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51EC7C46467 for ; Wed, 11 Jan 2023 09:55:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238786AbjAKJzr (ORCPT ); Wed, 11 Jan 2023 04:55:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236347AbjAKJzT (ORCPT ); Wed, 11 Jan 2023 04:55:19 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 384091AD89; Wed, 11 Jan 2023 01:52:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 24F1061B9A; Wed, 11 Jan 2023 09:52:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 827F6C433EF; Wed, 11 Jan 2023 09:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673430733; bh=hkuo7qNDuli+lY95kty3I8u2gv4csLJIhFbudWsHe44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hlUjMxfxt0z7KP7jhGBcW0mbvluD21ZU5AMs1exGjhcHCcNtCt2tujvNtHoCc84RR AZrGEOSQj9OQpn95tznKo4sX8isYo7p8QwqWycSgsIcnfk+WGrTzY3MMLiTZ8IqXpg 6a9zIgsqx4b3HroVDVYyjIDs5L+hk4EDNJSkmWUw= Date: Wed, 11 Jan 2023 10:52:10 +0100 From: Greg Kroah-Hartman To: Mika Westerberg Cc: linux-kernel@vger.kernel.org, Jens Axboe , "Rafael J. Wysocki" , Len Brown , Stefan Richter , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Sean Young , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Maximilian Luz , Hans de Goede , Mark Gross , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andreas Noever , Michael Jamet , Yehezkel Bernat , Jiri Slaby , Heikki Krogerus , "Matthew Wilcox (Oracle)" , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , Jilin Yuan , Alan Stern , Andy Shevchenko , Sakari Ailus , Jason Gunthorpe , Thomas Gleixner , Ira Weiny , Dan Williams , Won Chung , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux1394-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Nov 23, 2022 at 03:56:54PM +0200, Mika Westerberg wrote: > On Wed, Nov 23, 2022 at 01:25:21PM +0100, Greg Kroah-Hartman wrote: > > The uevent() callback in struct device_type should not be modifying the > > device that is passed into it, so mark it as a const * and propagate the > > function signature changes out into all relevant subsystems that use > > this callback. > > > > Cc: Jens Axboe > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: Stefan Richter > > Cc: Wolfram Sang > > Cc: Alexandre Belloni > > Cc: Dmitry Torokhov > > Cc: Sean Young > > Cc: Mauro Carvalho Chehab > > Cc: Rob Herring > > Cc: Frank Rowand > > Cc: Maximilian Luz > > Cc: Hans de Goede > > Cc: Mark Gross > > Cc: Vinod Koul > > Cc: Bard Liao > > Cc: Pierre-Louis Bossart > > Cc: Sanyog Kale > > Cc: Andreas Noever > > Cc: Michael Jamet > > Cc: Mika Westerberg > > Acked-by: Mika Westerberg # for Thunderbolt Thanks for the review. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38355C54EBC for ; Wed, 11 Jan 2023 13:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sgrh7oeUJpsIhicPjjiiIzseCE5GoHyYJ1zP2deqdW4=; b=EsbFSCIR87LVm/ ehCWZdVAx3yXzSRYnNo6HtM2Rti/Xk2U683VoHrpjzubccP4Usq4HivO4UmhLLPMjeKu2os6V5Jo9 He/MS8YBNpqz16+8+upMFN1bLiWxoaS6HtN3fyPd8wAWfDDQ1giRsOBUcLHuCO3jmHUJyPySWulgT vdvUt1ljY90WUYa5+LC9NL6RQR4llfTsT8roiA/aUkBIOGWDIn/bq4U9GOxU+qIgLq3PcC6IQ6v3u zYk+odbFTUAVI5e5Ej4zjlQm5qJcxcwvNeeJ/3ZvOMpgckMyk84G0gVNavzKjVVTEGapUCaak5FM8 0CekEhRhaLRLqhIiurRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFbEM-00Bbgq-91; Wed, 11 Jan 2023 13:33:26 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFXmK-00AdWX-BA for linux-i3c@lists.infradead.org; Wed, 11 Jan 2023 09:52:17 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C6DA9B81B6E; Wed, 11 Jan 2023 09:52:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 827F6C433EF; Wed, 11 Jan 2023 09:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673430733; bh=hkuo7qNDuli+lY95kty3I8u2gv4csLJIhFbudWsHe44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hlUjMxfxt0z7KP7jhGBcW0mbvluD21ZU5AMs1exGjhcHCcNtCt2tujvNtHoCc84RR AZrGEOSQj9OQpn95tznKo4sX8isYo7p8QwqWycSgsIcnfk+WGrTzY3MMLiTZ8IqXpg 6a9zIgsqx4b3HroVDVYyjIDs5L+hk4EDNJSkmWUw= Date: Wed, 11 Jan 2023 10:52:10 +0100 From: Greg Kroah-Hartman To: Mika Westerberg Cc: linux-kernel@vger.kernel.org, Jens Axboe , "Rafael J. Wysocki" , Len Brown , Stefan Richter , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Sean Young , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Maximilian Luz , Hans de Goede , Mark Gross , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andreas Noever , Michael Jamet , Yehezkel Bernat , Jiri Slaby , Heikki Krogerus , "Matthew Wilcox (Oracle)" , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , Jilin Yuan , Alan Stern , Andy Shevchenko , Sakari Ailus , Jason Gunthorpe , Thomas Gleixner , Ira Weiny , Dan Williams , Won Chung , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux1394-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_015216_683844_7BAC1568 X-CRM114-Status: GOOD ( 16.86 ) X-Mailman-Approved-At: Wed, 11 Jan 2023 05:33:24 -0800 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Wed, Nov 23, 2022 at 03:56:54PM +0200, Mika Westerberg wrote: > On Wed, Nov 23, 2022 at 01:25:21PM +0100, Greg Kroah-Hartman wrote: > > The uevent() callback in struct device_type should not be modifying the > > device that is passed into it, so mark it as a const * and propagate the > > function signature changes out into all relevant subsystems that use > > this callback. > > > > Cc: Jens Axboe > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: Stefan Richter > > Cc: Wolfram Sang > > Cc: Alexandre Belloni > > Cc: Dmitry Torokhov > > Cc: Sean Young > > Cc: Mauro Carvalho Chehab > > Cc: Rob Herring > > Cc: Frank Rowand > > Cc: Maximilian Luz > > Cc: Hans de Goede > > Cc: Mark Gross > > Cc: Vinod Koul > > Cc: Bard Liao > > Cc: Pierre-Louis Bossart > > Cc: Sanyog Kale > > Cc: Andreas Noever > > Cc: Michael Jamet > > Cc: Mika Westerberg > > Acked-by: Mika Westerberg # for Thunderbolt Thanks for the review. -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c