From: Sabrina Dubroca <sd@queasysnail.net>
To: ehakim@nvidia.com
Cc: dsahern@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v3 1/1] macsec: Fix Macsec replay protection
Date: Wed, 11 Jan 2023 12:15:06 +0100 [thread overview]
Message-ID: <Y76aOvxVcW/upwjl@hog> (raw)
In-Reply-To: <20230111073259.19723-1-ehakim@nvidia.com>
2023-01-11, 09:32:59 +0200, ehakim@nvidia.com wrote:
> From: Emeel Hakim <ehakim@nvidia.com>
>
> Currently when configuring macsec with replay protection,
> replay protection and window gets a default value of -1,
> the above is leading to passing replay protection and
> replay window attributes to the kernel while replay is
> explicitly set to off, leading for an invalid argument
> error when configured with extended packet number (XPN).
> since the default window value which is 0xFFFFFFFF is
> passed to the kernel and while XPN is configured the above
> value is an invalid window value.
>
> Example:
> ip link add link eth2 macsec0 type macsec sci 1 cipher
> gcm-aes-xpn-128 replay off
>
> RTNETLINK answers: Invalid argument
>
> Fix by passing the window attribute to the kernel only if replay is on
>
> Fixes: b26fc590ce62 ("ip: add MACsec support")
> Signed-off-by: Emeel Hakim <ehakim@nvidia.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Thanks Emeel.
--
Sabrina
next prev parent reply other threads:[~2023-01-11 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 7:32 [PATCH iproute2 v3 1/1] macsec: Fix Macsec replay protection ehakim
2023-01-11 11:15 ` Sabrina Dubroca [this message]
2023-01-15 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y76aOvxVcW/upwjl@hog \
--to=sd@queasysnail.net \
--cc=dsahern@kernel.org \
--cc=ehakim@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.