Re: [LTP] [PATCH] setreuid04.c: Rewrite using new LTP API

[Petr Vorel <pvorel@suse.cz>]

Hi Avinesh,

> -/*
> - * Test that root can change the real and effective uid to an
> - * unpriviledged user.
> +/*\
> + * [Description]
> + *
> + * Verify that root user can change the real and effective uid to an
> + * unprivileged user.
>   */

> -struct test_data_t {
> +static struct tcase {
>  	uid_t *real_uid;
>  	uid_t *eff_uid;
> +	uid_t *exp_real_uid;
> +	uid_t *exp_eff_uid;
nit: eff looks really strange. I'd personally use euid and uid or euid and ruid.
But it's really a detail (no need to change this).

Thanks for a nice cleanup.

Reviewed-by: Petr Vorel <akumar@suse.de>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp