All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/2] ipset patches for nf
Date: Mon, 2 Jan 2023 15:13:18 +0100	[thread overview]
Message-ID: <Y7LmfgCItoF49tSY@salvia> (raw)
In-Reply-To: <20221230122438.1618153-1-kadlec@netfilter.org>

On Fri, Dec 30, 2022 at 01:24:36PM +0100, Jozsef Kadlecsik wrote:
> Hi Pablo,
> 
> Please pull the next patches into your nf tree.
> 
> - The first patch fixes a hang when 0/0 subnets is added to a
>   hash:net,port,net type of set. Except hash:net,port,net and
>   hash:net,iface, the set types don't support 0/0 and the auxiliary
>   functions rely on this fact. So 0/0 needs a special handling in
>   hash:net,port,net which was missing (hash:net,iface was not affected
>   by this bug).
> - When adding/deleting large number of elements in one step in ipset,
>   it can take a reasonable amount of time and can result in soft lockup
>   errors. This patch is a complete rework of the previous version in order
>   to use a smaller internal batch limit and at the same time removing
>   the external hard limit to add arbitrary number of elements in one step.

Series applied to nf.git

I added a Fixes: tag to the first patch and removed a duplicated
Signed-off-by: line in the second.

Just a minor nitpick, nothing important.

Thanks for your fixes.

  parent reply	other threads:[~2023-01-02 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30 12:24 [PATCH 0/2] ipset patches for nf Jozsef Kadlecsik
2022-12-30 12:24 ` [PATCH 1/2] netfilter: ipset: fix hash:net,port,net hang with /0 subnet Jozsef Kadlecsik
2022-12-30 12:24 ` [PATCH 2/2] netfilter: ipset: Rework long task execution when adding/deleting entries Jozsef Kadlecsik
2022-12-30 12:42 ` [PATCH 0/2] ipset patches for nf Jozsef Kadlecsik
2023-01-02 14:12   ` Pablo Neira Ayuso
2023-01-02 14:13 ` Pablo Neira Ayuso [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-02-22 11:30 Jozsef Kadlecsik
2020-02-26 13:02 ` Pablo Neira Ayuso
2017-02-19 18:24 Jozsef Kadlecsik
2017-02-21 13:05 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7LmfgCItoF49tSY@salvia \
    --to=pablo@netfilter.org \
    --cc=kadlec@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.