From: Sam Ravnborg <sam@ravnborg.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH 01/14] drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro
Date: Mon, 2 Jan 2023 20:02:53 +0100 [thread overview]
Message-ID: <Y7MqXbQLzpbVI5V7@ravnborg.org> (raw)
In-Reply-To: <8de738ef-588b-1c59-6e97-c0277eb313b1@redhat.com>
Hi Javier,
> > (If you align '\' under each other it would be nicer, but I could see
> > that mipi_dsi_dcs_write_seq() do not do so).
>
> Yeah, I was actually thinking about doing like you suggested for this macro
> but preferred to keep it consistent with the existing mipi_dsi_dcs_write_seq()
> macro definition...
>
> Maybe I can add a preparatory patch that just fixes the backslash characters
> indent for mipi_dsi_dcs_write_seq() to be all aligned?
Yep, that would be nice.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/14] drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro
Date: Mon, 2 Jan 2023 20:02:53 +0100 [thread overview]
Message-ID: <Y7MqXbQLzpbVI5V7@ravnborg.org> (raw)
In-Reply-To: <8de738ef-588b-1c59-6e97-c0277eb313b1@redhat.com>
Hi Javier,
> > (If you align '\' under each other it would be nicer, but I could see
> > that mipi_dsi_dcs_write_seq() do not do so).
>
> Yeah, I was actually thinking about doing like you suggested for this macro
> but preferred to keep it consistent with the existing mipi_dsi_dcs_write_seq()
> macro definition...
>
> Maybe I can add a preparatory patch that just fixes the backslash characters
> indent for mipi_dsi_dcs_write_seq() to be all aligned?
Yep, that would be nice.
Sam
next prev parent reply other threads:[~2023-01-02 19:04 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 1:47 [PATCH 00/14] drm/panel: Make panel drivers use existing DSI write macros Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2022-12-28 1:47 ` [PATCH 01/14] drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2022-12-29 15:36 ` kernel test robot
2022-12-29 15:36 ` kernel test robot
2023-01-02 18:39 ` Sam Ravnborg
2023-01-02 18:39 ` Sam Ravnborg
2023-01-02 18:59 ` Javier Martinez Canillas
2023-01-02 18:59 ` Javier Martinez Canillas
2023-01-02 19:02 ` Sam Ravnborg [this message]
2023-01-02 19:02 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 02/14] drm/panel-asus-z00t-tm5p5-n35596: Drop custom DSI write macros Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2022-12-28 1:47 ` [PATCH 03/14] drm/panel-sitronix-st7703: " Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2022-12-28 12:01 ` Guido Günther
2022-12-28 12:01 ` Guido Günther
2022-12-29 14:30 ` Javier Martinez Canillas
2022-12-29 14:30 ` Javier Martinez Canillas
2023-01-02 18:42 ` Sam Ravnborg
2023-01-02 18:42 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 04/14] drm/panel-leadtek-ltk050h3146w: Drop custom DSI write macro Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:43 ` Sam Ravnborg
2023-01-02 18:43 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 05/14] drm/panel-elida-kd35t133: " Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:44 ` Sam Ravnborg
2023-01-02 18:44 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 06/14] drm/panel-boe-bf060y8m-aj0: " Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:45 ` Sam Ravnborg
2023-01-02 18:45 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 07/14] drm/panel-novatek-nt35950: " Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:55 ` Sam Ravnborg
2023-01-02 18:55 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 08/14] drm/panel-jdi-fhd-r63452: Drop custom DSI write macros Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:46 ` Sam Ravnborg
2023-01-02 18:46 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 09/14] drm/panel-samsung-s6e88a0-ams452ef01: Drop custom DSI write macro Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:48 ` Sam Ravnborg
2023-01-02 18:48 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 10/14] drm/panel-samsung-sofef00: " Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:56 ` Sam Ravnborg
2023-01-02 18:56 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 11/14] drm/panel-sharp-ls060t1sx01: " Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:50 ` Sam Ravnborg
2023-01-02 18:50 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 12/14] drm/panel-mantix-mlaf057we51: " Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:56 ` Sam Ravnborg
2023-01-02 18:56 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 13/14] drm/panel-sony-tulip-truly-nt35521: " Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:51 ` Sam Ravnborg
2023-01-02 18:51 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 14/14] drm/panel-xinpeng-xpp055c272: " Javier Martinez Canillas
2022-12-28 1:47 ` Javier Martinez Canillas
2023-01-02 18:53 ` Sam Ravnborg
2023-01-02 18:53 ` Sam Ravnborg
2023-01-02 19:08 ` Javier Martinez Canillas
2023-01-02 19:08 ` Javier Martinez Canillas
2023-01-02 19:00 ` [PATCH 00/14] drm/panel: Make panel drivers use existing DSI write macros Sam Ravnborg
2023-01-02 19:00 ` Sam Ravnborg
2023-01-02 19:13 ` Javier Martinez Canillas
2023-01-02 19:13 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7MqXbQLzpbVI5V7@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.