From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A51C46467 for ; Tue, 3 Jan 2023 09:37:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233070AbjACJho (ORCPT ); Tue, 3 Jan 2023 04:37:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230467AbjACJhn (ORCPT ); Tue, 3 Jan 2023 04:37:43 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF8C8F29 for ; Tue, 3 Jan 2023 01:37:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6BC5B61228 for ; Tue, 3 Jan 2023 09:37:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52663C433F0; Tue, 3 Jan 2023 09:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672738661; bh=HrZF70KL+uk5zjGG40UB1MOx0acd0dNvtJAlZ55IXIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HLG81xisX/m1pt8WLqaYdbs8f4nJe3fKRZhaENQ622WC7FgAKEB2C2i5vGUegRQba iGx7etwph6A2EUMD7no3nM8aXiu3mdDKvxPAAFc+HpUWO8QuiZqfQ4ysOFJcbMEFZW BCiRbWvyveWbNBLoHeXdanWKKwt3kUdb/ErYuYdPDfFKFgaR3mTmcvhBrwGGbZpRKf heEo8tM1nBrBGrPpu6klCPeFjTYrowSKGpxkr/9KioaXHVa1qWbATSN8/MWU4hF8h9 WRvav6vBpgLBvsi6U/9tOGM8OkOGply9MJgXstalk7BFYLDmgEWpPi0fI9rumG9n7V rX5m/eyaw2Gng== Date: Tue, 3 Jan 2023 11:37:37 +0200 From: Leon Romanovsky To: Zhu Yanjun Cc: mustafa.ismail@intel.com, shiraz.saleem@intel.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, Zhu Yanjun Subject: Re: [PATCH 1/1] RDMA/irdma: Add support for dmabuf pin memory regions Message-ID: References: <20230103013433.341997-1-yanjun.zhu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103013433.341997-1-yanjun.zhu@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Jan 02, 2023 at 08:34:33PM -0500, Zhu Yanjun wrote: > From: Zhu Yanjun > > This is a followup to the EFA dmabuf[1]. Irdma driver currently does > not support on-demand-paging(ODP). So it uses habanalabs as the > dmabuf exporter, and irdma as the importer to allow for peer2peer > access through libibverbs. > > In this commit, the function ib_umem_dmabuf_get_pinned() is used. > This function is introduced in EFA dmabuf[1] which allows the driver > to get a dmabuf umem which is pinned and does not require move_notify > callback implementation. The returned umem is pinned and DMA mapped > like standard cpu umems, and is released through ib_umem_release(). > > [1]https://lore.kernel.org/lkml/20211007114018.GD2688930@ziepe.ca/t/ > > Signed-off-by: Zhu Yanjun > --- > drivers/infiniband/hw/irdma/verbs.c | 158 ++++++++++++++++++++++++++++ > 1 file changed, 158 insertions(+) > > diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c > index f6973ea55eda..76dc6e65930a 100644 > --- a/drivers/infiniband/hw/irdma/verbs.c > +++ b/drivers/infiniband/hw/irdma/verbs.c > @@ -2912,6 +2912,163 @@ static struct ib_mr *irdma_reg_user_mr(struct ib_pd *pd, u64 start, u64 len, > return ERR_PTR(err); > } > > +struct ib_mr *irdma_reg_user_mr_dmabuf(struct ib_pd *pd, u64 start, > + u64 len, u64 virt, > + int fd, int access, > + struct ib_udata *udata) kbuild complained about this line, it should be "static struct ..." And please use target in your patches: rdma-next/rdma-rc. Thanks