All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Haotien Hsu <haotienh@nvidia.com>
Cc: "Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Sing-Han Chen" <singhanc@nvidia.com>,
	"Sanket Goswami" <Sanket.Goswami@amd.com>,
	"Wayne Chang" <waynec@nvidia.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ucsi_ccg: Refine the UCSI Interrupt handling
Date: Tue, 3 Jan 2023 08:32:03 +0100	[thread overview]
Message-ID: <Y7PZ81G1LI20eGeq@kroah.com> (raw)
In-Reply-To: <20230103024023.235098-1-haotienh@nvidia.com>

On Tue, Jan 03, 2023 at 10:40:23AM +0800, Haotien Hsu wrote:
> From: Sing-Han Chen <singhanc@nvidia.com>
> 
> For the CCGx, when the OPM field in the INTR_REG is cleared, then the
> CCI data in the PPM is reset.
> 
> To align with the CCGx UCSI interface guide, this patch updates the
> driver to copy CCI and MESSAGE_IN before clearing UCSI interrupt.
> When a new command is sent, the driver will clear the old CCI and
> MESSAGE_IN copy.
> 
> Finally, clear UCSI_READ_INT before calling complete() to ensure that
> the ucsi_ccg_sync_write() would wait for the interrupt handling to
> complete.
> It prevents the driver from resetting CCI prematurely.
> 
> Signed-off-by: Sing-Han Chen <singhanc@nvidia.com>
> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> Reported-by: kernel test robot <lkp@intel.com>

The test robot reported this whole issue?  If not, it should not be
here.

thanks,

greg k-h

  reply	other threads:[~2023-01-03  7:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-03  2:40 [PATCH v2] ucsi_ccg: Refine the UCSI Interrupt handling Haotien Hsu
2023-01-03  7:32 ` Greg Kroah-Hartman [this message]
2023-01-03  8:12   ` Haotien Hsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7PZ81G1LI20eGeq@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Sanket.Goswami@amd.com \
    --cc=haotienh@nvidia.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=singhanc@nvidia.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=waynec@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.