All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Bernard Metzler <BMT@zurich.ibm.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"leonro@nvidia.com" <leonro@nvidia.com>,
	"David.Laight@aculab.com" <David.Laight@aculab.com>
Subject: Re: Re: [PATCH] RDMA/siw: Fix missing permission check in user buffer registration
Date: Tue, 3 Jan 2023 10:15:09 -0400	[thread overview]
Message-ID: <Y7Q4bZqvDWeDNE/m@nvidia.com> (raw)
In-Reply-To: <SA0PR15MB39196C05636860B60263FF3599F49@SA0PR15MB3919.namprd15.prod.outlook.com>

On Tue, Jan 03, 2023 at 02:11:19PM +0000, Bernard Metzler wrote:
> Oh ok, thanks. It is probably find_vma() further down the call
> which makes sure the address is valid for the user context. I
> tried reserving bogus user memory with siw and indeed get the
> right failure from trying to pin it.

Why isn't this using a normal umem which does all this for you?

Jason

  reply	other threads:[~2023-01-03 14:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-16 18:32 [PATCH] RDMA/siw: Fix missing permission check in user buffer registration Bernard Metzler
2022-12-16 18:34 ` Jason Gunthorpe
2022-12-16 20:11   ` Bernard Metzler
2022-12-16 20:12     ` Jason Gunthorpe
2022-12-20 13:52       ` Bernard Metzler
2023-01-03 13:07         ` Jason Gunthorpe
2023-01-03 14:11           ` Bernard Metzler
2023-01-03 14:15             ` Jason Gunthorpe [this message]
2023-01-03 16:19               ` Bernard Metzler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7Q4bZqvDWeDNE/m@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=BMT@zurich.ibm.com \
    --cc=David.Laight@aculab.com \
    --cc=leonro@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.