From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF4CC3DA7D for ; Tue, 3 Jan 2023 12:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237495AbjACMVG (ORCPT ); Tue, 3 Jan 2023 07:21:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233201AbjACMU6 (ORCPT ); Tue, 3 Jan 2023 07:20:58 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A763EE1C for ; Tue, 3 Jan 2023 04:20:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DBCB8612EE for ; Tue, 3 Jan 2023 12:20:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C263EC433D2; Tue, 3 Jan 2023 12:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672748457; bh=xm2NByl3yjI2ATYgGnkJecO2t0pzu8NkiSD8Bp3s/4w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=koaoedWK+pn5ufUeWMRqgRhcaK3NVYSy0CN4EfakCQ4C6Rcz+IPeXA1t1uVBEoT5B NQ3h1ouEY9dc2Dz0xsCxljhoOnJAefu0j8q0UnRQSVlsV0mkZuWacbGbgF6qF6d9F3 rmlhb7pHbCCuLja8FKvHYZpX8AvdoANNr+k10xF1u3J0TBULOHqwPAslUPD2//jS/l UvdW2PIaj2oSkdU5wKgek8errhwB6/MwOIxiS6xdz/WQATTes6WMtzwHutRv5XxwKs UcWaO0ObD6JNsrWREqltvat/wPFumQnmBdULysYakbrXPn8vFEvEaIH8B1pmC0Hv6W Tfnw8V/zEzKRg== Date: Tue, 3 Jan 2023 12:20:52 +0000 From: Lee Jones To: Aren Moynihan Cc: Chen-Yu Tsai , linux-kernel@vger.kernel.org, Ondrej Jirman , Samuel Holland Subject: Re: [PATCH v2] mfd: axp20x: fix order of pek rise and fall events Message-ID: References: <20221208220225.635414-1-aren@peacevolution.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221208220225.635414-1-aren@peacevolution.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 08 Dec 2022, Aren Moynihan wrote: > The power button can get "stuck" if the rising edge and falling edge irq > are read in the same pass. This can often be triggered when resuming > from suspend if the power button is released before the kernel handles > the interrupt. > > Swapping the order of the rise and fall events makes sure that the press > event is handled first, which prevents this situation. > > Signed-off-by: Aren Moynihan > --- > changes in v2: > - add comments describing the reason these are out of bit order > > previous version: > https://lore.kernel.org/lkml/20221123230741.2430813-1-aren@peacevolution.org/T/ > > include/linux/mfd/axp20x.h | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) Applied, thanks -- Lee Jones [李琼斯]