From: Sean Christopherson <seanjc@google.com>
To: Michal Luczaj <mhal@rbox.co>
Cc: pbonzini@redhat.com, dwmw2@infradead.org, kvm@vger.kernel.org,
paul@xen.org
Subject: Re: [PATCH 1/2] KVM: x86: Fix deadlock in kvm_vm_ioctl_set_msr_filter()
Date: Tue, 3 Jan 2023 17:28:35 +0000 [thread overview]
Message-ID: <Y7Rlw/CWk3Pomu4A@google.com> (raw)
In-Reply-To: <Y7RjL+0Sjbm/rmUv@google.com>
On Tue, Jan 03, 2023, Sean Christopherson wrote:
> On Thu, Dec 29, 2022, Michal Luczaj wrote:
> > Move synchronize_srcu(&kvm->srcu) out of kvm->lock critical section.
>
> This needs a much more descriptive changelog, and an update to
> Documentation/virt/kvm/locking.rst to define the ordering requirements between
> kvm->scru and kvm->lock.
Ah, Paolo already send a docs update. I'll respond to that patch, I don't think
the assertion that "kvm->lock is taken inside kvm->srcu" is true prior to the Xen
change.
https://lore.kernel.org/all/20221228110410.1682852-2-pbonzini@redhat.com
next prev parent reply other threads:[~2023-01-03 17:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 20:30 [RFC PATCH 0/2] Use-after-free in kvm_xen_eventfd_update() Michal Luczaj
2022-12-22 20:30 ` [RFC PATCH 1/2] KVM: x86/xen: Fix use-after-free " Michal Luczaj
2022-12-24 8:52 ` Paolo Bonzini
2022-12-24 11:14 ` Michal Luczaj
2022-12-27 11:11 ` Paolo Bonzini
2022-12-28 0:21 ` Michal Luczaj
2022-12-28 9:32 ` David Woodhouse
2022-12-28 9:39 ` Paolo Bonzini
2022-12-28 9:54 ` David Woodhouse
2022-12-28 11:58 ` Paolo Bonzini
2022-12-28 12:35 ` David Woodhouse
2022-12-28 13:14 ` Paolo Bonzini
2022-12-29 2:12 ` Michal Luczaj
2022-12-29 21:03 ` Paolo Bonzini
2022-12-29 21:17 ` [PATCH 0/2] Fix deadlocks in kvm_vm_ioctl_set_msr_filter() and Michal Luczaj
2022-12-29 21:17 ` [PATCH 1/2] KVM: x86: Fix deadlock in kvm_vm_ioctl_set_msr_filter() Michal Luczaj
2023-01-03 17:17 ` Sean Christopherson
2023-01-03 17:28 ` Sean Christopherson [this message]
2023-01-05 19:32 ` Michal Luczaj
2023-01-05 22:23 ` Sean Christopherson
2023-01-05 23:02 ` Paolo Bonzini
2023-01-05 23:07 ` Sean Christopherson
2023-01-10 12:55 ` David Woodhouse
2023-01-10 14:10 ` Paolo Bonzini
2023-01-10 15:27 ` David Woodhouse
2023-01-10 19:17 ` David Woodhouse
2023-01-10 19:37 ` Sean Christopherson
2023-01-10 19:46 ` David Woodhouse
2023-01-11 8:49 ` David Woodhouse
2023-01-11 22:49 ` Paolo Bonzini
2023-01-06 10:06 ` David Woodhouse
2023-01-07 0:06 ` Michal Luczaj
2023-01-05 22:46 ` Sean Christopherson
2022-12-29 21:17 ` [PATCH 2/2] KVM: x86: Fix deadlock in kvm_vm_ioctl_set_pmu_event_filter() Michal Luczaj
2022-12-22 20:30 ` [RFC PATCH 2/2] KVM: x86/xen: Simplify eventfd IOCTLs Michal Luczaj
2022-12-24 8:54 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7Rlw/CWk3Pomu4A@google.com \
--to=seanjc@google.com \
--cc=dwmw2@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.