From: Andrew Lunn <andrew@lunn.ch>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, Jamie Gloudon <jamie.gloudon@gmx.fr>,
netdev@vger.kernel.org, sasha.neftin@intel.com,
Naama Meir <naamax.meir@linux.intel.com>
Subject: Re: [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised Support
Date: Wed, 4 Jan 2023 01:34:12 +0100 [thread overview]
Message-ID: <Y7TJhHjPDQj4UCii@lunn.ch> (raw)
In-Reply-To: <20230103230653.1102544-1-anthony.l.nguyen@intel.com>
> @@ -192,10 +194,16 @@ static int e1000_get_link_ksettings(struct net_device *netdev,
> if (hw->phy.media_type != e1000_media_type_copper)
> cmd->base.eth_tp_mdix_ctrl = ETH_TP_MDI_INVALID;
>
> + lpa_t = mii_stat1000_to_ethtool_lpa_t(adapter->phy_regs.stat1000);
> + lp_advertising = lpa_t |
> + mii_lpa_to_ethtool_lpa_t(adapter->phy_regs.lpa);
The indentation here is a bit odd.
I would also suggest you split this patch into two, since you are
making two changes, adding pause, and adding LPA.
Andrew
next prev parent reply other threads:[~2023-01-04 0:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 23:06 [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised Support Tony Nguyen
2023-01-04 0:34 ` Andrew Lunn [this message]
2023-01-04 0:47 ` Andrew Lunn
2023-01-04 8:59 ` Jamie Gloudon
2023-01-04 17:44 ` Andrew Lunn
2023-01-04 18:52 ` Jamie Gloudon
2023-01-09 8:40 ` Neftin, Sasha
2023-01-09 13:02 ` Andrew Lunn
2023-01-10 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7TJhHjPDQj4UCii@lunn.ch \
--to=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jamie.gloudon@gmx.fr \
--cc=kuba@kernel.org \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.