From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 611FEC4332F for ; Wed, 4 Jan 2023 06:31:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D6AE641681; Wed, 4 Jan 2023 06:31:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D6AE641681 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1672813901; bh=4bARJahpiLgurs5xkpk5LbKx85BnkoYM8q+KVMRpCZ0=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=r+NH78dM1/03tn9qgMLXLptd+8A9zpsIhQg+8e3ZIchMOroSfXDIt+6oMMoJYGQNd G73bUo1sR8XJ4zgUZ22Hwg7AjQlHSHMRP7KOlf+zyve3eJ7t8MTO4Xs4NjZ8dw+7Kc AoG+OhzevBe8jhVXR83RREy3uvdkKL0AtlE2B5LIeAJZb3nSBLlV6yX1XhcOiU2wBA nk1wOo73NRTx1HmlEi0wTfqgfIjAPll6m1W3su5vcYVy1ZEUYWUzSnX7tt5CMWahla UMzoJzqeJTiejy3ukT16Ov5x8ucb1KRtCuT4qR1UosQbb2QLFxOSsN7HQ3DYyf/eFh HCp79unxNaHJw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0LW5gZF43Wun; Wed, 4 Jan 2023 06:31:40 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 9A4E8417D9; Wed, 4 Jan 2023 06:31:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9A4E8417D9 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 1BBB61BF836 for ; Wed, 4 Jan 2023 06:31:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0228C81ED8 for ; Wed, 4 Jan 2023 06:31:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0228C81ED8 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KYOiQlhoUXaW for ; Wed, 4 Jan 2023 06:31:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4861081990 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4861081990 for ; Wed, 4 Jan 2023 06:31:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 29CB8615B0; Wed, 4 Jan 2023 06:31:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDD17C433D2; Wed, 4 Jan 2023 06:31:35 +0000 (UTC) Date: Wed, 4 Jan 2023 08:31:31 +0200 From: Leon Romanovsky To: Bjorn Helgaas Message-ID: References: <20230103142104.GA996978@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672813896; bh=Jq89Kt6GXbDbgoUy01U5qC9TI8NvX/meP04iOIsIWiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tsyBcvrO9BpqHYiYlcjjB3N0yH9nUsyCTkPW7A/evdYAongrrcXQX4nAzJL6wC3/K HA6PDhkl9YJln6ARlXdV2EPyjOJbVAJ4wEQVonw6o7o4nQV8Kkn4kCCNzXKwfotpth GlUZOfj/YqcjPoSj4CyL39AUxwcCdXwGQnSMyQpGnVFTJkl/7Br0xPtA2oVrv+W2Iw QuAixiTJuVlBl+L1WSixJ6cRESXTwJcOt0xf3L+hl6AM84HcZbHeDnIm3WAd0SouGs 4AnHa5iixo/WzKvmVbCNof3Sb1WBmV8VnvvX7Ffl88xwqOmAaZ9Y0vaTvZvX7yKVgL Gqte4Rc26WGkw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=tsyBcvrO Subject: Re: [Intel-wired-lan] [PATCH] igc: Mask replay rollover/timeout errors in I225_LMVP X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Menzel , Rajat Khandelwal , netdev@vger.kernel.org, rajat.khandelwal@intel.com, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, kuba@kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com, linux-pci@vger.kernel.org, Bjorn Helgaas , intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jan 03, 2023 at 07:16:58PM +0200, Leon Romanovsky wrote: > On Tue, Jan 03, 2023 at 08:21:04AM -0600, Bjorn Helgaas wrote: <...> > > > > If a quirk like this is only needed when the driver is loaded, > > > > > > This is always the case with PCI devices managed through kernel, isn't it? > > > Users don't care/aware about "broken" devices unless they start to use them. > > > > Indeed, that's usually the case. There's a lot of stuff in quirks.c > > that could probably be in drivers instead. > > NP, so or deprecate quirks.c and prohibit any change to that file or > don't allow drivers to mangle PCI in their probe routines. > Everything in-between will cause to enormous mess in long run. Another thing to consider what if you go with "probe variant", users will see behavioral differences between drivers and subsystems on how to control these quirks. As an example, see proposal in this thread to add ethtool private flag to enable/disable quirk. In other places, it will be module parameter, sysfs or special to that subsystem tool. Thanks > > Thanks > > > > > Bjorn _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A23C46467 for ; Wed, 4 Jan 2023 06:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231288AbjADGbl (ORCPT ); Wed, 4 Jan 2023 01:31:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231201AbjADGbk (ORCPT ); Wed, 4 Jan 2023 01:31:40 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8823D13FAF; Tue, 3 Jan 2023 22:31:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D1FA2B811FC; Wed, 4 Jan 2023 06:31:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDD17C433D2; Wed, 4 Jan 2023 06:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672813896; bh=Jq89Kt6GXbDbgoUy01U5qC9TI8NvX/meP04iOIsIWiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tsyBcvrO9BpqHYiYlcjjB3N0yH9nUsyCTkPW7A/evdYAongrrcXQX4nAzJL6wC3/K HA6PDhkl9YJln6ARlXdV2EPyjOJbVAJ4wEQVonw6o7o4nQV8Kkn4kCCNzXKwfotpth GlUZOfj/YqcjPoSj4CyL39AUxwcCdXwGQnSMyQpGnVFTJkl/7Br0xPtA2oVrv+W2Iw QuAixiTJuVlBl+L1WSixJ6cRESXTwJcOt0xf3L+hl6AM84HcZbHeDnIm3WAd0SouGs 4AnHa5iixo/WzKvmVbCNof3Sb1WBmV8VnvvX7Ffl88xwqOmAaZ9Y0vaTvZvX7yKVgL Gqte4Rc26WGkw== Date: Wed, 4 Jan 2023 08:31:31 +0200 From: Leon Romanovsky To: Bjorn Helgaas Cc: Paul Menzel , Rajat Khandelwal , anthony.l.nguyen@intel.com, netdev@vger.kernel.org, rajat.khandelwal@intel.com, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, edumazet@google.com, intel-wired-lan@lists.osuosl.org, linux-pci@vger.kernel.org, Bjorn Helgaas , kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net Subject: Re: [Intel-wired-lan] [PATCH] igc: Mask replay rollover/timeout errors in I225_LMVP Message-ID: References: <20230103142104.GA996978@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jan 03, 2023 at 07:16:58PM +0200, Leon Romanovsky wrote: > On Tue, Jan 03, 2023 at 08:21:04AM -0600, Bjorn Helgaas wrote: <...> > > > > If a quirk like this is only needed when the driver is loaded, > > > > > > This is always the case with PCI devices managed through kernel, isn't it? > > > Users don't care/aware about "broken" devices unless they start to use them. > > > > Indeed, that's usually the case. There's a lot of stuff in quirks.c > > that could probably be in drivers instead. > > NP, so or deprecate quirks.c and prohibit any change to that file or > don't allow drivers to mangle PCI in their probe routines. > Everything in-between will cause to enormous mess in long run. Another thing to consider what if you go with "probe variant", users will see behavioral differences between drivers and subsystems on how to control these quirks. As an example, see proposal in this thread to add ethtool private flag to enable/disable quirk. In other places, it will be module parameter, sysfs or special to that subsystem tool. Thanks > > Thanks > > > > > Bjorn