From: Leon Romanovsky <leonro@nvidia.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, Dave Ertman <david.m.ertman@intel.com>,
<netdev@vger.kernel.org>, <shiraz.saleem@intel.com>,
<mustafa.ismail@intel.com>, <jgg@nvidia.com>,
<linux-rdma@vger.kernel.org>,
Gurucharan G <gurucharanx.g@intel.com>
Subject: Re: [PATCH net v2 1/3] ice: Prevent set_channel from changing queues while RDMA active
Date: Wed, 4 Jan 2023 09:45:56 +0200 [thread overview]
Message-ID: <Y7UutHc/1QBH4ude@unreal> (raw)
In-Reply-To: <20230103230738.1102585-2-anthony.l.nguyen@intel.com>
On Tue, Jan 03, 2023 at 03:07:36PM -0800, Tony Nguyen wrote:
> From: Dave Ertman <david.m.ertman@intel.com>
>
> The PF controls the set of queues that the RDMA auxiliary_driver requests
> resources from. The set_channel command will alter that pool and trigger a
> reconfiguration of the VSI, which breaks RDMA functionality.
>
> Prevent set_channel from executing when RDMA driver bound to auxiliary
> device.
>
> Fixes: 348048e724a0 ("ice: Implement iidc operations")
> Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
> Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-01-04 7:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 23:07 [PATCH net v2 0/3][pull request] Intel Wired LAN Driver Updates 2023-01-03 (ice) Tony Nguyen
2023-01-03 23:07 ` [PATCH net v2 1/3] ice: Prevent set_channel from changing queues while RDMA active Tony Nguyen
2023-01-04 7:45 ` Leon Romanovsky [this message]
2023-01-05 4:42 ` Jakub Kicinski
2023-01-03 23:07 ` [PATCH net v2 2/3] ice: Fix deadlock on the rtnl_mutex Tony Nguyen
2023-01-04 7:44 ` Leon Romanovsky
2023-01-03 23:07 ` [PATCH net v2 3/3] ice: Fix broken link in ice NAPI doc Tony Nguyen
2023-01-04 2:02 ` Bagas Sanjaya
2023-01-05 4:43 ` Jakub Kicinski
2023-01-09 8:54 ` Wilczynski, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7UutHc/1QBH4ude@unreal \
--to=leonro@nvidia.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=edumazet@google.com \
--cc=gurucharanx.g@intel.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.