From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org,
Song Liu <songliubraving@fb.com>,
bpf@vger.kernel.org
Subject: Re: [PATCH 0/4] perf bpf_counter: A set of random fixes (v1)
Date: Wed, 4 Jan 2023 11:21:50 -0300 [thread overview]
Message-ID: <Y7WLfqrR6NlMQPTs@kernel.org> (raw)
In-Reply-To: <20230104064402.1551516-1-namhyung@kernel.org>
Em Tue, Jan 03, 2023 at 10:43:58PM -0800, Namhyung Kim escreveu:
> Hello,
>
> This is a collection of small fixes for perf stat bpf counters (bperf).
>
> The bperf framework maintains perf_attr_map in the BPF fs to share the
> same event as much as possible. But the size was limited to 16 and
> perf stat with -ddd option would create more than 16 events and fails.
>
> Also cgroup events with --for-each-cgroup had some other problems when
> dealing with unsupported events and duplicate cgroups.
>
> The code is available at 'perf/stat-bpf-fix-v1' branch in
>
> git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
The first two are improvements, not strict fixes, so I'm leaving them
for the next merge window.
- Arnaldo
> Thanks,
> Namhyung
>
> Namhyung Kim (4):
> perf bpf_counter: Add more error messages for bperf
> perf bpf_counter: Increase perf_attr_map entries to 32
> perf bpf_counter: Handle unsupported cgroup events
> perf stat: Do not use the same cgroup more than once
>
> tools/perf/util/bpf_counter.c | 11 ++++++++---
> tools/perf/util/bpf_counter_cgroup.c | 14 +++-----------
> tools/perf/util/cgroup.c | 23 ++++++++++++++++++-----
> 3 files changed, 29 insertions(+), 19 deletions(-)
>
>
> base-commit: d8d85ce86dc82de4f88b821a78f533b9d5b22a45
> --
> 2.39.0.314.g84b9a713c41-goog
--
- Arnaldo
prev parent reply other threads:[~2023-01-04 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 6:43 [PATCH 0/4] perf bpf_counter: A set of random fixes (v1) Namhyung Kim
2023-01-04 6:43 ` [PATCH 1/4] perf bpf_counter: Add more error messages for bperf Namhyung Kim
2023-01-04 6:44 ` [PATCH 2/4] perf bpf_counter: Increase perf_attr_map entries to 32 Namhyung Kim
2023-01-04 6:44 ` [PATCH 3/4] perf bpf_counter: Handle unsupported cgroup events Namhyung Kim
2023-01-04 13:51 ` Arnaldo Carvalho de Melo
2023-01-04 6:44 ` [PATCH 4/4] perf stat: Do not use the same cgroup more than once Namhyung Kim
2023-01-04 14:21 ` Arnaldo Carvalho de Melo
2023-01-04 14:21 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7WLfqrR6NlMQPTs@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=bpf@vger.kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.