From: Sean Christopherson <seanjc@google.com>
To: Reiji Watanabe <reijiw@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Oliver Upton <oliver.upton@linux.dev>,
Andrew Jones <andrew.jones@linux.dev>
Subject: Re: [PATCH 1/1] KVM: selftests: kvm_vm_elf_load() and elfhdr_get() should close fd
Date: Wed, 4 Jan 2023 15:00:16 +0000 [thread overview]
Message-ID: <Y7WUgI4muVCn8glt@google.com> (raw)
In-Reply-To: <20221220170921.2499209-2-reijiw@google.com>
On Tue, Dec 20, 2022, Reiji Watanabe wrote:
> kvm_vm_elf_load() and elfhdr_get() open one file each, but they
> never close the opened file descriptor. If a test repeatedly
> creates and destroys a VM with __vm_create(), which
> (directly or indirectly) calls those two functions, the test
> might end up getting a open failure with EMFILE.
> Fix those two functions to close the file descriptor.
>
> Signed-off-by: Reiji Watanabe <reijiw@google.com>
> Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
> Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
> ---
Reviewed-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2023-01-04 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 17:09 [PATCH 0/1] KVM: selftests: kvm_vm_elf_load() and elfhdr_get() should close fd Reiji Watanabe
2022-12-20 17:09 ` [PATCH 1/1] " Reiji Watanabe
2023-01-04 15:00 ` Sean Christopherson [this message]
2023-01-19 21:01 ` [PATCH 0/1] " Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7WUgI4muVCn8glt@google.com \
--to=seanjc@google.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=reijiw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.