From: John Levon <john.levon@nutanix.com>
To: Ashish Sadanandan <ashish.sadanandan@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt
Date: Wed, 4 Jan 2023 16:22:36 +0000 [thread overview]
Message-ID: <Y7WnzOfnTuP2ysTD@movementarian.org> (raw)
In-Reply-To: <20230104000030.187857-1-ashish.sadanandan@gmail.com>
On Tue, Jan 03, 2023 at 05:00:30PM -0700, Ashish Sadanandan wrote:
> The code added for allowing --huge-dir to specify hugetlbfs
> sub-directories has a bug where it incorrectly matches mounts that
> contain a prefix of the specified --huge-dir.
Sorry for the trouble & thanks for the fix.
> + /*
> + * Ignore any mount where hugepage_dir is not a parent path of
> + * the mount
> + */
> + else if(hugepage_dir_len > mountpt_len &&
> + internal_conf->hugepage_dir[mountpt_len] != '/') {
> continue;
> }
Shouldn't this comment say "Ignore any mount that is not a parent path of
hugepage_dir" ?
regards
john
next prev parent reply other threads:[~2023-01-04 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 18:57 [PATCH 1/1] eal/linux: reject mountpt shorter than --huge-dir Ashish Sadanandan
2023-01-03 23:53 ` Ashish Sadanandan
2023-01-04 0:00 ` [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt Ashish Sadanandan
2023-01-04 11:24 ` Dmitry Kozlyuk
2023-01-04 18:17 ` Ashish Sadanandan
2023-01-04 16:22 ` John Levon [this message]
2023-01-04 18:17 ` Ashish Sadanandan
2023-01-04 18:17 ` [PATCH v3 " Ashish Sadanandan
2023-01-09 1:52 ` [PATCH v4 1/1] eal/linux: reject mountpt not parent of --huge-dir Ashish Sadanandan
2023-01-11 12:11 ` John Levon
2023-01-16 18:25 ` Ashish Sadanandan
2023-02-10 11:04 ` David Marchand
2023-02-10 11:01 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7WnzOfnTuP2ysTD@movementarian.org \
--to=john.levon@nutanix.com \
--cc=ashish.sadanandan@gmail.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.