From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E1B3C53210 for ; Thu, 5 Jan 2023 10:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232164AbjAEKxi (ORCPT ); Thu, 5 Jan 2023 05:53:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232949AbjAEKxc (ORCPT ); Thu, 5 Jan 2023 05:53:32 -0500 X-Greylist: delayed 1396 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 05 Jan 2023 02:53:30 PST Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B384750051 for ; Thu, 5 Jan 2023 02:53:30 -0800 (PST) Received: from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.94.2) (envelope-from ) id 1pDNVh-00CMzf-RG; Thu, 05 Jan 2023 11:30:09 +0100 Received: from laforge by localhost.localdomain with local (Exim 4.96) (envelope-from ) id 1pDBd2-00FDH1-35; Wed, 04 Jan 2023 22:48:56 +0100 Date: Wed, 4 Jan 2023 22:48:56 +0100 From: Harald Welte To: Andrew Lunn Cc: netdev@vger.kernel.org, khc@pm.waw.pl Subject: Re: [PATCH] net: hdlc: Increase maximum HDLC MTU Message-ID: References: <20230104125724.3587015-1-laforge@osmocom.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dear Andrew, On Wed, Jan 04, 2023 at 06:52:32PM +0100, Andrew Lunn wrote: > This change does appear to change dev->mtu, not just dev->max_mtu? > So i'm not sure the commit message is correct? Thanks for your feedback, which seems correct. We've been using this patch in production for more than a year, but our use cases are all using larger MTU so this might have been unnoticed. I'll investigate and likely we have to introduce a new HDLC_DEFAULT_MTU of 1500 to achieve backwards compatibility. -- - Harald Welte https://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)