From: Eric Biggers <ebiggers@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-ext4@vger.kernel.org,
Paulo Antonio Alvarez <pauloaalvarez@gmail.com>
Subject: Re: [e2fsprogs PATCH] libext2fs: fix 32-bit Windows build
Date: Wed, 4 Jan 2023 20:05:09 +0000 [thread overview]
Message-ID: <Y7Xb9cYkymilfKLd@gmail.com> (raw)
In-Reply-To: <Y7WvQ9cqOZuF0YJR@magnolia>
On Wed, Jan 04, 2023 at 08:54:27AM -0800, Darrick J. Wong wrote:
> On Wed, Jan 04, 2023 at 01:03:01AM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > _WIN32 is the standard macro to detect Windows, regardless of 32-bit or
> > 64-bit. _WIN64 is for 64-bit Windows only. Use _WIN32 where _WIN64 was
> > incorrectly being used.
> >
> > This fixes several 32-bit Windows build errors, for example this one:
>
> Color me impressed, I would have applied to deprecate Windows support
> entirely, particularly given the existence of WSL.
Yes, now that everyone has migrated to GNU Hurd, which is fully supported by
e2fsprogs, there's no need for Windows which no one uses anymore :-)
The reason I have to care about e2fsprogs support for Windows is because the
Windows build of the Android SDK Platform tools includes a Windows binary of
mke2fs, so that it can be used by 'fastboot format'.
I am sure that Ted would be very unhappy if Android had to bring back
'make_ext4fs' due to e2fsprogs removing Windows support...
(One way out of this for Android would be to remove fastboot's support for
formatting filesystems, and just have it support wiping them. The actual
formatting would then always happen on the Android device itself, using the
Linux build of e2fsprogs. I'm not sure why that can't be done; however, I do
know that it's been brought up many times before and still hasn't happened...)
Of course, a second problem that I ran into after I sent this patch without
properly testing it, is that misc/mke2fs.c is hard-coding unix_io_manager. So
an additional fix would be needed to make it use windows_io_manager on Windows,
now that Windows has its own windows_io_manager instead of unix_io_manager.
Paulo, just to double check: was your intent when adding the windows_io_manager
that it *always* replace unix_io_manager on Windows?
- Eric
next prev parent reply other threads:[~2023-01-04 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:03 [e2fsprogs PATCH] libext2fs: fix 32-bit Windows build Eric Biggers
2023-01-04 16:54 ` Darrick J. Wong
2023-01-04 20:05 ` Eric Biggers [this message]
2023-01-04 20:53 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7Xb9cYkymilfKLd@gmail.com \
--to=ebiggers@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=pauloaalvarez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.