From: Eric Biggers <ebiggers@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-ext4@vger.kernel.org,
Paulo Antonio Alvarez <pauloaalvarez@gmail.com>
Subject: Re: [e2fsprogs PATCH] libext2fs: fix 32-bit Windows build
Date: Wed, 4 Jan 2023 20:53:57 +0000 [thread overview]
Message-ID: <Y7XnZWqRFeuN1Hzn@gmail.com> (raw)
In-Reply-To: <Y7Xb9cYkymilfKLd@gmail.com>
On Wed, Jan 04, 2023 at 08:05:09PM +0000, Eric Biggers wrote:
> On Wed, Jan 04, 2023 at 08:54:27AM -0800, Darrick J. Wong wrote:
> > On Wed, Jan 04, 2023 at 01:03:01AM -0800, Eric Biggers wrote:
> > > From: Eric Biggers <ebiggers@google.com>
> > >
> > > _WIN32 is the standard macro to detect Windows, regardless of 32-bit or
> > > 64-bit. _WIN64 is for 64-bit Windows only. Use _WIN32 where _WIN64 was
> > > incorrectly being used.
> > >
> > > This fixes several 32-bit Windows build errors, for example this one:
> >
> > Color me impressed, I would have applied to deprecate Windows support
> > entirely, particularly given the existence of WSL.
Note that WSL doesn't really eliminate the need for native Windows binaries,
since WSL is something that has to be explicitly enabled and configured; see
https://learn.microsoft.com/en-us/windows/wsl/install. It's not like running a
32-bit binary on a 64-bit system which is something that just works. You can't
just take a Linux binary and run it on Windows.
- Eric
prev parent reply other threads:[~2023-01-04 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:03 [e2fsprogs PATCH] libext2fs: fix 32-bit Windows build Eric Biggers
2023-01-04 16:54 ` Darrick J. Wong
2023-01-04 20:05 ` Eric Biggers
2023-01-04 20:53 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7XnZWqRFeuN1Hzn@gmail.com \
--to=ebiggers@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=pauloaalvarez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.