Re: [PATCH] libbpf: Fix map creation flags sanitization

[Jiri Olsa <olsajiri@gmail.com>]

On Sun, Jan 08, 2023 at 07:20:18PM +0100, Ludovic L'Hours wrote:
> As BPF_F_MMAPABLE flag is now conditionnaly set (by map_is_mmapable),
> it should not be toggled but disabled if not supported by kernel.
> 
> Fixes: 4fcac46c7e10 ("libbpf: only add BPF_F_MMAPABLE flag for data maps with global vars")
> Signed-off-by: Ludovic L'Hours <ludovic.lhours@gmail.com>

LGTM

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> ---
>  tools/lib/bpf/libbpf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index a5c67a3c93c5..f8dfee32c2bc 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -7355,7 +7355,7 @@ static int bpf_object__sanitize_maps(struct bpf_object *obj)
>  		if (!bpf_map__is_internal(m))
>  			continue;
>  		if (!kernel_supports(obj, FEAT_ARRAY_MMAP))
> -			m->def.map_flags ^= BPF_F_MMAPABLE;
> +			m->def.map_flags &= ~BPF_F_MMAPABLE;
>  	}
>  
>  	return 0;
> -- 
> 2.25.1
>