From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Subject: Re: [PATCH v1 1/5] ASoC: Intel: bytcht_cx2072x: Replace open coded acpi_dev_put()
Date: Mon, 9 Jan 2023 12:55:59 +0200 [thread overview]
Message-ID: <Y7vyv7mEmvCSA0eM@smile.fi.intel.com> (raw)
In-Reply-To: <151a05a5-fc56-e005-e572-d031e6de0bb1@linux.intel.com>
On Wed, Jan 04, 2023 at 08:15:27AM -0600, Pierre-Louis Bossart wrote:
> On 1/4/23 04:29, Andy Shevchenko wrote:
> > On Tue, Jan 03, 2023 at 09:08:20AM -0600, Pierre-Louis Bossart wrote:
> >> On 1/2/23 14:30, Andy Shevchenko wrote:
...
> >> I see at least four cases that were missed
> >>
> >> bytcr_rt5640.c: put_device(&adev->dev);
> >> bytcr_rt5651.c: put_device(&adev->dev);
> >> bytcr_wm5102.c: put_device(&adev->dev);
> >> sof_es8336.c: put_device(&adev->dev);
> >
> > Aren't they (they all problematic, btw) covered by the fixes series
> > https://lore.kernel.org/r/20230102203014.16041-1-andriy.shevchenko@linux.intel.com?
>
> They are indeed, but if you group AMD-related patches with Intel ones,
> it's only human for reviewers to skip the thread entirely, even more so
> when catching up with email on January 3 :-)
I'm not sure what should I do about that series. Shall I split AMD and Intel
parts? (Assuming Intel will go as a series with cover letter.)
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/5] ASoC: Intel: bytcht_cx2072x: Replace open coded acpi_dev_put()
Date: Mon, 9 Jan 2023 12:55:59 +0200 [thread overview]
Message-ID: <Y7vyv7mEmvCSA0eM@smile.fi.intel.com> (raw)
In-Reply-To: <151a05a5-fc56-e005-e572-d031e6de0bb1@linux.intel.com>
On Wed, Jan 04, 2023 at 08:15:27AM -0600, Pierre-Louis Bossart wrote:
> On 1/4/23 04:29, Andy Shevchenko wrote:
> > On Tue, Jan 03, 2023 at 09:08:20AM -0600, Pierre-Louis Bossart wrote:
> >> On 1/2/23 14:30, Andy Shevchenko wrote:
...
> >> I see at least four cases that were missed
> >>
> >> bytcr_rt5640.c: put_device(&adev->dev);
> >> bytcr_rt5651.c: put_device(&adev->dev);
> >> bytcr_wm5102.c: put_device(&adev->dev);
> >> sof_es8336.c: put_device(&adev->dev);
> >
> > Aren't they (they all problematic, btw) covered by the fixes series
> > https://lore.kernel.org/r/20230102203014.16041-1-andriy.shevchenko@linux.intel.com?
>
> They are indeed, but if you group AMD-related patches with Intel ones,
> it's only human for reviewers to skip the thread entirely, even more so
> when catching up with email on January 3 :-)
I'm not sure what should I do about that series. Shall I split AMD and Intel
parts? (Assuming Intel will go as a series with cover letter.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-09 10:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 20:30 [PATCH v1 1/5] ASoC: Intel: bytcht_cx2072x: Replace open coded acpi_dev_put() Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-02 20:30 ` [PATCH v1 2/5] ASoC: Intel: bytcht_da7213: " Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-02 20:30 ` [PATCH v1 3/5] ASoC: Intel: cht_bsw_rt5645: " Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-02 20:30 ` [PATCH v1 4/5] ASoC: Intel: cht_bsw_rt5672: " Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-02 20:30 ` [PATCH v1 5/5] ASoC: Intel: sof-wm8804: " Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-03 15:08 ` [PATCH v1 1/5] ASoC: Intel: bytcht_cx2072x: " Pierre-Louis Bossart
2023-01-03 15:08 ` Pierre-Louis Bossart
2023-01-04 10:29 ` Andy Shevchenko
2023-01-04 10:29 ` Andy Shevchenko
2023-01-04 14:15 ` Pierre-Louis Bossart
2023-01-04 14:15 ` Pierre-Louis Bossart
2023-01-04 16:42 ` Mark Brown
2023-01-04 16:42 ` Mark Brown
2023-01-04 16:48 ` Andy Shevchenko
2023-01-04 16:48 ` Andy Shevchenko
2023-01-04 17:16 ` Mark Brown
2023-01-04 17:16 ` Mark Brown
2023-01-04 18:55 ` Andy Shevchenko
2023-01-04 18:55 ` Andy Shevchenko
2023-01-05 11:46 ` Mark Brown
2023-01-05 11:46 ` Mark Brown
2023-01-04 16:45 ` Andy Shevchenko
2023-01-04 16:45 ` Andy Shevchenko
2023-01-09 10:55 ` Andy Shevchenko [this message]
2023-01-09 10:55 ` Andy Shevchenko
2023-01-06 17:04 ` Mark Brown
2023-01-06 17:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7vyv7mEmvCSA0eM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.