From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0BFC54EBD for ; Mon, 9 Jan 2023 15:12:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236657AbjAIPMA (ORCPT ); Mon, 9 Jan 2023 10:12:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236723AbjAIPL1 (ORCPT ); Mon, 9 Jan 2023 10:11:27 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DD0D306 for ; Mon, 9 Jan 2023 07:10:53 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 14A5576090; Mon, 9 Jan 2023 15:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673277052; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D1j9M/5WtOcRK7YwNPkdaM+6SDyg9bNJyJZjB6fEhU0=; b=DoBRBPqw8HfmDXkjTWHuL4Gwqp2zrNMI5wnXhFHbWOCVxfMvcGp+jnh9qe+qw0i4Nou6kn /cLVzQ4PwAjwLPqE2kxPRqv87t+8JNhcCREQgVw/qwmGUVeTGM1KoiJmzgv/CM8j+hEkKP o58PNyM+k2SggKV5O5s42jczHqkLp0A= Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id D15782C141; Mon, 9 Jan 2023 15:10:51 +0000 (UTC) Date: Mon, 9 Jan 2023 16:10:51 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH printk v5 0/8] printk: cleanup buffer handling Message-ID: References: <20230109100800.1085541-1-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230109100800.1085541-1-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2023-01-09 11:13:52, John Ogness wrote: > Hi, > > This is v5 of a series to cleanup console buffer handling and > prepare for code sharing with the upcoming threaded/atomic > consoles. v4 is here [0]. > > The main purpose of the series is to introduce two new lockless > functions to handle reading and formatting of printk messages. These > functions can then be used from any context, which is important for > the upcoming threaded/atomic consoles. The series also helps to > cleanup some of the internal printk interfaces and cleanly separate > formatting code from outputting code. > > Changes since v4: > > - Make console_prepend_dropped() a NOP for !CONFIG_PRINTK to > workaround compiler warnings. > > - In devkmsg_read() use printk_get_next_message() for the wait > condition instead of looping to retry the actual read. > > - Add an argument @may_suppress to printk_get_next_message() so > devkmsg_read() can specify that records should not be skipped > based on loglevel. > > John Ogness > > [0] https://lore.kernel.org/lkml/20230105103735.880956-1-john.ogness@linutronix.de > > John Ogness (6): > printk: move size limit macros into internal.h > printk: introduce struct printk_buffers > printk: introduce printk_get_next_message() and printk_message > printk: introduce console_prepend_dropped() for dropped messages > printk: use printk_buffers for devkmsg > printk: adjust string limit macros > > Thomas Gleixner (2): > console: Use BIT() macros for @flags values > console: Document struct console The series looks ready for linux-next from my POV. I am going to push it into a new branch rework/buffers-cleanup within two days or so unless anyone speak against it. Best Regards, Petr