All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: separate single stripe optimization into a dedicate branch
Date: Tue, 24 Jan 2023 00:16:36 -0800	[thread overview]
Message-ID: <Y8+T5PIURkONMvTD@infradead.org> (raw)
In-Reply-To: <4e4d6e0aab34ab40fd0ac69874141bb02a559f10.1674546545.git.wqu@suse.com>

On Tue, Jan 24, 2023 at 04:00:24PM +0800, Qu Wenruo wrote:
> This patch would looks awful by itself, as it's causing a lot of new
> lines.

Yeah.

> 
> But firstly, a lot of the new lines are just comments.
> 
> Secondly I hope my RAID56/non-RAID56 split can later be used to
> refactor the slow path.

I'm not sure what exact refactor you are planning.  Right now this
duplicates a lot of code and makes the function harder to read.

So while I agree that __btrfs_map_block could use some splitting,
this patch as-is seems counter productive.  It might make more
sense to look into reusable building blocks and split them into
helpers rather than duplicating code to start out.

  reply	other threads:[~2023-01-24  8:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24  8:00 [PATCH] btrfs: separate single stripe optimization into a dedicate branch Qu Wenruo
2023-01-24  8:16 ` Christoph Hellwig [this message]
2023-01-24  8:18   ` Qu Wenruo
2023-01-24  8:43 ` Johannes Thumshirn
2023-01-24  9:45   ` Qu Wenruo
2023-01-24 15:41 ` kernel test robot
2023-01-24 15:41 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8+T5PIURkONMvTD@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.