From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev, Ammar Faizi <ammarfaizi2@gnuweeb.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev
Subject: [ammarfaizi2-block:google/android/kernel/common/upstream-f2fs-stable-linux-5.15.y 115/361] fs/f2fs/data.c:996 f2fs_grab_read_bio() warn: variable dereferenced before check 'bio' (see line 995)
Date: Mon, 23 Jan 2023 15:03:34 +0300 [thread overview]
Message-ID: <Y853lht6nq1emVj6@kadam> (raw)
tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/upstream-f2fs-stable-linux-5.15.y
head: 4bf3e7f429f64b802942c685cf37b02a546a25e5
commit: e8e3f1a12d05d0aef2c819664890b540dfb055af [115/361] f2fs: don't pass a bio to f2fs_target_device
config: arm64-randconfig-m041-20230115 (https://download.01.org/0day-ci/archive/20230122/202301220910.UeYxE65s-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
New smatch warnings:
fs/f2fs/data.c:996 f2fs_grab_read_bio() warn: variable dereferenced before check 'bio' (see line 995)
vim +/bio +996 fs/f2fs/data.c
13ba41e346170e Jaegeuk Kim 2017-09-06 982 static struct bio *f2fs_grab_read_bio(struct inode *inode, block_t blkaddr,
95ae251fe82838 Eric Biggers 2019-07-22 983 unsigned nr_pages, unsigned op_flag,
7f59b277f79e8a Eric Biggers 2021-01-04 984 pgoff_t first_idx, bool for_write)
13ba41e346170e Jaegeuk Kim 2017-09-06 985 {
13ba41e346170e Jaegeuk Kim 2017-09-06 986 struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
13ba41e346170e Jaegeuk Kim 2017-09-06 987 struct bio *bio;
a4b6817625e71d Daeho Jeong 2021-08-20 988 struct bio_post_read_ctx *ctx = NULL;
6dbb17961f46b2 Eric Biggers 2018-04-18 989 unsigned int post_read_steps = 0;
e8e3f1a12d05d0 Christoph Hellwig 2022-02-28 990 sector_t sector;
e8e3f1a12d05d0 Christoph Hellwig 2022-02-28 991 struct block_device *bdev = f2fs_target_device(sbi, blkaddr, §or);
13ba41e346170e Jaegeuk Kim 2017-09-06 992
67883ade7a98a7 Christoph Hellwig 2021-01-26 993 bio = bio_alloc_bioset(for_write ? GFP_NOIO : GFP_KERNEL,
5f7136db829960 Matthew Wilcox (Oracle 2021-01-29 994) bio_max_segs(nr_pages), &f2fs_bioset);
e8e3f1a12d05d0 Christoph Hellwig 2022-02-28 @995 bio_set_dev(bio, bdev);
^^^
Dereferenced inside function
6dbb17961f46b2 Eric Biggers 2018-04-18 @996 if (!bio)
^^^^
Checked too late
13ba41e346170e Jaegeuk Kim 2017-09-06 997 return ERR_PTR(-ENOMEM);
e8e3f1a12d05d0 Christoph Hellwig 2022-02-28 998 bio->bi_iter.bi_sector = sector;
27aacd28ea3b89 Satya Tangirala 2020-07-02 999 f2fs_set_bio_crypt_ctx(bio, inode, first_idx, NULL, GFP_NOFS);
13ba41e346170e Jaegeuk Kim 2017-09-06 1000 bio->bi_end_io = f2fs_read_end_io;
e2e59414aae2c8 Jaegeuk Kim 2018-06-21 1001 bio_set_op_attrs(bio, REQ_OP_READ, op_flag);
13ba41e346170e Jaegeuk Kim 2017-09-06 1002
27aacd28ea3b89 Satya Tangirala 2020-07-02 1003 if (fscrypt_inode_uses_fs_layer_crypto(inode))
7f59b277f79e8a Eric Biggers 2021-01-04 1004 post_read_steps |= STEP_DECRYPT;
7f59b277f79e8a Eric Biggers 2021-01-04 1005
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-01-23 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 12:03 Dan Carpenter [this message]
2023-01-23 12:22 ` [ammarfaizi2-block:google/android/kernel/common/upstream-f2fs-stable-linux-5.15.y 115/361] fs/f2fs/data.c:996 f2fs_grab_read_bio() warn: variable dereferenced before check 'bio' (see line 995) Ammar Faizi
2023-01-23 12:24 ` Fwd: " Ammar Faizi
2023-01-23 12:37 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2023-01-22 1:33 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y853lht6nq1emVj6@kadam \
--to=error27@gmail.com \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.