From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87DA8C05027 for ; Mon, 23 Jan 2023 15:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dfZOXBX9dTJLBCY1wmqYoL0wJpbZxiqKkHopcLcqTyU=; b=2kzoidKvmmNXB+ A5taYk6Eh2nDzmKHcfwIqVbHWjht75shuzOD/ZvP+knnUvw0gK8a0sIUH5371+nn3UwbQiBGNZnrD CDLdtySNUG/WU9fQnHEW/1+cJDnVHtLtTHbC1f4kL1UIJNgpw0EOakMPXAzafqMI814FqZ2wJYopU SJKNoblx0/J+upY1axagUKff9wWJFB8mhoBdpkIJZ3GQVzZe+o3G6PR04C1qJyWFy6nmlNiIHjIRq 0eezsoGTmqBYTSdYXGop1MlfPMPIecYvod2ETgCtP2Lo1xHpnvoqkEMoAbxe/5pV7zGu7GHFzDuz2 EQ+ZHEmkOOQjlkIxZzBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJz3d-000JRu-Iu; Mon, 23 Jan 2023 15:48:29 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJyjx-000BoH-4n for linux-rockchip@lists.infradead.org; Mon, 23 Jan 2023 15:28:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DA34AB80DD6; Mon, 23 Jan 2023 15:28:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C6D9C433EF; Mon, 23 Jan 2023 15:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674487685; bh=8nopWCghWSW6qg8L9ZsS34jM69jMO1LFoFfm/AalAfo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RUxRmKp7CiHKY961/2uBdqNaRyuSjLFLuN5KZxLhGIBaSbPplMiYkKHSdBxj2WOWJ uXECKrCONlmX91BA7249i7kYHI66nZWawITAlgpYhgbQ3xL7umIgOE4xoEgzspGaQD nUNzaSzoHeJUMeh2hphujQmnzLs/+sO2z24JxDVhSrZKlMChdGKup/5KjRrjPyTIlL wyHR+IuQqTDXtmpbS9uKt1BfYKhLtKnKuFPoeqF3X7ZLq4RCRu/1BsyiaA74XJpPc/ 81+4RPUdPSMD3WS4TfplghlIJsgNxur8wySmD4FSl0ouRHTd5vr5FjtPC7bxx6DZ+3 c+kROTFx620qw== Date: Mon, 23 Jan 2023 15:27:58 +0000 From: Lee Jones To: Sebastian Reichel Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Linus Walleij , Mark Brown , Liam Girdwood , Alexandre Belloni , Alessandro Zummo , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCHv5 07/10] mfd: rk8xx: add rk806 support Message-ID: References: <20230109172723.60304-1-sebastian.reichel@collabora.com> <20230109172723.60304-8-sebastian.reichel@collabora.com> <20230123143321.lsddiol6bo2agfbk@mercury.elektranox.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230123143321.lsddiol6bo2agfbk@mercury.elektranox.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_072809_533643_2487BD87 X-CRM114-Status: GOOD ( 35.43 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMyBKYW4gMjAyMywgU2ViYXN0aWFuIFJlaWNoZWwgd3JvdGU6Cgo+IEhpLAo+IAo+ IE9uIEZyaSwgSmFuIDIwLCAyMDIzIGF0IDA0OjU5OjIxUE0gKzAwMDAsIExlZSBKb25lcyB3cm90 ZToKPiA+IE9uIE1vbiwgMDkgSmFuIDIwMjMsIFNlYmFzdGlhbiBSZWljaGVsIHdyb3RlOgo+ID4g Cj4gPiA+IEFkZCBzdXBwb3J0IGZvciBTUEkgY29ubmVjdGVkIHJrODA2LCB3aGljaCBpcyB1c2Vk IGJ5IHRoZSBSSzM1ODgKPiA+ID4gZXZhbHVhdGlvbiBib2FyZHMuIFRoZSBQTUlDIGlzIGFkdmVy dGlzZWQgdG8gc3VwcG9ydCBJMkMgYW5kIFNQSSwKPiA+ID4gYnV0IHRoZSBldmFsdWF0aW9uIGJv YXJkcyBhbGwgdXNlIFNQSS4gVGh1cyBvbmx5IFNQSSBzdXBwb3J0IGlzCj4gPiA+IGFkZGVkIGhl cmUuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBTZWJhc3RpYW4gUmVpY2hlbCA8c2ViYXN0 aWFuLnJlaWNoZWxAY29sbGFib3JhLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL21mZC9L Y29uZmlnICAgICAgIHwgIDE0ICsrCj4gPiA+ICBkcml2ZXJzL21mZC9NYWtlZmlsZSAgICAgIHwg ICAxICsKPiA+ID4gIGRyaXZlcnMvbWZkL3JrOHh4LWNvcmUuYyAgfCAgNjcgKysrKysrLQo+ID4g PiAgZHJpdmVycy9tZmQvcms4eHgtc3BpLmMgICB8IDEyMiArKysrKysrKysrKysKPiA+ID4gIGlu Y2x1ZGUvbGludXgvbWZkL3JrODA4LmggfCA0MDkgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysKPiA+ID4gIDUgZmlsZXMgY2hhbmdlZCwgNjExIGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCj4gPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tZmQvcms4eHgt c3BpLmMKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9LY29uZmlnIGIvZHJp dmVycy9tZmQvS2NvbmZpZwo+ID4gPiBpbmRleCA2OTJlMzgyODNiZGEuLjEzNTgyZWE1Y2I0NCAx MDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9tZmQvS2NvbmZpZwo+ID4gPiArKysgYi9kcml2ZXJz L21mZC9LY29uZmlnCj4gPiA+IEBAIC0xMjIyLDYgKzEyMjIsMjAgQEAgY29uZmlnIE1GRF9SSzhY WF9JMkMKPiA+ID4gIAkgIHRocm91Z2ggSTJDIGludGVyZmFjZS4gVGhlIGRldmljZSBzdXBwb3J0 cyBtdWx0aXBsZSBzdWItZGV2aWNlcwo+ID4gPiAgCSAgaW5jbHVkaW5nIGludGVycnVwdHMsIFJU QywgTERPICYgRENEQyByZWd1bGF0b3JzLCBhbmQgb25rZXkuCj4gPiA+ICAKPiA+ID4gK2NvbmZp ZyBNRkRfUks4WFhfU1BJCj4gPiA+ICsJdHJpc3RhdGUgIlJvY2tjaGlwIFJLODA2IFBvd2VyIE1h bmFnZW1lbnQgQ2hpcCIKPiA+ID4gKwlkZXBlbmRzIG9uIFNQSSAmJiBPRgo+ID4gPiArCXNlbGVj dCBNRkRfQ09SRQo+ID4gPiArCXNlbGVjdCBSRUdNQVBfU1BJCj4gPiA+ICsJc2VsZWN0IFJFR01B UF9JUlEKPiA+ID4gKwlzZWxlY3QgTUZEX1JLOFhYCj4gPiA+ICsJaGVscAo+ID4gPiArCSAgSWYg eW91IHNheSB5ZXMgaGVyZSB5b3UgZ2V0IHN1cHBvcnQgZm9yIHRoZSBSSzgwNiBQb3dlciBNYW5h Z2VtZW50Cj4gPiA+ICsJICBjaGlwLgo+ID4gPiArCSAgVGhpcyBkcml2ZXIgcHJvdmlkZXMgY29t bW9uIHN1cHBvcnQgZm9yIGFjY2Vzc2luZyB0aGUgZGV2aWNlCj4gPiA+ICsJICB0aHJvdWdoIGFu IFNQSSBpbnRlcmZhY2UuIFRoZSBkZXZpY2Ugc3VwcG9ydHMgbXVsdGlwbGUgc3ViLWRldmljZXMK PiA+ID4gKwkgIGluY2x1ZGluZyBpbnRlcnJ1cHRzLCBMRE8gJiBEQ0RDIHJlZ3VsYXRvcnMsIGFu ZCBwb3dlciBvbi1rZXkuCj4gPiA+ICsKPiA+ID4gIGNvbmZpZyBNRkRfUk41VDYxOAo+ID4gPiAg CXRyaXN0YXRlICJSaWNvaCBSTjVUNTY3LzYxOCBQTUlDIgo+ID4gPiAgCWRlcGVuZHMgb24gSTJD Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9NYWtlZmlsZSBiL2RyaXZlcnMvbWZkL01h a2VmaWxlCj4gPiA+IGluZGV4IGY2NWVmMWJkMDgxMC4uYTg4ZjI3Y2Q4MzdiIDEwMDY0NAo+ID4g PiAtLS0gYS9kcml2ZXJzL21mZC9NYWtlZmlsZQo+ID4gPiArKysgYi9kcml2ZXJzL21mZC9NYWtl ZmlsZQo+ID4gPiBAQCAtMjIyLDYgKzIyMiw3IEBAIG9iai0kKENPTkZJR19NRkRfTlRYRUMpCQkr PSBudHhlYy5vCj4gPiA+ICBvYmotJChDT05GSUdfTUZEX1JDNVQ1ODMpCSs9IHJjNXQ1ODMubyBy YzV0NTgzLWlycS5vCj4gPiA+ICBvYmotJChDT05GSUdfTUZEX1JLOFhYKQkJKz0gcms4eHgtY29y ZS5vCj4gPiA+ICBvYmotJChDT05GSUdfTUZEX1JLOFhYX0kyQykJKz0gcms4eHgtaTJjLm8KPiA+ ID4gK29iai0kKENPTkZJR19NRkRfUks4WFhfU1BJKQkrPSByazh4eC1zcGkubwo+ID4gPiAgb2Jq LSQoQ09ORklHX01GRF9STjVUNjE4KQkrPSBybjV0NjE4Lm8KPiA+ID4gIG9iai0kKENPTkZJR19N RkRfU0VDX0NPUkUpCSs9IHNlYy1jb3JlLm8gc2VjLWlycS5vCj4gPiA+ICBvYmotJChDT05GSUdf TUZEX1NZU0NPTikJKz0gc3lzY29uLm8KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL3Jr OHh4LWNvcmUuYyBiL2RyaXZlcnMvbWZkL3JrOHh4LWNvcmUuYwo+ID4gPiBpbmRleCBjNTJmNWZh MWE0ZGEuLjI4OWY0YzFmMzBjMiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9tZmQvcms4eHgt Y29yZS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvbWZkL3JrOHh4LWNvcmUuYwo+ID4gPiBAQCAtMzcs NiArMzcsMTEgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCByZXNvdXJjZSByazgwNV9rZXlfcmVzb3Vy Y2VzW10gPSB7Cj4gPiA+ICAJREVGSU5FX1JFU19JUlEoUks4MDVfSVJRX1BXUk9OX0ZBTEwpLAo+ ID4gPiAgfTsKPiA+ID4gIAo+ID4gPiArc3RhdGljIHN0cnVjdCByZXNvdXJjZSByazgwNl9wd3Jr ZXlfcmVzb3VyY2VzW10gPSB7Cj4gPiA+ICsJREVGSU5FX1JFU19JUlEoUks4MDZfSVJRX1BXUk9O X0ZBTEwpLAo+ID4gPiArCURFRklORV9SRVNfSVJRKFJLODA2X0lSUV9QV1JPTl9SSVNFKSwKPiA+ ID4gK307Cj4gPiA+ICsKPiA+ID4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmVzb3VyY2Ugcms4MTdf cHdya2V5X3Jlc291cmNlc1tdID0gewo+ID4gPiAgCURFRklORV9SRVNfSVJRKFJLODE3X0lSUV9Q V1JPTl9SSVNFKSwKPiA+ID4gIAlERUZJTkVfUkVTX0lSUShSSzgxN19JUlFfUFdST05fRkFMTCks Cj4gPiA+IEBAIC02NCw2ICs2OSwxNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG1mZF9jZWxsIHJr ODA1c1tdID0gewo+ID4gPiAgCX0sCj4gPiA+ICB9Owo+ID4gPiAgCj4gPiA+ICtzdGF0aWMgY29u c3Qgc3RydWN0IG1mZF9jZWxsIHJrODA2c1tdID0gewo+ID4gPiArCXsgLm5hbWUgPSAicms4MDUt cGluY3RybCIsIH0sCj4gPiA+ICsJeyAubmFtZSA9ICJyazgwOC1yZWd1bGF0b3IiLCB9LAo+ID4g PiArCXsKPiA+ID4gKwkJLm5hbWUgPSAicms4MDUtcHdya2V5IiwKPiA+ID4gKwkJLm51bV9yZXNv dXJjZXMgPSBBUlJBWV9TSVpFKHJrODA2X3B3cmtleV9yZXNvdXJjZXMpLAo+ID4gPiArCQkucmVz b3VyY2VzID0gJnJrODA2X3B3cmtleV9yZXNvdXJjZXNbMF0sCj4gPiAKPiA+IE15IE9DRC1zZW5z ZSBpcyB0aW5nbGluZy4KPiA+IAo+ID4gQ291bGQgeW91IHBsZWFzZSBhZGQgdGhlIHJlc291cmNl cyAqYmVmb3JlKiB0aGUgbnVtX3Jlc291cmNlcyBwbGVhc2U/Cj4gPiAKPiA+IEFsc286ICcucmVz b3VyY2VzID0gcms4MDZfcHdya2V5X3Jlc291cmNlcycgaXMgZmluZQo+IAo+IEFjay4KPiAKPiA+ IAo+ID4gPiArCX0sCj4gPiA+ICt9Owo+ID4gPiArCj4gPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0 IG1mZF9jZWxsIHJrODA4c1tdID0gewo+ID4gPiAgCXsgLm5hbWUgPSAicms4MDgtY2xrb3V0Iiwg LmlkID0gUExBVEZPUk1fREVWSURfTk9ORSwgfSwKPiA+ID4gIAl7IC5uYW1lID0gInJrODA4LXJl Z3VsYXRvciIsIC5pZCA9IFBMQVRGT1JNX0RFVklEX05PTkUsIH0sCj4gPiA+IEBAIC0xMjIsNiAr MTM3LDEyIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgcms4MDhfcmVnX2RhdGEgcms4MDVfcHJlX2lu aXRfcmVnW10gPSB7Cj4gPiA+ICAJe1JLODA1X1RIRVJNQUxfUkVHLCBURU1QX0hPVERJRV9NU0ss IFRFTVAxMTVDfSwKPiA+ID4gIH07Cj4gPiA+ICAKPiA+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qg cms4MDhfcmVnX2RhdGEgcms4MDZfcHJlX2luaXRfcmVnW10gPSB7Cj4gPiA+ICsJeyBSSzgwNl9H UElPX0lOVF9DT05GSUcsIFJLODA2X0lOVF9QT0xfTVNLLCBSSzgwNl9JTlRfUE9MX0wgfSwKPiA+ ID4gKwl7IFJLODA2X1NZU19DRkczLCBSSzgwNl9TTEFWRV9SRVNUQVJUX0ZVTl9NU0ssIFJLODA2 X1NMQVZFX1JFU1RBUlRfRlVOX0VOIH0sCj4gPiA+ICsJeyBSSzgwNl9TWVNfT1BUSU9OLCBSSzgw Nl9TWVNfRU5CMl8yTV9NU0ssIFJLODA2X1NZU19FTkIyXzJNX0VOIH0sCj4gPiA+ICt9Owo+ID4g PiArCj4gPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IHJrODA4X3JlZ19kYXRhIHJrODA4X3ByZV9p bml0X3JlZ1tdID0gewo+ID4gPiAgCXsgUks4MDhfQlVDSzNfQ09ORklHX1JFRywgQlVDS19JTE1J Tl9NQVNLLCAgQlVDS19JTE1JTl8xNTBNQSB9LAo+ID4gPiAgCXsgUks4MDhfQlVDSzRfQ09ORklH X1JFRywgQlVDS19JTE1JTl9NQVNLLCAgQlVDS19JTE1JTl8yMDBNQSB9LAo+ID4gPiBAQCAtMjcy LDYgKzI5MywyNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJlZ21hcF9pcnEgcms4MDVfaXJxc1td ID0gewo+ID4gPiAgCX0sCj4gPiA+ICB9Owo+ID4gPiAgCj4gPiA+ICtzdGF0aWMgY29uc3Qgc3Ry dWN0IHJlZ21hcF9pcnEgcms4MDZfaXJxc1tdID0gewo+ID4gPiArCS8qIElOVF9TVFMwIElSUXMg Ki8KPiA+ID4gKwlSRUdNQVBfSVJRX1JFRyhSSzgwNl9JUlFfUFdST05fRkFMTCwgMCwgUks4MDZf SU5UX1NUU19QV1JPTl9GQUxMKSwKPiA+ID4gKwlSRUdNQVBfSVJRX1JFRyhSSzgwNl9JUlFfUFdS T05fUklTRSwgMCwgUks4MDZfSU5UX1NUU19QV1JPTl9SSVNFKSwKPiA+ID4gKwlSRUdNQVBfSVJR X1JFRyhSSzgwNl9JUlFfUFdST04sIDAsIFJLODA2X0lOVF9TVFNfUFdST04pLAo+ID4gPiArCVJF R01BUF9JUlFfUkVHKFJLODA2X0lSUV9QV1JPTl9MUCwgMCwgUks4MDZfSU5UX1NUU19QV1JPTl9M UCksCj4gPiA+ICsJUkVHTUFQX0lSUV9SRUcoUks4MDZfSVJRX0hPVERJRSwgMCwgUks4MDZfSU5U X1NUU19IT1RESUUpLAo+ID4gPiArCVJFR01BUF9JUlFfUkVHKFJLODA2X0lSUV9WRENfUklTRSwg MCwgUks4MDZfSU5UX1NUU19WRENfUklTRSksCj4gPiA+ICsJUkVHTUFQX0lSUV9SRUcoUks4MDZf SVJRX1ZEQ19GQUxMLCAwLCBSSzgwNl9JTlRfU1RTX1ZEQ19GQUxMKSwKPiA+ID4gKwlSRUdNQVBf SVJRX1JFRyhSSzgwNl9JUlFfVkJfTE8sIDAsIFJLODA2X0lOVF9TVFNfVkJfTE8pLAo+ID4gPiAr CS8qIElOVF9TVFMxIElSUXMgKi8KPiA+ID4gKwlSRUdNQVBfSVJRX1JFRyhSSzgwNl9JUlFfUkVW MCwgMSwgUks4MDZfSU5UX1NUU19SRVYwKSwKPiA+ID4gKwlSRUdNQVBfSVJRX1JFRyhSSzgwNl9J UlFfUkVWMSwgMSwgUks4MDZfSU5UX1NUU19SRVYxKSwKPiA+ID4gKwlSRUdNQVBfSVJRX1JFRyhS SzgwNl9JUlFfUkVWMiwgMSwgUks4MDZfSU5UX1NUU19SRVYyKSwKPiA+ID4gKwlSRUdNQVBfSVJR X1JFRyhSSzgwNl9JUlFfQ1JDX0VSUk9SLCAxLCBSSzgwNl9JTlRfU1RTX0NSQ19FUlJPUiksCj4g PiA+ICsJUkVHTUFQX0lSUV9SRUcoUks4MDZfSVJRX1NMUDNfR1BJTywgMSwgUks4MDZfSU5UX1NU U19TTFAzX0dQSU8pLAo+ID4gPiArCVJFR01BUF9JUlFfUkVHKFJLODA2X0lSUV9TTFAyX0dQSU8s IDEsIFJLODA2X0lOVF9TVFNfU0xQMl9HUElPKSwKPiA+ID4gKwlSRUdNQVBfSVJRX1JFRyhSSzgw Nl9JUlFfU0xQMV9HUElPLCAxLCBSSzgwNl9JTlRfU1RTX1NMUDFfR1BJTyksCj4gPiA+ICsJUkVH TUFQX0lSUV9SRUcoUks4MDZfSVJRX1dEVCwgMSwgUks4MDZfSU5UX1NUU19XRFQpLAo+ID4gPiAr fTsKPiA+ID4gKwo+ID4gPiAgc3RhdGljIGNvbnN0IHN0cnVjdCByZWdtYXBfaXJxIHJrODA4X2ly cXNbXSA9IHsKPiA+ID4gIAkvKiBJTlRfU1RTICovCj4gPiA+ICAJW1JLODA4X0lSUV9WT1VUX0xP XSA9IHsKPiA+ID4gQEAgLTQyMiw2ICs0NjQsMTggQEAgc3RhdGljIHN0cnVjdCByZWdtYXBfaXJx X2NoaXAgcms4MDVfaXJxX2NoaXAgPSB7Cj4gPiA+ICAJLmluaXRfYWNrX21hc2tlZCA9IHRydWUs Cj4gPiA+ICB9Owo+ID4gPiAgCj4gPiA+ICtzdGF0aWMgc3RydWN0IHJlZ21hcF9pcnFfY2hpcCBy azgwNl9pcnFfY2hpcCA9IHsKPiA+ID4gKwkubmFtZSA9ICJyazgwNiIsCj4gPiA+ICsJLmlycXMg PSByazgwNl9pcnFzLAo+ID4gPiArCS5udW1faXJxcyA9IEFSUkFZX1NJWkUocms4MDZfaXJxcyks Cj4gPiA+ICsJLm51bV9yZWdzID0gMiwKPiA+ID4gKwkuaXJxX3JlZ19zdHJpZGUgPSAyLAo+ID4g PiArCS5tYXNrX2Jhc2UgPSBSSzgwNl9JTlRfTVNLMCwKPiA+ID4gKwkuc3RhdHVzX2Jhc2UgPSBS SzgwNl9JTlRfU1RTMCwKPiA+ID4gKwkuYWNrX2Jhc2UgPSBSSzgwNl9JTlRfU1RTMCwKPiA+ID4g KwkuaW5pdF9hY2tfbWFza2VkID0gdHJ1ZSwKPiA+ID4gK307Cj4gPiA+ICsKPiA+ID4gIHN0YXRp YyBjb25zdCBzdHJ1Y3QgcmVnbWFwX2lycV9jaGlwIHJrODA4X2lycV9jaGlwID0gewo+ID4gPiAg CS5uYW1lID0gInJrODA4IiwKPiA+ID4gIAkuaXJxcyA9IHJrODA4X2lycXMsCj4gPiA+IEBAIC01 NDgsNiArNjAyLDcgQEAgaW50IHJrOHh4X3Byb2JlKHN0cnVjdCBkZXZpY2UgKmRldiwgaW50IHZh cmlhbnQsIHVuc2lnbmVkIGludCBpcnEsIHN0cnVjdCByZWdtYXAKPiA+ID4gIAlzdHJ1Y3Qgcms4 MDggKnJrODA4Owo+ID4gPiAgCWNvbnN0IHN0cnVjdCByazgwOF9yZWdfZGF0YSAqcHJlX2luaXRf cmVnOwo+ID4gPiAgCWNvbnN0IHN0cnVjdCBtZmRfY2VsbCAqY2VsbHM7Cj4gPiA+ICsJYm9vbCBk dWFsX3N1cHBvcnQgPSBmYWxzZTsKPiA+ID4gIAlpbnQgbnJfcHJlX2luaXRfcmVnczsKPiA+ID4g IAlpbnQgbnJfY2VsbHM7Cj4gPiA+ICAJaW50IHJldDsKPiA+ID4gQEAgLTU2OSw2ICs2MjQsMTQg QEAgaW50IHJrOHh4X3Byb2JlKHN0cnVjdCBkZXZpY2UgKmRldiwgaW50IHZhcmlhbnQsIHVuc2ln bmVkIGludCBpcnEsIHN0cnVjdCByZWdtYXAKPiA+ID4gIAkJY2VsbHMgPSByazgwNXM7Cj4gPiA+ ICAJCW5yX2NlbGxzID0gQVJSQVlfU0laRShyazgwNXMpOwo+ID4gPiAgCQlicmVhazsKPiA+ID4g KwljYXNlIFJLODA2X0lEOgo+ID4gPiArCQlyazgwOC0+cmVnbWFwX2lycV9jaGlwID0gJnJrODA2 X2lycV9jaGlwOwo+ID4gPiArCQlwcmVfaW5pdF9yZWcgPSByazgwNl9wcmVfaW5pdF9yZWc7Cj4g PiA+ICsJCW5yX3ByZV9pbml0X3JlZ3MgPSBBUlJBWV9TSVpFKHJrODA2X3ByZV9pbml0X3JlZyk7 Cj4gPiA+ICsJCWNlbGxzID0gcms4MDZzOwo+ID4gPiArCQlucl9jZWxscyA9IEFSUkFZX1NJWkUo cms4MDZzKTsKPiA+ID4gKwkJZHVhbF9zdXBwb3J0ID0gdHJ1ZTsKPiA+ID4gKwkJYnJlYWs7Cj4g PiA+ICAJY2FzZSBSSzgwOF9JRDoKPiA+ID4gIAkJcms4MDgtPnJlZ21hcF9pcnFfY2hpcCA9ICZy azgwOF9pcnFfY2hpcDsKPiA+ID4gIAkJcHJlX2luaXRfcmVnID0gcms4MDhfcHJlX2luaXRfcmVn Owo+ID4gPiBAQCAtNjAyLDcgKzY2NSw3IEBAIGludCByazh4eF9wcm9iZShzdHJ1Y3QgZGV2aWNl ICpkZXYsIGludCB2YXJpYW50LCB1bnNpZ25lZCBpbnQgaXJxLCBzdHJ1Y3QgcmVnbWFwCj4gPiA+ ICAJCXJldHVybiBkZXZfZXJyX3Byb2JlKGRldiwgLUVJTlZBTCwgIk5vIGludGVycnVwdCBzdXBw b3J0LCBubyBjb3JlIElSUVxuIik7Cj4gPiA+ICAKPiA+ID4gIAlyZXQgPSBkZXZtX3JlZ21hcF9h ZGRfaXJxX2NoaXAoZGV2LCByazgwOC0+cmVnbWFwLCBpcnEsCj4gPiA+IC0JCQkJICAgICAgIElS UUZfT05FU0hPVCwgLTEsCj4gPiA+ICsJCQkJICAgICAgIElSUUZfT05FU0hPVCB8IChkdWFsX3N1 cHBvcnQgPyBJUlFGX1NIQVJFRCA6IDApLCAtMSwKPiA+IAo+ID4gV2h5IG5vdCAnZHVhbF9zdXBw b3J0ID0gSVJRRl9TSEFSRUQnLCB0aGVuIHwgaXQgcmVnYXJkbGVzcz8KPiAKPiBBY2sKPiAKPiA+ IAo+ID4gPiAgCQkJCSAgICAgICByazgwOC0+cmVnbWFwX2lycV9jaGlwLCAmcms4MDgtPmlycV9k YXRhKTsKPiA+ID4gIAlpZiAocmV0KQo+ID4gPiAgCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYs IHJldCwgIkZhaWxlZCB0byBhZGQgaXJxX2NoaXBcbiIpOwo+ID4gPiBAQCAtNjE3LDcgKzY4MCw3 IEBAIGludCByazh4eF9wcm9iZShzdHJ1Y3QgZGV2aWNlICpkZXYsIGludCB2YXJpYW50LCB1bnNp Z25lZCBpbnQgaXJxLCBzdHJ1Y3QgcmVnbWFwCj4gPiA+ICAJCQkJCSAgICAgcHJlX2luaXRfcmVn W2ldLmFkZHIpOwo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAtCXJldCA9IGRldm1fbWZkX2FkZF9k ZXZpY2VzKGRldiwgUExBVEZPUk1fREVWSURfTk9ORSwKPiA+ID4gKwlyZXQgPSBkZXZtX21mZF9h ZGRfZGV2aWNlcyhkZXYsIGR1YWxfc3VwcG9ydCA/IFBMQVRGT1JNX0RFVklEX0FVVE8gOiBQTEFU Rk9STV9ERVZJRF9OT05FLAo+ID4gCj4gPiBBbnkgcmVhc29uIHdoeSB5b3UgY2FuJ3QgdXNlIEFV VE8gYWxsIHRoZSB0aW1lPwo+IAo+IFRoYXQgd291bGQgY2hhbmdlIGRldmljZSBuYW1lcyAoYW5k IHRodXMgc3lzZnMgcGF0aHMpIGZvciBhbHJlYWR5Cj4gc3VwcG9ydGVkIGRldmljZXMuIERFVklE X0FVVE8gYXBwZW5kcyBhICIuPG51bWJlcj4iIHN1ZmZpeCBjb21wYXJlZAo+IHRvIERFVklEX05P TkUuCgpIb3cgYWJvdXQgdXNpbmcgY2VsbC0+aWQgaW5zdGVhZCBvZiBkb2luZyB0aGlzIGxpdHRs ZSBkYW5jZT8KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApM aW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97115C38142 for ; Mon, 23 Jan 2023 15:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231736AbjAWP2K (ORCPT ); Mon, 23 Jan 2023 10:28:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231847AbjAWP2J (ORCPT ); Mon, 23 Jan 2023 10:28:09 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 171CF55A5; Mon, 23 Jan 2023 07:28:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2FD5060F5E; Mon, 23 Jan 2023 15:28:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C6D9C433EF; Mon, 23 Jan 2023 15:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674487685; bh=8nopWCghWSW6qg8L9ZsS34jM69jMO1LFoFfm/AalAfo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RUxRmKp7CiHKY961/2uBdqNaRyuSjLFLuN5KZxLhGIBaSbPplMiYkKHSdBxj2WOWJ uXECKrCONlmX91BA7249i7kYHI66nZWawITAlgpYhgbQ3xL7umIgOE4xoEgzspGaQD nUNzaSzoHeJUMeh2hphujQmnzLs/+sO2z24JxDVhSrZKlMChdGKup/5KjRrjPyTIlL wyHR+IuQqTDXtmpbS9uKt1BfYKhLtKnKuFPoeqF3X7ZLq4RCRu/1BsyiaA74XJpPc/ 81+4RPUdPSMD3WS4TfplghlIJsgNxur8wySmD4FSl0ouRHTd5vr5FjtPC7bxx6DZ+3 c+kROTFx620qw== Date: Mon, 23 Jan 2023 15:27:58 +0000 From: Lee Jones To: Sebastian Reichel Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Linus Walleij , Mark Brown , Liam Girdwood , Alexandre Belloni , Alessandro Zummo , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCHv5 07/10] mfd: rk8xx: add rk806 support Message-ID: References: <20230109172723.60304-1-sebastian.reichel@collabora.com> <20230109172723.60304-8-sebastian.reichel@collabora.com> <20230123143321.lsddiol6bo2agfbk@mercury.elektranox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230123143321.lsddiol6bo2agfbk@mercury.elektranox.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 23 Jan 2023, Sebastian Reichel wrote: > Hi, > > On Fri, Jan 20, 2023 at 04:59:21PM +0000, Lee Jones wrote: > > On Mon, 09 Jan 2023, Sebastian Reichel wrote: > > > > > Add support for SPI connected rk806, which is used by the RK3588 > > > evaluation boards. The PMIC is advertised to support I2C and SPI, > > > but the evaluation boards all use SPI. Thus only SPI support is > > > added here. > > > > > > Signed-off-by: Sebastian Reichel > > > --- > > > drivers/mfd/Kconfig | 14 ++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/rk8xx-core.c | 67 ++++++- > > > drivers/mfd/rk8xx-spi.c | 122 ++++++++++++ > > > include/linux/mfd/rk808.h | 409 ++++++++++++++++++++++++++++++++++++++ > > > 5 files changed, 611 insertions(+), 2 deletions(-) > > > create mode 100644 drivers/mfd/rk8xx-spi.c > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index 692e38283bda..13582ea5cb44 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -1222,6 +1222,20 @@ config MFD_RK8XX_I2C > > > through I2C interface. The device supports multiple sub-devices > > > including interrupts, RTC, LDO & DCDC regulators, and onkey. > > > > > > +config MFD_RK8XX_SPI > > > + tristate "Rockchip RK806 Power Management Chip" > > > + depends on SPI && OF > > > + select MFD_CORE > > > + select REGMAP_SPI > > > + select REGMAP_IRQ > > > + select MFD_RK8XX > > > + help > > > + If you say yes here you get support for the RK806 Power Management > > > + chip. > > > + This driver provides common support for accessing the device > > > + through an SPI interface. The device supports multiple sub-devices > > > + including interrupts, LDO & DCDC regulators, and power on-key. > > > + > > > config MFD_RN5T618 > > > tristate "Ricoh RN5T567/618 PMIC" > > > depends on I2C > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > > index f65ef1bd0810..a88f27cd837b 100644 > > > --- a/drivers/mfd/Makefile > > > +++ b/drivers/mfd/Makefile > > > @@ -222,6 +222,7 @@ obj-$(CONFIG_MFD_NTXEC) += ntxec.o > > > obj-$(CONFIG_MFD_RC5T583) += rc5t583.o rc5t583-irq.o > > > obj-$(CONFIG_MFD_RK8XX) += rk8xx-core.o > > > obj-$(CONFIG_MFD_RK8XX_I2C) += rk8xx-i2c.o > > > +obj-$(CONFIG_MFD_RK8XX_SPI) += rk8xx-spi.o > > > obj-$(CONFIG_MFD_RN5T618) += rn5t618.o > > > obj-$(CONFIG_MFD_SEC_CORE) += sec-core.o sec-irq.o > > > obj-$(CONFIG_MFD_SYSCON) += syscon.o > > > diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c > > > index c52f5fa1a4da..289f4c1f30c2 100644 > > > --- a/drivers/mfd/rk8xx-core.c > > > +++ b/drivers/mfd/rk8xx-core.c > > > @@ -37,6 +37,11 @@ static const struct resource rk805_key_resources[] = { > > > DEFINE_RES_IRQ(RK805_IRQ_PWRON_FALL), > > > }; > > > > > > +static struct resource rk806_pwrkey_resources[] = { > > > + DEFINE_RES_IRQ(RK806_IRQ_PWRON_FALL), > > > + DEFINE_RES_IRQ(RK806_IRQ_PWRON_RISE), > > > +}; > > > + > > > static const struct resource rk817_pwrkey_resources[] = { > > > DEFINE_RES_IRQ(RK817_IRQ_PWRON_RISE), > > > DEFINE_RES_IRQ(RK817_IRQ_PWRON_FALL), > > > @@ -64,6 +69,16 @@ static const struct mfd_cell rk805s[] = { > > > }, > > > }; > > > > > > +static const struct mfd_cell rk806s[] = { > > > + { .name = "rk805-pinctrl", }, > > > + { .name = "rk808-regulator", }, > > > + { > > > + .name = "rk805-pwrkey", > > > + .num_resources = ARRAY_SIZE(rk806_pwrkey_resources), > > > + .resources = &rk806_pwrkey_resources[0], > > > > My OCD-sense is tingling. > > > > Could you please add the resources *before* the num_resources please? > > > > Also: '.resources = rk806_pwrkey_resources' is fine > > Ack. > > > > > > + }, > > > +}; > > > + > > > static const struct mfd_cell rk808s[] = { > > > { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, }, > > > { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, }, > > > @@ -122,6 +137,12 @@ static const struct rk808_reg_data rk805_pre_init_reg[] = { > > > {RK805_THERMAL_REG, TEMP_HOTDIE_MSK, TEMP115C}, > > > }; > > > > > > +static const struct rk808_reg_data rk806_pre_init_reg[] = { > > > + { RK806_GPIO_INT_CONFIG, RK806_INT_POL_MSK, RK806_INT_POL_L }, > > > + { RK806_SYS_CFG3, RK806_SLAVE_RESTART_FUN_MSK, RK806_SLAVE_RESTART_FUN_EN }, > > > + { RK806_SYS_OPTION, RK806_SYS_ENB2_2M_MSK, RK806_SYS_ENB2_2M_EN }, > > > +}; > > > + > > > static const struct rk808_reg_data rk808_pre_init_reg[] = { > > > { RK808_BUCK3_CONFIG_REG, BUCK_ILMIN_MASK, BUCK_ILMIN_150MA }, > > > { RK808_BUCK4_CONFIG_REG, BUCK_ILMIN_MASK, BUCK_ILMIN_200MA }, > > > @@ -272,6 +293,27 @@ static const struct regmap_irq rk805_irqs[] = { > > > }, > > > }; > > > > > > +static const struct regmap_irq rk806_irqs[] = { > > > + /* INT_STS0 IRQs */ > > > + REGMAP_IRQ_REG(RK806_IRQ_PWRON_FALL, 0, RK806_INT_STS_PWRON_FALL), > > > + REGMAP_IRQ_REG(RK806_IRQ_PWRON_RISE, 0, RK806_INT_STS_PWRON_RISE), > > > + REGMAP_IRQ_REG(RK806_IRQ_PWRON, 0, RK806_INT_STS_PWRON), > > > + REGMAP_IRQ_REG(RK806_IRQ_PWRON_LP, 0, RK806_INT_STS_PWRON_LP), > > > + REGMAP_IRQ_REG(RK806_IRQ_HOTDIE, 0, RK806_INT_STS_HOTDIE), > > > + REGMAP_IRQ_REG(RK806_IRQ_VDC_RISE, 0, RK806_INT_STS_VDC_RISE), > > > + REGMAP_IRQ_REG(RK806_IRQ_VDC_FALL, 0, RK806_INT_STS_VDC_FALL), > > > + REGMAP_IRQ_REG(RK806_IRQ_VB_LO, 0, RK806_INT_STS_VB_LO), > > > + /* INT_STS1 IRQs */ > > > + REGMAP_IRQ_REG(RK806_IRQ_REV0, 1, RK806_INT_STS_REV0), > > > + REGMAP_IRQ_REG(RK806_IRQ_REV1, 1, RK806_INT_STS_REV1), > > > + REGMAP_IRQ_REG(RK806_IRQ_REV2, 1, RK806_INT_STS_REV2), > > > + REGMAP_IRQ_REG(RK806_IRQ_CRC_ERROR, 1, RK806_INT_STS_CRC_ERROR), > > > + REGMAP_IRQ_REG(RK806_IRQ_SLP3_GPIO, 1, RK806_INT_STS_SLP3_GPIO), > > > + REGMAP_IRQ_REG(RK806_IRQ_SLP2_GPIO, 1, RK806_INT_STS_SLP2_GPIO), > > > + REGMAP_IRQ_REG(RK806_IRQ_SLP1_GPIO, 1, RK806_INT_STS_SLP1_GPIO), > > > + REGMAP_IRQ_REG(RK806_IRQ_WDT, 1, RK806_INT_STS_WDT), > > > +}; > > > + > > > static const struct regmap_irq rk808_irqs[] = { > > > /* INT_STS */ > > > [RK808_IRQ_VOUT_LO] = { > > > @@ -422,6 +464,18 @@ static struct regmap_irq_chip rk805_irq_chip = { > > > .init_ack_masked = true, > > > }; > > > > > > +static struct regmap_irq_chip rk806_irq_chip = { > > > + .name = "rk806", > > > + .irqs = rk806_irqs, > > > + .num_irqs = ARRAY_SIZE(rk806_irqs), > > > + .num_regs = 2, > > > + .irq_reg_stride = 2, > > > + .mask_base = RK806_INT_MSK0, > > > + .status_base = RK806_INT_STS0, > > > + .ack_base = RK806_INT_STS0, > > > + .init_ack_masked = true, > > > +}; > > > + > > > static const struct regmap_irq_chip rk808_irq_chip = { > > > .name = "rk808", > > > .irqs = rk808_irqs, > > > @@ -548,6 +602,7 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap > > > struct rk808 *rk808; > > > const struct rk808_reg_data *pre_init_reg; > > > const struct mfd_cell *cells; > > > + bool dual_support = false; > > > int nr_pre_init_regs; > > > int nr_cells; > > > int ret; > > > @@ -569,6 +624,14 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap > > > cells = rk805s; > > > nr_cells = ARRAY_SIZE(rk805s); > > > break; > > > + case RK806_ID: > > > + rk808->regmap_irq_chip = &rk806_irq_chip; > > > + pre_init_reg = rk806_pre_init_reg; > > > + nr_pre_init_regs = ARRAY_SIZE(rk806_pre_init_reg); > > > + cells = rk806s; > > > + nr_cells = ARRAY_SIZE(rk806s); > > > + dual_support = true; > > > + break; > > > case RK808_ID: > > > rk808->regmap_irq_chip = &rk808_irq_chip; > > > pre_init_reg = rk808_pre_init_reg; > > > @@ -602,7 +665,7 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap > > > return dev_err_probe(dev, -EINVAL, "No interrupt support, no core IRQ\n"); > > > > > > ret = devm_regmap_add_irq_chip(dev, rk808->regmap, irq, > > > - IRQF_ONESHOT, -1, > > > + IRQF_ONESHOT | (dual_support ? IRQF_SHARED : 0), -1, > > > > Why not 'dual_support = IRQF_SHARED', then | it regardless? > > Ack > > > > > > rk808->regmap_irq_chip, &rk808->irq_data); > > > if (ret) > > > return dev_err_probe(dev, ret, "Failed to add irq_chip\n"); > > > @@ -617,7 +680,7 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap > > > pre_init_reg[i].addr); > > > } > > > > > > - ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, > > > + ret = devm_mfd_add_devices(dev, dual_support ? PLATFORM_DEVID_AUTO : PLATFORM_DEVID_NONE, > > > > Any reason why you can't use AUTO all the time? > > That would change device names (and thus sysfs paths) for already > supported devices. DEVID_AUTO appends a "." suffix compared > to DEVID_NONE. How about using cell->id instead of doing this little dance? -- Lee Jones [李琼斯]