From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: "Jiri Slaby" <jirislaby@kernel.org>,
"Lukas Wunner" <lukas@wunner.de>,
"Dominique Martinet" <dominique.martinet@atmark-techno.com>,
"Daisuke Mizobuchi" <mizo@atmark-techno.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 5.15.y v2] serial: fixup backport of "serial: Deassert Transmit Enable on probe in driver-specific way"
Date: Thu, 12 Jan 2023 13:41:48 +0100 [thread overview]
Message-ID: <Y8AADD1b19FsTMRD@kroah.com> (raw)
In-Reply-To: <20221222114414.1886632-1-linux@rasmusvillemoes.dk>
On Thu, Dec 22, 2022 at 12:44:14PM +0100, Rasmus Villemoes wrote:
> When 7c7f9bc986e6 ("serial: Deassert Transmit Enable on probe in
> driver-specific way") got backported to 5.15.y, there known as
> b079d3775237, some hunks were accidentally left out.
>
> In fsl_lpuart.c, this amounts to uart_remove_one_port() being called
> in an error path despite uart_add_one_port() not having been called.
>
> In serial_core.c, it is possible that the omission in
> uart_suspend_port() is harmless, but the backport did have the
> corresponding hunk in uart_resume_port(), it runs counter to the
> original commit's intention of
>
> Skip any invocation of ->set_mctrl() if RS485 is enabled.
>
> and it's certainly better to be aligned with upstream.
>
> Fixes: b079d3775237 ("serial: Deassert Transmit Enable on probe in driver-specific way")
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>
> v2: Also amend uart_suspend_port(), update commit log accordingly.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-01-12 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 10:23 [PATCH 5.15.y] tty: serial: fsl_lpuart: fixup error path in lpuart_probe() Rasmus Villemoes
2022-12-22 11:44 ` [PATCH 5.15.y v2] serial: fixup backport of "serial: Deassert Transmit Enable on probe in driver-specific way" Rasmus Villemoes
2022-12-23 2:12 ` Dominique Martinet
2023-01-12 12:41 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8AADD1b19FsTMRD@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dominique.martinet@atmark-techno.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukas@wunner.de \
--cc=mizo@atmark-techno.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.