From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dominique Martinet <dominique.martinet@atmark-techno.com>
Cc: "Jiri Slaby" <jirislaby@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Daisuke Mizobuchi" <mizo@atmark-techno.com>,
stable@vger.kernel.org, linux-serial@vger.kernel.org,
"Indan Zupancic" <Indan.Zupancic@mep-info.com>
Subject: Re: [PATCH 5.10 1/2] fsl_lpuart: Don't enable interrupts too early
Date: Thu, 12 Jan 2023 13:47:13 +0100 [thread overview]
Message-ID: <Y8ABUYClE1ychdVp@kroah.com> (raw)
In-Reply-To: <20221223042354.4080724-1-dominique.martinet@atmark-techno.com>
On Fri, Dec 23, 2022 at 01:23:53PM +0900, Dominique Martinet wrote:
> From: Indan Zupancic <Indan.Zupancic@mep-info.com>
>
> [ Upstream commit 401fb66a355eb0f22096cf26864324f8e63c7d78 ]
>
> If an irq is pending when devm_request_irq() is called, the irq
> handler will cause a NULL pointer access because initialisation
> is not done yet.
>
> Fixes: 9d7ee0e28da59 ("tty: serial: lpuart: avoid report NULL interrupt")
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Indan Zupancic <Indan.Zupancic@mep-info.com>
> Link: https://lore.kernel.org/r/20220505114750.45423-1-Indan.Zupancic@mep-info.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> [5.10 did not have lpuart_global_reset or anything after
> uart_add_one_port(), so add the remove call in cleanup manually]
> Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
> ---
> This was originally intended as a prerequirement to backport the patch
> submitted in [1] for 5.10, but even with that part of the patch gone it
> makes sense as a fix on its own.
>
> [1] https://lkml.kernel.org/r/20221222114414.1886632-1-linux@rasmusvillemoes.dk
>
> drivers/tty/serial/fsl_lpuart.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
Both now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-01-12 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 4:23 [PATCH 5.10 1/2] fsl_lpuart: Don't enable interrupts too early Dominique Martinet
2022-12-23 4:23 ` [PATCH 5.10 2/2] serial: fixup backport of "serial: Deassert Transmit Enable on probe in driver-specific way" Dominique Martinet
2023-01-12 12:47 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8ABUYClE1ychdVp@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Indan.Zupancic@mep-info.com \
--cc=dominique.martinet@atmark-techno.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukas@wunner.de \
--cc=mizo@atmark-techno.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.