From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E59AAC54EBC for ; Thu, 12 Jan 2023 12:49:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbjALMtU (ORCPT ); Thu, 12 Jan 2023 07:49:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230375AbjALMtO (ORCPT ); Thu, 12 Jan 2023 07:49:14 -0500 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EBF74C70D for ; Thu, 12 Jan 2023 04:49:13 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 43B0A5C00F5; Thu, 12 Jan 2023 07:49:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 12 Jan 2023 07:49:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1673527750; x=1673614150; bh=UOt//9rBmC 9zXmXXsruIPeqvipqSRenmwAYz0YoEh7A=; b=fqC5CGU/Gi3c7FHTyGUwsvTazS QWhKGrzSAWw5vtsLa8dyowRo+SKQR45r2NmEEFlgiZicoQr+NnbdtFteZyA6dQ3i VhxFxqmOuGhi0cBYvexit1x1UnMdmWri3SRUcRroXo/3QZ8j8kIF2nqBr5yYEXLX c6AHGxuJo0UBrB7ExzMM9jxddMKXbLdK+GspVedOWBrRQTqRF8AsDuoL58t3phuu WtW3BGnFkBeZtq1wMS/jcHs165cdhZnASfeC7AX1j53QN8WfQbG+qdpHqkGJxHA+ vw2A4jXwPSyfooRp2nSjjuqkl1pKqhoTKbj3WGvoqKyApezN8uFhxXfb8huQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673527750; x=1673614150; bh=UOt//9rBmC9zXmXXsruIPeqvipqS RenmwAYz0YoEh7A=; b=cHdnCclOBjaXMMtfLXv9/NViDyjxU+ePB1myTTF+Nvcb XXNc+QeFNtadt4K7nmt9fQ8pAtsXJlxjEKTHcHVDdMUxb1ZEqqIzYN8L1+wN67V0 gWpoYm+HanIvii8wP5EkEqAM8r4ABXBIsoCKtLcrypf85Y70eonJyGAyEVonC3PD lqmVcP/+Dz3CT00Wk/77PyGFD1ejjmn/i9xJl1lSdVpxALp0pR1KhwlgbCX6Gys3 z/ufIM0J2wn9DlN4j1uXNkrMR5bwwyYpK3DU7gmU8OJSIKX+WC6WXzOtYAH3T2Ky 2cVJkDHol3GPVH89We3sVi/MMNZJHNEyx0QxjiKMXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleeigdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeehgedvve dvleejuefgtdduudfhkeeltdeihfevjeekjeeuhfdtueefhffgheekteenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh drtghomh X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Jan 2023 07:49:09 -0500 (EST) Date: Thu, 12 Jan 2023 13:49:07 +0100 From: Greg KH To: Tyler Hicks Cc: stable@vger.kernel.org, Shuah Khan , Muhammad Usama Anjum Subject: Re: [PATCH 5.4 0/2] Fix kselftest builds when specifying an output dir Message-ID: References: <20230106220844.763870-1-code@tyhicks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230106220844.763870-1-code@tyhicks.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jan 06, 2023 at 04:08:42PM -0600, Tyler Hicks wrote: > From: "Tyler Hicks" > > When attempting to build kselftests with a separate output directory, a > number of the tests fail to build. > > For example, > > $ rm -rf build && \ > make INSTALL_HDR_PATH=build/usr headers_install > /dev/null && \ > make O=build FORCE_TARGETS=1 TARGETS=breakpoints -C tools/testing/selftests > /dev/null > /usr/bin/ld: cannot open output file > build/kselftest/breakpoints/step_after_suspend_test: No such file or directory > collect2: error: ld returned 1 exit status > make[1]: *** [../lib.mk:146: build/kselftest/breakpoints/step_after_suspend_test] Error 1 > make: *** [Makefile:163: all] Error 2 > > This has already been addressed upstream with v5.18 commit 5ad51ab618de > ("selftests: set the BUILD variable to absolute path"). It does not > cleanly cherry pick to the linux-5.4.y branch without v5.7 commit > 29e911ef7b70 ("selftests: Fix kselftest O=objdir build from cluttering > top level objdir"). Commit 5ad51ab618de was written in a way that > assumes that the kselftests aren't build in the top level objdir so it > makes sense to bring the pre-req commit back but it does represent a > slight change in behavior since the kselftests will now be built in a > subdir of the specified objdir (O=). > > Tyler > > Muhammad Usama Anjum (1): > selftests: set the BUILD variable to absolute path > > Shuah Khan (1): > selftests: Fix kselftest O=objdir build from cluttering top level > objdir > > tools/testing/selftests/Makefile | 28 ++++++++++++++++++---------- > 1 file changed, 18 insertions(+), 10 deletions(-) > > -- > 2.34.1 > Now queued up, thanks. greg k-h