From: Tycho Andersen <tycho@tycho.pizza>
To: Andrei Vagin <avagin@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Christian Brauner <brauner@kernel.org>,
Andrei Vagin <avagin@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Juri Lelli <juri.lelli@redhat.com>,
Peter Oskolkov <posk@google.com>, Will Drewry <wad@chromium.org>
Subject: Re: [PATCH 1/5] seccomp: don't use semaphore and wait_queue together
Date: Thu, 12 Jan 2023 07:58:19 -0700 [thread overview]
Message-ID: <Y8AgC99AUeMjFWKt@tycho.pizza> (raw)
In-Reply-To: <20230110213010.2683185-2-avagin@google.com>
On Tue, Jan 10, 2023 at 01:30:06PM -0800, Andrei Vagin wrote:
> From: Andrei Vagin <avagin@gmail.com>
>
> The main reason is to use new wake_up helpers that will be added in the
> following patches. But here are a few other reasons:
>
> * if we use two different ways, we always need to call them both. This
> patch fixes seccomp_notify_recv where we forgot to call wake_up_poll
> in the error path.
[snip]
> @@ -1515,7 +1546,8 @@ static long seccomp_notify_recv(struct seccomp_filter *filter,
> if (should_sleep_killable(filter, knotif))
> complete(&knotif->ready);
> knotif->state = SECCOMP_NOTIFY_INIT;
> - up(&filter->notif->request);
> + atomic_add(1, &filter->notif->requests);
> + wake_up_poll(&filter->wqh, EPOLLIN | EPOLLRDNORM);
> }
> mutex_unlock(&filter->notify_lock);
> }
I wonder if this shouldn't be a separate patch that you can send now
independent of this series?
Tycho
next prev parent reply other threads:[~2023-01-12 15:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 21:30 [PATCH 0/5 v3 RESEND] seccomp: add the synchronous mode for seccomp_unotify Andrei Vagin
2023-01-10 21:30 ` [PATCH 1/5] seccomp: don't use semaphore and wait_queue together Andrei Vagin
2023-01-12 14:58 ` Tycho Andersen [this message]
2023-01-13 21:51 ` Andrei Vagin
2023-01-16 9:48 ` Peter Zijlstra
2023-01-10 21:30 ` [PATCH 2/5] sched: add WF_CURRENT_CPU and externise ttwu Andrei Vagin
2023-01-12 7:35 ` Chen Yu
2023-01-13 21:39 ` Andrei Vagin
2023-01-14 15:59 ` Chen Yu
2023-01-18 6:10 ` Andrei Vagin
2023-01-10 21:30 ` [PATCH 3/5] sched: add a few helpers to wake up tasks on the current cpu Andrei Vagin
2023-01-16 9:59 ` Peter Zijlstra
2023-01-19 6:45 ` Andrei Vagin
2023-01-19 10:09 ` Peter Zijlstra
2023-01-10 21:30 ` [PATCH 4/5] seccomp: add the synchronous mode for seccomp_unotify Andrei Vagin
2023-01-12 15:00 ` Tycho Andersen
2023-01-14 1:16 ` Andrei Vagin
2023-01-10 21:30 ` [PATCH 5/5] selftest/seccomp: add a new test for the sync mode of seccomp_user_notify Andrei Vagin
-- strict thread matches above, loose matches on Subject: below --
2022-11-11 7:31 [PATCH 0/5 v3] seccomp: add the synchronous mode for seccomp_unotify Andrei Vagin
2022-11-11 7:31 ` [PATCH 1/5] seccomp: don't use semaphore and wait_queue together Andrei Vagin
2022-10-20 1:10 [PATCH 0/5 v2] seccomp: add the synchronous mode for seccomp_unotify Andrei Vagin
2022-10-20 1:10 ` [PATCH 1/5] seccomp: don't use semaphore and wait_queue together Andrei Vagin
2022-10-20 5:10 ` Kees Cook
2022-10-21 4:30 ` Andrei Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8AgC99AUeMjFWKt@tycho.pizza \
--to=tycho@tycho.pizza \
--cc=avagin@gmail.com \
--cc=avagin@google.com \
--cc=brauner@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=posk@google.com \
--cc=vincent.guittot@linaro.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.