From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Robert Elliott <elliott@hpe.com>,
davem@davemloft.net, Jason@zx2c4.com, ardb@kernel.org,
ap420073@gmail.com, David.Laight@aculab.com,
tim.c.chen@linux.intel.com, peter@n8pjl.ca, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
linux-crypto@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/13] crypto: x86/sha - yield FPU context during long loops
Date: Thu, 12 Jan 2023 10:46:42 -0800 [thread overview]
Message-ID: <Y8BVkjwPc6DLm7HT@sol.localdomain> (raw)
In-Reply-To: <Y7+/Yy7+mLEyqeiK@gondor.apana.org.au>
On Thu, Jan 12, 2023 at 04:05:55PM +0800, Herbert Xu wrote:
> On Mon, Dec 19, 2022 at 04:02:13PM -0600, Robert Elliott wrote:
> >
> > @@ -41,9 +41,7 @@ static int sha1_update(struct shash_desc *desc, const u8 *data,
>
> I just realised a show-stopper with this patch-set. We don't
> have a desc->flags field that tells us whether we can sleep or
> not.
>
> I'm currently doing a patch-set for per-request keys and I will
> add a flags field to shash_desc so we could use that for your
> patch-set too.
>
Right, this used to exist, but it didn't actually do anything, and it had
suffered heavily from bitrot. For example, some callers specified MAY_SLEEP
when actually they couldn't sleep. IIRC, some callers also didn't even bother
initializing the flags, so they were passing uninitialized memory. So I removed
it in commit 877b5691f27a ("crypto: shash - remove shash_desc::flags").
Has there been any consideration of just adding the crypto_shash_update_large()
helper function that I had mentioned in the commit message of 877b5691f27a?
- Eric
next prev parent reply other threads:[~2023-01-12 19:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 22:02 [PATCH 00/13] crypto: x86 - yield FPU context during long loops Robert Elliott
2022-12-19 22:02 ` [PATCH 01/13] x86: protect simd.h header file Robert Elliott
2022-12-19 22:02 ` [PATCH 02/13] x86: add yield FPU context utility function Robert Elliott
2022-12-19 22:02 ` [PATCH 03/13] crypto: x86/sha - yield FPU context during long loops Robert Elliott
2022-12-20 3:57 ` Herbert Xu
2022-12-30 9:08 ` Herbert Xu
2023-01-12 8:05 ` Herbert Xu
2023-01-12 18:46 ` Eric Biggers [this message]
2023-01-13 2:36 ` Herbert Xu
2023-01-13 2:37 ` Herbert Xu
2023-01-13 19:35 ` Elliott, Robert (Servers)
2023-01-16 3:33 ` Herbert Xu
2022-12-19 22:02 ` [PATCH 04/13] crypto: x86/crc " Robert Elliott
2022-12-19 22:02 ` [PATCH 05/13] crypto: x86/sm3 " Robert Elliott
2022-12-19 22:02 ` [PATCH 06/13] crypto: x86/ghash - use u8 rather than char Robert Elliott
2022-12-19 22:02 ` [PATCH 07/13] crypto: x86/ghash - restructure FPU context saving Robert Elliott
2022-12-30 9:04 ` Herbert Xu
2022-12-19 22:02 ` [PATCH 08/13] crypto: x86/ghash - yield FPU context during long loops Robert Elliott
2022-12-19 22:02 ` [PATCH 09/13] crypto: x86/poly - yield FPU context only when needed Robert Elliott
2022-12-19 22:02 ` [PATCH 10/13] crypto: x86/aegis - yield FPU context during long loops Robert Elliott
2022-12-19 22:02 ` [PATCH 11/13] crypto: x86/blake - yield FPU context only when needed Robert Elliott
2022-12-19 22:02 ` [PATCH 12/13] crypto: x86/chacha " Robert Elliott
2022-12-19 22:02 ` [PATCH 13/13] crypto: x86/aria " Robert Elliott
2022-12-20 20:02 ` [PATCH 00/13] crypto: x86 - yield FPU context during long loops Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8BVkjwPc6DLm7HT@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=David.Laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=ap420073@gmail.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=elliott@hpe.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peter@n8pjl.ca \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.