From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pGFTd-00046k-U8 for mharc-grub-devel@gnu.org; Fri, 13 Jan 2023 03:31:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGFTb-00044C-Ml for grub-devel@gnu.org; Fri, 13 Jan 2023 03:31:51 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGFTZ-0002Oc-Jk for grub-devel@gnu.org; Fri, 13 Jan 2023 03:31:51 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 048305C0083; Fri, 13 Jan 2023 03:31:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 13 Jan 2023 03:31:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1673598708; x=1673685108; bh=6RNqQSe+9X VzLrRArZab35wWzN0GHVqd1UoORdpMhO4=; b=qmtYXeyvJWiT61O3vaC0Zhv4Uf zplYAft5D5od8nUooSAuwK4ybHEURDtJfAq4rLcUl0hyI5QNBTlpN2x/Ey+j2q6A 2s4GJSkGJxmUGh7x3B7QBaX/Kw5wByyyYuFuE4SZWImSJD9f129aync/u5oZo76+ Ui/P1Zdm3RejlbE06LEbVEupXi6AO2QeIUR2Z8GxYS5QuMzahPsrCI6ASxBdt+IJ 6pkwz7wrHMIeLHePC+fDk4dYnfGErnnr2y3qa4tTNQV2/3tMz8L80tq50XJzq63w H0MZymSUafI0K4fuNGZlfj8BHnneo6ncC2gMYmwABg3GgKCF99kDcWgdbLNw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673598708; x=1673685108; bh=6RNqQSe+9XVzLrRArZab35wWzN0G HVqd1UoORdpMhO4=; b=UCS3AxvkslpF6tG0yeXR/2RY0f3Mh7jsA7Vc0YrJl0nB yQxr9Nx57Cj+BOsdNMb/qqlsPbTyNkOnjXYDjjUHWN8/6AV81vYsrzjT72pXfnYK P31ik/E3PuH005ZvlWeMyBHHa4nqutCuelACSx9GUyquBahNt0fL3b2mVQe3oxL6 DkXxXQZF0oDoraQsl1iPc9LY7OClK7B+JhoG3u/lFza+99DSw1Z89VNcPXp5JOek 79aa71cf4nLOHHShpXz7SoStYItRG0/SNzRIq2wzijCJmKuyFH1ORAlGFmMSfSi6 52TytpBrNfdrpNTN73Q39Ijpo/lEzi876Rn+RVIAmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleejgdduvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvg hrnhephfeiieeuvdffveeigeejjeffkeektdehleekvdekheeilefgkeefvdegtdekfeei necuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Jan 2023 03:31:46 -0500 (EST) Received: by pks.im (OpenSMTPD) with ESMTPSA id 6aaf8ae2 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 13 Jan 2023 08:31:35 +0000 (UTC) Date: Fri, 13 Jan 2023 09:31:43 +0100 From: Patrick Steinhardt To: Glenn Washburn Cc: grub-devel@gnu.org, Daniel Kiper , Pierre-Louis Bonicoli , Josselin Poiret , Fabian Vogt Subject: Re: [PATCH 0/4] LUKS1/2 testing in fs-tester and LUKS2 support in grub-probe Message-ID: References: <20230112230510.1319896-1-development@efficientek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8AoiRuKxoJvTtdY0" Content-Disposition: inline In-Reply-To: <20230112230510.1319896-1-development@efficientek.com> Received-SPF: pass client-ip=66.111.4.25; envelope-from=ps@pks.im; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2023 08:31:52 -0000 --8AoiRuKxoJvTtdY0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 12, 2023 at 05:05:06PM -0600, Glenn Washburn wrote: > This series adds the testing of LUKS 1 and 2 encrypted container to the > user-space fs tester. While this does replicate some of the testing done > by grub_cmd_cryptomount, and is less flexible, it is run natively (that is > without need for virtualization). It also tests the added LUKS2 support in > grub-probe, unlike grub_cmd_cryptomount which does not test any user-space > grub components. >=20 > All of these patches have previously been sent to the list. Only patch 4 = has > been slightly modified to fix some issues. Since utility of any one is gr= eatly > enhanced, and in the case of patch 4 required, by the others, I think it = makes > sense to evaluate them together. Yeah, makes sense to have them all in one place. > Fabian has noted a memory leak with error handling when using LUKS2 with a > null_cipher[1]. Since this isn't something that I expect to happen in the= wild > (why would you use an unencrypted LUKS container?) and even if it does oc= cur > grub-probe is exiting, so the leak would be very short lived, I don't thi= nk > this is something that we need to worry about. It wouldn't be that hard t= o fix > though, just annoying and add a little more complexity to the source. >=20 > The corresponding patches can be found in the order of this series here: > 1: [PATCH v3] disk/cryptodisk: When cheatmounting, use the sector info o= f the cheat device > https://lists.gnu.org/archive/html/grub-devel/2022-06/msg00106.html > 2: [PATCH v6 1/2] devmapper/getroot: Have devmapper recognize LUKS2 > https://lists.gnu.org/archive/html/grub-devel/2022-07/msg00036.html > 3: [PATCH v6 2/2] devmapper/getroot: Set up cheated LUKS2 cryptodisk mou= nt from DM parameters > https://lists.gnu.org/archive/html/grub-devel/2022-07/msg00038.html > 4: [PATCH v4] grub-fs-tester: Add luks1 and luks2 support > https://lists.gnu.org/archive/html/grub-devel/2022-06/msg00127.html For all patches: Reviewed-by: Patrick Steinhardt Thanks a bunch! Patrick --8AoiRuKxoJvTtdY0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAmPBFu8ACgkQVbJhu7ck PpTJUQ//V7Mr1NRUBN7lRisYpy/zartEuw5iHUfzerERopHIiWWZj9JVKfXqu9d6 to90EZR0LgQ4zpVGctczYbN7vgUKIxYR5tY8OkRK8sg/59Mk5TkbUS+fXVXFw7aI 0hvQspnCLgXbdI8QmVfh2miI1YLUgPzpgczQEH8MC5qkayZYaYyvG4BrvfdIDp24 KBYMmu+JHn8ihWDUFpZMx3vYYmzijBoTeSvOiI7lTnVdupjvt63u600I9LDdD//j e/zCWHpXglctK8vaMjS2lvHAgnvjmIuxN0iC0F/3owDeq/wtMne56JaAK0vwlOvC U4ypLN2MbR8x7oK3JzAIO7mpyURkntRI5ZL3kyV1DTu3IkNkemnQkus9do3uq6L0 rrQYFay+StJjnVOvQxxAmtviiUaVJvjK1RV7fkYm5OpwWC4Z1nmSUKNRvkljMjuh k71+E6uMfZjAbpimPdmWmoWqeK8AAvyP9Q74BK3GKmzNTskP12TtRAkkMFqLgLre TJEWQlexRDjTxRKFBFCGcITrP6bgyourOwtylyznvn3xJy605ndSPowaruu8MFH5 CJpQs922uwEUKXSeAwZhpxRh+4Ar9CRDAwoZyUapLY2n1uwZW8cgjr9TQ2gzzy7D 6gqsSDhZoh/PIHgszQRLZ/Nk5aIBqBV/WFgINadN0ka8himw2jc= =0Xcv -----END PGP SIGNATURE----- --8AoiRuKxoJvTtdY0--