From: Lee Jones <lee@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Russell King <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v1 17/20] clk: imx6ul: add ethernet refclock mux support
Date: Fri, 13 Jan 2023 14:48:48 +0000 [thread overview]
Message-ID: <Y8FvULElX2D8FGXA@google.com> (raw)
In-Reply-To: <20230113142718.3038265-18-o.rempel@pengutronix.de>
On Fri, 13 Jan 2023, Oleksij Rempel wrote:
> Add ethernet refclock mux support and set it to internal clock by
> default. This configuration will not affect existing boards.
>
> clock tree before this patch:
> fec1 <- enet1_ref_125m (gate) <- enet1_ref (divider) <-,
> |- pll6_enet
> fec2 <- enet2_ref_125m (gate) <- enet2_ref (divider) <-´
>
> after this patch:
> fec1 <- enet1_ref_sel(mux) <- enet1_ref_125m (gate) <- ...
> `--<> enet1_ref_pad |- pll6_enet
> fec2 <- enet2_ref_sel(mux) <- enet2_ref_125m (gate) <- ...
> `--<> enet2_ref_pad
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/clk/imx/clk-imx6ul.c | 26 +++++++++++++++++++++
> include/dt-bindings/clock/imx6ul-clock.h | 6 ++++-
> include/linux/mfd/syscon/imx6q-iomuxc-gpr.h | 6 +++--
> 3 files changed, 35 insertions(+), 3 deletions(-)
[...]
> --- a/include/linux/mfd/syscon/imx6q-iomuxc-gpr.h
> +++ b/include/linux/mfd/syscon/imx6q-iomuxc-gpr.h
> @@ -451,8 +451,10 @@
> #define IMX6SX_GPR12_PCIE_RX_EQ_2 (0x2 << 0)
>
> /* For imx6ul iomux gpr register field define */
> -#define IMX6UL_GPR1_ENET1_CLK_DIR (0x1 << 17)
> -#define IMX6UL_GPR1_ENET2_CLK_DIR (0x1 << 18)
> +#define IMX6UL_GPR1_ENET2_TX_CLK_DIR BIT(18)
> +#define IMX6UL_GPR1_ENET1_TX_CLK_DIR BIT(17)
> +#define IMX6UL_GPR1_ENET2_CLK_SEL BIT(14)
> +#define IMX6UL_GPR1_ENET1_CLK_SEL BIT(13)
> #define IMX6UL_GPR1_ENET1_CLK_OUTPUT (0x1 << 17)
> #define IMX6UL_GPR1_ENET2_CLK_OUTPUT (0x1 << 18)
> #define IMX6UL_GPR1_ENET_CLK_DIR (0x3 << 17)
Why not convert more of them them?
Either way, could you please refrain from sending me subsequent
patch-sets please.
Acked-by: Lee Jones <lee@kernel.org>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-01-13 14:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 14:26 [PATCH v1 00/20] ARM: imx: make Ethernet refclock configurable Oleksij Rempel
2023-01-13 14:26 ` [PATCH v1 01/20] clk: imx: add clk-gpr-mux driver Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 02/20] clk: imx6q: add ethernet refclock mux support Oleksij Rempel
2023-01-13 22:56 ` kernel test robot
2023-01-15 6:25 ` kernel test robot
2023-01-13 14:27 ` [PATCH v1 03/20] ARM: imx6q: skip ethernet refclock reconfiguration if enet_clk_ref is present Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 04/20] ARM: imx6q: use of_clk_get_by_name() instead of_clk_get() to get ptp clock Oleksij Rempel
2023-01-14 0:15 ` Stephen Boyd
2023-01-13 14:27 ` [PATCH v1 05/20] ARM: dts: imx6qdl: use enet_clk_ref instead of enet_out for the FEC node Oleksij Rempel
2023-01-16 1:01 ` Peng Fan
2023-01-16 5:26 ` Oleksij Rempel
2023-01-17 1:45 ` Peng Fan
2023-01-13 14:27 ` [PATCH v1 06/20] ARM: dts: imx6dl-lanmcu: configure ethernet reference clock parent Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 07/20] ARM: dts: imx6dl-alti6p: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 08/20] ARM: dts: imx6dl-plybas: " Oleksij Rempel
2023-01-14 11:39 ` Fabio Estevam
2023-01-13 14:27 ` [PATCH v1 09/20] ARM: dts: imx6dl-plym2m: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 10/20] ARM: dts: imx6dl-prtmvt: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 11/20] ARM: dts: imx6dl-victgo: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 12/20] ARM: dts: imx6q-prtwd2: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 13/20] ARM: dts: imx6qdl-skov-cpu: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 14/20] ARM: dts: imx6dl-eckelmann-ci4x10: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 15/20] clk: imx: add imx_obtain_fixed_of_clock() Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 16/20] clk: imx6ul: fix enet1 gate configuration Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 17/20] clk: imx6ul: add ethernet refclock mux support Oleksij Rempel
2023-01-13 14:48 ` Lee Jones [this message]
2023-01-14 1:07 ` kernel test robot
2023-01-15 8:46 ` kernel test robot
2023-01-13 14:27 ` [PATCH v1 18/20] ARM: dts: imx6ul: set enet_clk_ref to CLK_ENETx_REF_SEL Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 19/20] ARM: mach-imx: imx6ul: remove not optional ethernet refclock overwrite Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 20/20] ARM: dts: imx6ul-prti6g: configure ethernet reference clock parent Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8FvULElX2D8FGXA@google.com \
--to=lee@kernel.org \
--cc=abelvesa@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.