From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34560C54EBE for ; Mon, 16 Jan 2023 12:30:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230250AbjAPMaw (ORCPT ); Mon, 16 Jan 2023 07:30:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbjAPMaq (ORCPT ); Mon, 16 Jan 2023 07:30:46 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3E65A1E1DF for ; Mon, 16 Jan 2023 04:30:45 -0800 (PST) Date: Mon, 16 Jan 2023 13:30:42 +0100 From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH v2] Implement 'reset rule' and 'reset rules' commands Message-ID: References: <20230112162342.2986-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230112162342.2986-1-phil@nwl.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Jan 12, 2023 at 05:23:42PM +0100, Phil Sutter wrote: > Reset rule counters and quotas in kernel, i.e. without having to reload > them. Requires respective kernel patch to support NFT_MSG_GETRULE_RESET > message type. Only thing to mention: This adds a new rule_cache_dump() call, this was consolidated on top of the cache infrastructure, to have a single spot in the code to fetch kernel objects via netlink. This triggers to netlink dumps, one to populate the cache and another for the reset, right? Apart from that, patch LGTM.