All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Philippe De Muyter <Philippe.DeMuyter@macq.eu>
Cc: linux-iio@vger.kernel.org, Philippe De Muyter <phdm@macqel.be>
Subject: Re: [PATCH v2 1/2] iio: imu: st_lsm6dsx: fix naming of 'struct iio_info' in st_lsm6dsx_shub.c.
Date: Mon, 16 Jan 2023 14:20:05 +0100	[thread overview]
Message-ID: <Y8VPBcpihYfEtGVG@lore-desk> (raw)
In-Reply-To: <1673874434-30750-2-git-send-email-Philippe.DeMuyter@macq.eu>

[-- Attachment #1: Type: text/plain, Size: 2280 bytes --]

> From: Philippe De Muyter <phdm@macqel.be>
> 
> We need the name 'st_lsm6dsx_ext_info' for the actual 'iio_chan_spec_ext_info'.
> Rename the 'st_lsm6dsx_ext_info' in st_lsm6dsx_shub.c to 'st_lsm6dsx_shub_info'.
> For consistency, replace also 'ext' by 'shub' in 'st_lsm6dsx_ext_attributes'
> and 'st_lsm6dsx_ext_attribute_group'.

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> 
> Signed-off-by: Philippe De Muyter <phdm@macqel.be>
> ---
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> index f2b64b4956a3..c1b444520d2a 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> @@ -704,18 +704,18 @@ static ssize_t st_lsm6dsx_shub_scale_avail(struct device *dev,
>  static IIO_DEV_ATTR_SAMP_FREQ_AVAIL(st_lsm6dsx_shub_sampling_freq_avail);
>  static IIO_DEVICE_ATTR(in_scale_available, 0444,
>  		       st_lsm6dsx_shub_scale_avail, NULL, 0);
> -static struct attribute *st_lsm6dsx_ext_attributes[] = {
> +static struct attribute *st_lsm6dsx_shub_attributes[] = {
>  	&iio_dev_attr_sampling_frequency_available.dev_attr.attr,
>  	&iio_dev_attr_in_scale_available.dev_attr.attr,
>  	NULL,
>  };
>  
> -static const struct attribute_group st_lsm6dsx_ext_attribute_group = {
> -	.attrs = st_lsm6dsx_ext_attributes,
> +static const struct attribute_group st_lsm6dsx_shub_attribute_group = {
> +	.attrs = st_lsm6dsx_shub_attributes,
>  };
>  
> -static const struct iio_info st_lsm6dsx_ext_info = {
> -	.attrs = &st_lsm6dsx_ext_attribute_group,
> +static const struct iio_info st_lsm6dsx_shub_info = {
> +	.attrs = &st_lsm6dsx_shub_attribute_group,
>  	.read_raw = st_lsm6dsx_shub_read_raw,
>  	.write_raw = st_lsm6dsx_shub_write_raw,
>  	.hwfifo_set_watermark = st_lsm6dsx_set_watermark,
> @@ -737,7 +737,7 @@ st_lsm6dsx_shub_alloc_iiodev(struct st_lsm6dsx_hw *hw,
>  		return NULL;
>  
>  	iio_dev->modes = INDIO_DIRECT_MODE;
> -	iio_dev->info = &st_lsm6dsx_ext_info;
> +	iio_dev->info = &st_lsm6dsx_shub_info;
>  
>  	sensor = iio_priv(iio_dev);
>  	sensor->id = id;
> -- 
> 2.31.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-01-16 13:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16 13:07 [PATCH v2 0/2] iio: imu: st_lsm6dsx: add 'mount_matrix' sysfs entry to gyro channel Philippe De Muyter
2023-01-16 13:07 ` [PATCH v2 1/2] iio: imu: st_lsm6dsx: fix naming of 'struct iio_info' in st_lsm6dsx_shub.c Philippe De Muyter
2023-01-16 13:20   ` Lorenzo Bianconi [this message]
2023-01-16 13:07 ` [PATCH v2 2/2] iio: imu: st_lsm6dsx: add 'mount_matrix' sysfs entry to gyro channel Philippe De Muyter
2023-01-16 13:19   ` Lorenzo Bianconi
2023-01-21 18:17 ` [PATCH v2 0/2] " Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8VPBcpihYfEtGVG@lore-desk \
    --to=lorenzo@kernel.org \
    --cc=Philippe.DeMuyter@macq.eu \
    --cc=linux-iio@vger.kernel.org \
    --cc=phdm@macqel.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.