From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Niklas Cassel <niklas.cassel@wdc.com>,
Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2 01/18] ata: libata: allow ata_scsi_set_sense() to not set CHECK_CONDITION
Date: Mon, 16 Jan 2023 23:23:46 -0800 [thread overview]
Message-ID: <Y8ZNApPCqcueEd5U@infradead.org> (raw)
In-Reply-To: <b1c381c4-5bb5-f697-ef35-686edb1404dd@opensource.wdc.com>
On Tue, Jan 17, 2023 at 04:15:01PM +0900, Damien Le Moal wrote:
> Trying to get to a pretty solution keeping a single line for setting sense
> + status. But sure, splitting out the status setting works too.
I suggested just adding a wrapper above. And while I tried to white
board code it here in the mail I think we can do even better than
that, and just drop this change and just open code the call to
scsi_build_sense_buffer for the CDL use case.
While we're at it: That !cmd check in ata_scsi_set_sense looks
really odd, can someone clean that up and just remove the calls
where there is no command?
next prev parent reply other threads:[~2023-01-17 7:23 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 14:03 [PATCH v2 00/18] Add Command Duration Limits support Niklas Cassel
2023-01-12 14:03 ` [PATCH v2 01/18] ata: libata: allow ata_scsi_set_sense() to not set CHECK_CONDITION Niklas Cassel
2023-01-13 7:49 ` Hannes Reinecke
2023-01-17 6:06 ` Christoph Hellwig
2023-01-17 7:10 ` Damien Le Moal
2023-01-17 7:12 ` Christoph Hellwig
2023-01-17 7:15 ` Damien Le Moal
2023-01-17 7:23 ` Christoph Hellwig [this message]
2023-01-12 14:03 ` [PATCH v2 02/18] ata: libata: allow ata_eh_request_sense() " Niklas Cassel
2023-01-13 7:51 ` Hannes Reinecke
2023-01-17 6:08 ` Christoph Hellwig
2023-01-12 14:03 ` [PATCH v2 03/18] scsi: core: allow libata to complete successful commands via EH Niklas Cassel
2023-01-13 7:57 ` Hannes Reinecke
2023-01-16 12:43 ` Niklas Cassel
2023-01-17 11:44 ` Hannes Reinecke
2023-01-17 7:24 ` Christoph Hellwig
2023-01-12 14:03 ` [PATCH v2 04/18] scsi: rename and move get_scsi_ml_byte() Niklas Cassel
2023-01-13 7:58 ` Hannes Reinecke
2023-01-17 6:12 ` Christoph Hellwig
2023-01-12 14:03 ` [PATCH v2 05/18] scsi: support retrieving sub-pages of mode pages Niklas Cassel
2023-01-13 7:59 ` Hannes Reinecke
2023-01-17 6:13 ` Christoph Hellwig
2023-01-12 14:03 ` [PATCH v2 06/18] scsi: support service action in scsi_report_opcode() Niklas Cassel
2023-01-13 11:48 ` Hannes Reinecke
2023-01-17 6:13 ` Christoph Hellwig
2023-01-12 14:03 ` [PATCH v2 07/18] block: introduce duration-limits priority class Niklas Cassel
2023-01-13 11:55 ` Hannes Reinecke
2023-01-13 12:44 ` Damien Le Moal
2023-01-17 7:25 ` Christoph Hellwig
2023-01-17 8:06 ` Damien Le Moal
2023-01-17 8:13 ` Christoph Hellwig
2023-01-17 8:14 ` Damien Le Moal
2023-01-12 14:03 ` [PATCH v2 08/18] block: introduce BLK_STS_DURATION_LIMIT Niklas Cassel
2023-01-13 11:56 ` Hannes Reinecke
2023-01-17 7:26 ` Christoph Hellwig
2023-01-12 14:03 ` [PATCH v2 09/18] ata: libata: detect support for command duration limits Niklas Cassel
2023-01-13 11:59 ` Hannes Reinecke
2023-01-12 14:03 ` [PATCH v2 10/18] ata: libata-scsi: handle CDL bits in ata_scsiop_maint_in() Niklas Cassel
2023-01-12 14:04 ` [PATCH v2 11/18] ata: libata-scsi: add support for CDL pages mode sense Niklas Cassel
2023-01-12 14:04 ` [PATCH v2 12/18] ata: libata: add ATA feature control sub-page translation Niklas Cassel
2023-01-12 14:04 ` [PATCH v2 13/18] ata: libata: set read/write commands CDL index Niklas Cassel
2023-01-12 14:04 ` [PATCH v2 14/18] scsi: sd: detect support for command duration limits Niklas Cassel
2023-01-17 7:37 ` Christoph Hellwig
2023-01-17 8:00 ` Damien Le Moal
2023-01-12 14:04 ` [PATCH v2 15/18] scsi: sd: set read/write commands CDL index Niklas Cassel
2023-01-12 14:04 ` [PATCH v2 16/18] scsi: sd: handle read/write CDL timeout failures Niklas Cassel
2023-01-12 14:04 ` [PATCH v2 17/18] ata: libata: handle completion of CDL commands using policy 0xD Niklas Cassel
2023-01-12 14:04 ` [PATCH v2 18/18] Documentation: sysfs-block-device: document command duration limits Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8ZNApPCqcueEd5U@infradead.org \
--to=hch@infradead.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=niklas.cassel@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.