From: Simon Horman <simon.horman@corigine.com>
To: Vlad Buslov <vladbu@nvidia.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
pablo@netfilter.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, ozsh@nvidia.com,
marcelo.leitner@gmail.com,
Baowen Zheng <baowen.zheng@corigine.com>,
oss-drivers@corigine.com
Subject: Re: [PATCH net-next v1 1/7] net: flow_offload: provision conntrack info in ct_metadata
Date: Tue, 17 Jan 2023 08:55:23 +0100 [thread overview]
Message-ID: <Y8ZUa+uiXWAklNem@corigine.com> (raw)
In-Reply-To: <875yda4dfc.fsf@nvidia.com>
On Fri, Jan 13, 2023 at 06:15:55PM +0200, Vlad Buslov wrote:
> On Fri 13 Jan 2023 at 10:12, Simon Horman <simon.horman@corigine.com> wrote:
> > + Baowen Zheng, oss-drivers@corigine.com
...
> > Hi Vlad,
> >
> > Some feedback from Baowen Zheng, who asked me to pass it on here:
> >
> > It is confusing that after FLOW_ACTION_CT_METADATA check, this functoin
> > will return false, that is -EOPNOTSUPP.
> >
> > Since this function is only used to check nft table, It seems better to
> > change its name to nfp_fl_ct_offload_nft_supported(). This would make things
> > clearer and may avoid it being used in the wrong way.
>
> Thanks for the suggestions! I will change the naming and send V2.
Thanks Vlad, much appreciated.
next prev parent reply other threads:[~2023-01-17 7:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 13:30 [PATCH net-next v1 0/7] Allow offloading of UDP NEW connections via act_ct Vlad Buslov
2023-01-10 13:30 ` [PATCH net-next v1 1/7] net: flow_offload: provision conntrack info in ct_metadata Vlad Buslov
2023-01-10 15:14 ` kernel test robot
2023-01-10 20:27 ` kernel test robot
2023-01-10 20:37 ` kernel test robot
2023-01-10 20:47 ` kernel test robot
2023-01-13 9:12 ` Simon Horman
2023-01-13 16:15 ` Vlad Buslov
2023-01-17 7:55 ` Simon Horman [this message]
2023-01-10 13:30 ` [PATCH net-next v1 2/7] netfilter: flowtable: fixup UDP timeout depending on ct state Vlad Buslov
2023-01-10 13:30 ` [PATCH net-next v1 3/7] netfilter: flowtable: allow unidirectional rules Vlad Buslov
2023-01-10 13:30 ` [PATCH net-next v1 4/7] netfilter: flowtable: allow updating offloaded rules asynchronously Vlad Buslov
2023-01-10 13:30 ` [PATCH net-next v1 5/7] net/sched: act_ct: set ctinfo in meta action depending on ct state Vlad Buslov
2023-01-10 13:30 ` [PATCH net-next v1 6/7] net/sched: act_ct: offload UDP NEW connections Vlad Buslov
2023-01-10 13:30 ` [PATCH net-next v1 7/7] netfilter: nf_conntrack: allow early drop of offloaded UDP conns Vlad Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8ZUa+uiXWAklNem@corigine.com \
--to=simon.horman@corigine.com \
--cc=baowen.zheng@corigine.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=ozsh@nvidia.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.