From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D6A3C3DA78 for ; Tue, 17 Jan 2023 15:27:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v5bZsLG35JIt9F5Ra4QxdHEASomjxKO+MzAS8VZjwag=; b=imk12oriI0WWzO z3swzI5GNwYeOsrBtQq4R2RvPxYuyU/jDiRZeSy5QSnnltPiiOSOIGK7rqesTvJj+wfBSgMnnE8Wy 3HYGfLkXObRjc+RVnVPl0okccYqS4U5eSyT4vHyQ+F+SrER9h3AuAEDtRv8Og4CIacthOlZQ2Pgn2 F+CQqKSLiJCFaWfidqD/Eu7YS/lZZpPCt22HToXpltH+OkOm/a4U8Rv7/UvdZyl9Cno7H22YYe8wc D63JEIzcx5Uxh47snFWBalK84UWdefwWKdcHjSy0uMVPBWZkYE7pK6ROZPn05bas8A72eW2Fq8zcg zET3qHFC2txcU4DOMV4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHnr7-00EpbJ-0L; Tue, 17 Jan 2023 15:26:33 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHnr3-00EpYg-IT for linux-arm-kernel@lists.infradead.org; Tue, 17 Jan 2023 15:26:31 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F3F610C; Tue, 17 Jan 2023 16:26:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673969181; bh=tSDcjAh6bFmwIhxqPp/jq7QIdOqP7tA6ejjlekmgFZo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BVlO2NPSanLnnpZ9sV70KYrrQe9hv2XFk89MRzJJ55jCEXhtEy0oWi7C3t5UzIqsr pq9GIkxGnIyLgvxDX1ajQ777N9AA2NfaRG1WJVmsPC/oEXti4UF4QHn96Ae6cKXVTL QEnC9WZFMQMXpfkUfgATNOUrxNC/JDtxvoTpnsY8= Date: Tue, 17 Jan 2023 17:26:22 +0200 From: Laurent Pinchart To: Yuji Ishikawa Cc: Hans Verkuil , Mauro Carvalho Chehab , Nobuhiro Iwamatsu , Rob Herring , Krzysztof Kozlowski , "Rafael J . Wysocki" , Mark Brown , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings Message-ID: References: <20230111022433.25950-1-yuji2.ishikawa@toshiba.co.jp> <20230111022433.25950-2-yuji2.ishikawa@toshiba.co.jp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230111022433.25950-2-yuji2.ishikawa@toshiba.co.jp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230117_072629_798485_6E4CECCB X-CRM114-Status: GOOD ( 26.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Yuji, Thank you for the patch. On Wed, Jan 11, 2023 at 11:24:28AM +0900, Yuji Ishikawa wrote: > Adds the Device Tree binding documentation that allows to describe > the Video Input Interface found in Toshiba Visconti SoCs. > > Signed-off-by: Yuji Ishikawa > Reviewed-by: Nobuhiro Iwamatsu > --- > Changelog v2: > - no change > > Changelog v3: > - no change > > Changelog v4: > - fix style problems at the v3 patch > - remove "index" member > - update example > > Changelog v5: > - no change > --- > .../bindings/media/toshiba,visconti-viif.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > > diff --git a/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml b/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > new file mode 100644 > index 00000000000..71442724d1a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/toshiba,visconti-viif.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba Visconti5 SoC Video Input Interface Device Tree Bindings > + > +maintainers: > + - Nobuhiro Iwamatsu > + > +description: > + Toshiba Visconti5 SoC Video Input Interface (VIIF) > + receives MIPI CSI2 video stream, > + processes the stream with embedded image signal processor (L1ISP, L2ISP), > + then stores pictures to main memory. > + > +properties: > + compatible: > + const: toshiba,visconti-viif > + > + reg: > + items: > + - description: registers for capture control > + - description: registers for CSI2 receiver control Nitpicking, s/registers/Registers/ in the two lines above as you capitalize the descriptions below. > + > + interrupts: > + items: > + - description: Sync Interrupt > + - description: Status (Error) Interrupt > + - description: CSI2 Receiver Interrupt > + - description: L1ISP Interrupt > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: Input port, single endpoint describing the CSI-2 transmitter. I would write description: CSI-2 input port, with a single endpoint connected to the CSI-2 transmitter. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: VIIF supports 2 or 4 data lines s/lines/lanes/ > + $ref: /schemas/types.yaml#/definitions/uint32-array You can drop this line, it's already handled by video-interfaces.yaml. > + minItems: 1 > + maxItems: 4 If only 2 or 4 data lanes are supported, shouldn't minItems be 2 ? > + items: > + minimum: 1 > + maximum: 4 Can the CSI-2 receiver reorder the data lanes ? If not, I think you can write items: - const: 1 - const: 2 - const: 3 - const: 4 > + > + clock-lanes: > + description: VIIF supports 1 clock line s/line/lane/ > + const: 0 I would also add clock-noncontinuous: true link-frequencies: true to indicate that the above two properties are used by this device. Also, mark the properties that are required: required: - data-lanes - clock-lanes I'm wondering, though, if clock-lanes shouldn't be simply omitted. If the hardware doesn't support any other option than using lane 0 for the clock lane (as in, no lane remapping), then you can drop the clock-lanes property completely. > + > +required: > + - compatible > + - reg > + - interrupts > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + viif@1c000000 { > + compatible = "toshiba,visconti-viif"; > + reg = <0 0x1c000000 0 0x6000>, > + <0 0x1c008000 0 0x400>; > + interrupts = , > + , > + , > + ; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + csi_in0: endpoint { > + remote-endpoint = <&imx219_out0>; > + bus-type = <4>; Does the hardware support any other bus type ? If not, you can drop the bus-type. If it does, bus-type should be added to the binding, with the value set to "const: 4". > + data-lanes = <1 2>; > + clock-lanes = <0>; > + clock-noncontinuous; > + link-frequencies = /bits/ 64 <456000000>; > + }; > + }; > + }; > + }; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA532C63797 for ; Tue, 17 Jan 2023 15:26:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232578AbjAQP0u (ORCPT ); Tue, 17 Jan 2023 10:26:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229803AbjAQP0Z (ORCPT ); Tue, 17 Jan 2023 10:26:25 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1054655BA; Tue, 17 Jan 2023 07:26:24 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F3F610C; Tue, 17 Jan 2023 16:26:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673969181; bh=tSDcjAh6bFmwIhxqPp/jq7QIdOqP7tA6ejjlekmgFZo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BVlO2NPSanLnnpZ9sV70KYrrQe9hv2XFk89MRzJJ55jCEXhtEy0oWi7C3t5UzIqsr pq9GIkxGnIyLgvxDX1ajQ777N9AA2NfaRG1WJVmsPC/oEXti4UF4QHn96Ae6cKXVTL QEnC9WZFMQMXpfkUfgATNOUrxNC/JDtxvoTpnsY8= Date: Tue, 17 Jan 2023 17:26:22 +0200 From: Laurent Pinchart To: Yuji Ishikawa Cc: Hans Verkuil , Mauro Carvalho Chehab , Nobuhiro Iwamatsu , Rob Herring , Krzysztof Kozlowski , "Rafael J . Wysocki" , Mark Brown , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings Message-ID: References: <20230111022433.25950-1-yuji2.ishikawa@toshiba.co.jp> <20230111022433.25950-2-yuji2.ishikawa@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230111022433.25950-2-yuji2.ishikawa@toshiba.co.jp> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Yuji, Thank you for the patch. On Wed, Jan 11, 2023 at 11:24:28AM +0900, Yuji Ishikawa wrote: > Adds the Device Tree binding documentation that allows to describe > the Video Input Interface found in Toshiba Visconti SoCs. > > Signed-off-by: Yuji Ishikawa > Reviewed-by: Nobuhiro Iwamatsu > --- > Changelog v2: > - no change > > Changelog v3: > - no change > > Changelog v4: > - fix style problems at the v3 patch > - remove "index" member > - update example > > Changelog v5: > - no change > --- > .../bindings/media/toshiba,visconti-viif.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > > diff --git a/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml b/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > new file mode 100644 > index 00000000000..71442724d1a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/toshiba,visconti-viif.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba Visconti5 SoC Video Input Interface Device Tree Bindings > + > +maintainers: > + - Nobuhiro Iwamatsu > + > +description: > + Toshiba Visconti5 SoC Video Input Interface (VIIF) > + receives MIPI CSI2 video stream, > + processes the stream with embedded image signal processor (L1ISP, L2ISP), > + then stores pictures to main memory. > + > +properties: > + compatible: > + const: toshiba,visconti-viif > + > + reg: > + items: > + - description: registers for capture control > + - description: registers for CSI2 receiver control Nitpicking, s/registers/Registers/ in the two lines above as you capitalize the descriptions below. > + > + interrupts: > + items: > + - description: Sync Interrupt > + - description: Status (Error) Interrupt > + - description: CSI2 Receiver Interrupt > + - description: L1ISP Interrupt > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: Input port, single endpoint describing the CSI-2 transmitter. I would write description: CSI-2 input port, with a single endpoint connected to the CSI-2 transmitter. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: VIIF supports 2 or 4 data lines s/lines/lanes/ > + $ref: /schemas/types.yaml#/definitions/uint32-array You can drop this line, it's already handled by video-interfaces.yaml. > + minItems: 1 > + maxItems: 4 If only 2 or 4 data lanes are supported, shouldn't minItems be 2 ? > + items: > + minimum: 1 > + maximum: 4 Can the CSI-2 receiver reorder the data lanes ? If not, I think you can write items: - const: 1 - const: 2 - const: 3 - const: 4 > + > + clock-lanes: > + description: VIIF supports 1 clock line s/line/lane/ > + const: 0 I would also add clock-noncontinuous: true link-frequencies: true to indicate that the above two properties are used by this device. Also, mark the properties that are required: required: - data-lanes - clock-lanes I'm wondering, though, if clock-lanes shouldn't be simply omitted. If the hardware doesn't support any other option than using lane 0 for the clock lane (as in, no lane remapping), then you can drop the clock-lanes property completely. > + > +required: > + - compatible > + - reg > + - interrupts > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + viif@1c000000 { > + compatible = "toshiba,visconti-viif"; > + reg = <0 0x1c000000 0 0x6000>, > + <0 0x1c008000 0 0x400>; > + interrupts = , > + , > + , > + ; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + csi_in0: endpoint { > + remote-endpoint = <&imx219_out0>; > + bus-type = <4>; Does the hardware support any other bus type ? If not, you can drop the bus-type. If it does, bus-type should be added to the binding, with the value set to "const: 4". > + data-lanes = <1 2>; > + clock-lanes = <0>; > + clock-noncontinuous; > + link-frequencies = /bits/ 64 <456000000>; > + }; > + }; > + }; > + }; -- Regards, Laurent Pinchart